Received-SPF: pass (google.com: domain of linux-kernel+bounces-190312-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) client-ip=147.75.199.223;
Date: Mon, 27 May 2024 11:24:03 +0200
From: Sebastian Andrzej Siewior <bigeasy@linutronix.de>
To: xu.xin16@zte.com.cn
Cc: john.ogness@linutronix.de, rostedt@goodmis.org, zhang.yunkai@zte.com.cn,
	yang.yang29@zte.com.cn, liu.chun2@zte.com.cn, si.hao@zte.com.cn,
	linux-kernel@vger.kernel.org, linux-rt-users@vger.kernel.org
Subject: Re: [PATCH  5.10-rt] printk: ignore that console preempted by
 irq/softirq
Message-ID: <20240527092403.x2m7SpvL@linutronix.de>
References: <20240523235537910_yxfGMbTcSOmMkcfuK2d8@zte.com.cn>
Precedence: bulk
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable
In-Reply-To: <20240523235537910_yxfGMbTcSOmMkcfuK2d8@zte.com.cn>

On 2024-05-23 23:55:37 [+0800], xu.xin16@zte.com.cn wrote:
> diff --git a/kernel/printk/printk.c b/kernel/printk/printk.c
> index 7f27cfee283e..faab85dd4439 100644
> --- a/kernel/printk/printk.c
> +++ b/kernel/printk/printk.c
> @@ -3735,6 +3735,14 @@ bool pr_flush(int timeout_ms, bool reset_on_progre=
ss)
> diff =3D 0;
>=20
> for_each_console(con) {
> + /*
> + * When we're in the unpreemptible context on the same cpu
> + * with which the thread of console locates on, we should
> + * ignore this console, because it's a vain.
> + */
> + if (!preemptible() && con->thread &&
> + task_cpu(con->thread) =3D=3D smp_processor_id())
> + continue;
> if (!(con->flags & CON_ENABLED))
> continue;
> printk_seq =3D read_console_seq(con);

This does not apply.
There is `may_sleep' set earlier.

There is no console_lock() around for each=E2=80=A6

The other question is which kernel started enforcing might_sleep() for
pr_flush(). This should be applied to all kernel or none so we don't
have random behaviour across kernels (5.4 yes, 5.10 no, 5.15 yes).

This is a delay of max 1 sec during bug() and panic(). Not sure how
"critical" this is=E2=80=A6

Sebastian