Received-SPF: pass (google.com: domain of linux-kernel+bounces-190391-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) client-ip=147.75.80.249;
From: =?UTF-8?q?Ilpo=20J=C3=A4rvinen?= <ilpo.jarvinen@linux.intel.com>
Date: Mon, 27 May 2024 13:03:20 +0300 (EEST)
To: Srinivas Pandruvada <srinivas.pandruvada@linux.intel.com>
cc: Hans de Goede <hdegoede@redhat.com>, 
    Andy Shevchenko <andriy.shevchenko@linux.intel.com>, 
    platform-driver-x86@vger.kernel.org, LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 2/2] platform/x86: ISST: Use only TPMI interface when
 present
In-Reply-To: <20240509230236.1494326-3-srinivas.pandruvada@linux.intel.com>
Message-ID: <d3e92568-3440-cb45-e6b0-90133aa8a9b1@linux.intel.com>
References: <20240509230236.1494326-1-srinivas.pandruvada@linux.intel.com> <20240509230236.1494326-3-srinivas.pandruvada@linux.intel.com>
Precedence: bulk
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="8323328-357872044-1716804200=:1006"

  This message is in MIME format.  The first part should be readable text,
  while the remaining parts are likely unreadable without MIME-aware tools.

--8323328-357872044-1716804200=:1006
Content-Type: text/plain; charset=ISO-8859-15
Content-Transfer-Encoding: QUOTED-PRINTABLE

On Thu, 9 May 2024, Srinivas Pandruvada wrote:

> When the TPMI interface is present, use this interface instead of legacy.
> On some systems legacy IO device is also present. Using both interfaces
> together is confusing and may set the hardware in inconsistent state.
>=20
> When TPMI interface is present, don't load legacy drivers.
>=20
> Signed-off-by: Srinivas Pandruvada <srinivas.pandruvada@linux.intel.com>
> Reviewed-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
> Reviewed-by: Zhang Rui <rui.zhang@intel.com
> ---
>  drivers/platform/x86/intel/speed_select_if/isst_if_common.c | 3 +++
>  1 file changed, 3 insertions(+)
>=20
> diff --git a/drivers/platform/x86/intel/speed_select_if/isst_if_common.c =
b/drivers/platform/x86/intel/speed_select_if/isst_if_common.c
> index f886f9369fad..6283af37e73b 100644
> --- a/drivers/platform/x86/intel/speed_select_if/isst_if_common.c
> +++ b/drivers/platform/x86/intel/speed_select_if/isst_if_common.c
> @@ -775,6 +775,9 @@ int isst_if_cdev_register(int device_type, struct iss=
t_if_cmd_cb *cb)
>  =09if (device_type >=3D ISST_IF_DEV_MAX)
>  =09=09return -EINVAL;
> =20
> +=09if (device_type < ISST_IF_DEV_TPMI && isst_hpm_support)
> +=09=09return -ENODEV;

Reviewed-by: Ilpo J=E4rvinen <ilpo.jarvinen@linux.intel.com>

--=20
 i.

--8323328-357872044-1716804200=:1006--