Received-SPF: pass (google.com: domain of linux-kernel+bounces-190401-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.48.161 as permitted sender) client-ip=147.75.48.161;
Date: Mon, 27 May 2024 12:06:18 +0200
From: Wolfram Sang <wsa+renesas@sang-engineering.com>
To: Christian Brauner <brauner@kernel.org>
Cc: Eric Sandeen <sandeen@redhat.com>, linux-renesas-soc@vger.kernel.org,
	linux-fsdevel@vger.kernel.org,
	Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	"Rafael J. Wysocki" <rafael@kernel.org>,
	David Howells <dhowells@redhat.com>, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] debugfs: ignore auto and noauto options if given
Message-ID: <20240527100618.np2wqiw5mz7as3vk@ninjato>
Mail-Followup-To: Wolfram Sang <wsa+renesas@sang-engineering.com>,
	Christian Brauner <brauner@kernel.org>,
	Eric Sandeen <sandeen@redhat.com>,
	linux-renesas-soc@vger.kernel.org, linux-fsdevel@vger.kernel.org,
	Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	"Rafael J. Wysocki" <rafael@kernel.org>,
	David Howells <dhowells@redhat.com>, linux-kernel@vger.kernel.org
References: <20240522083851.37668-1-wsa+renesas@sang-engineering.com>
 <20240524-glasfaser-gerede-fdff887f8ae2@brauner>
Precedence: bulk
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
	protocol="application/pgp-signature"; boundary="hqjbo2nzioraqstx"
Content-Disposition: inline
In-Reply-To: <20240524-glasfaser-gerede-fdff887f8ae2@brauner>


--hqjbo2nzioraqstx
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

Hi Christian,

> Afaict, the "auto" option has either never existent or it was removed bef=
ore
> the new mount api conversion time ago for debugfs.

Frankly, I have no idea why I put this 'auto' in my fstab ages ago. But
it seems, I am not the only one[1].

[1] https://www.ibm.com/docs/en/linux-on-systems?topic=3Dassumptions-debugfs

> diff --git a/fs/debugfs/inode.c b/fs/debugfs/inode.c
> index dc51df0b118d..713b6f76e75d 100644
> --- a/fs/debugfs/inode.c
> +++ b/fs/debugfs/inode.c
> @@ -107,8 +107,16 @@ static int debugfs_parse_param(struct fs_context *fc=
, struct fs_parameter *param
>         int opt;
>=20
>         opt =3D fs_parse(fc, debugfs_param_specs, param, &result);
> -       if (opt < 0)
> +       if (opt < 0) {
> +               /*
> +                * We might like to report bad mount options here; but
> +                * traditionally debugfs has ignored all mount options
> +                */
> +               if (opt =3D=3D -ENOPARAM)
> +                       return 0;
> +
>                 return opt;
> +       }
>=20
>         switch (opt) {
>         case Opt_uid:
>=20
>=20
> Does that fix it for you?

Yes, it does, thank you.

Reported-by: Wolfram Sang <wsa+renesas@sang-engineering.com>
Tested-by: Wolfram Sang <wsa+renesas@sang-engineering.com>

Happy hacking,

   Wolfram


--hqjbo2nzioraqstx
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQIzBAABCgAdFiEEOZGx6rniZ1Gk92RdFA3kzBSgKbYFAmZUWxYACgkQFA3kzBSg
KbYn7BAAgjXXfe6438wgV+D2SvJ7lziQ32oC2AKs/kiVtJYHQ6vmj9M5fCgIfuNG
5kSvB/KAwYsMIZrEtYmAWJRJAlpUz4PQHxCEGCgD4QktsUTZW8I+7Y4uwI33D+Sf
BbkGsv2sDvTV+LfVp7VSmQRuMHUkJaSYkpDLEpI2I5NRL99KnqplLSuxJi7VtAoJ
sVw4AFj48H3Ea1L78YW7CGUUVE2j9s98NQzKHyBHl4ZALfIvJAvfpJn5LgMOhHEU
C5w0MzKnIh1iUovzqnTVJVok7LpPrVE3pk7KkScGl/0XkKn3AEdegjk4ydf1+9TI
2i5EKQdFyRv1WqsN3HYuRRyaZOhu1HobWpQcBeJ6yZht/OawnopjiQe8CvkJF23p
Dndc97Mc3inp6U03l9gq4zhjMqVzhQQnPp78HXTLUVppxDlfHeMAkxtz0PC/7vQ3
jM4nysaIwvYPItDjVFNyvGMUhdnPb0lKM1gGl5IVnVu7qhsSR5Myx0qwr8XJ6sRV
sSggapJDx0Otpt/M1Rdav3jdHUJvBXAnYTCfOe+x2T2eQLizBp+BY+u6oSbAqpbs
5G34N/rVjerSlrgEqVgK5RRsXu8xxdKdyMxNhKJltAz8oMYOvwuWTKq5NeaCauLf
KOIyxgdi5MP49mjs2CVvnuqoH60dPU0QyPLPJUtwWRhNKn2/Y7s=
=GJ16
-----END PGP SIGNATURE-----

--hqjbo2nzioraqstx--