Received-SPF: pass (google.com: domain of linux-kernel+bounces-190441-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) client-ip=147.75.80.249;
Precedence: bulk
MIME-Version: 1.0
References: <20240522213649.2860-1-W_Armin@gmx.de> <20240522213649.2860-2-W_Armin@gmx.de>
In-Reply-To: <20240522213649.2860-2-W_Armin@gmx.de>
From: "Rafael J. Wysocki" <rafael@kernel.org>
Date: Mon, 27 May 2024 12:45:22 +0200
Message-ID: <CAJZ5v0jVwZJ1Q9XFDMb5E0NmPsj=Z3sC9E9zNTjFH0oWKgpn-g@mail.gmail.com>
Subject: Re: [PATCH 2/2] ACPI: EC: Avoid returning AE_OK upon unknown error
To: Armin Wolf <W_Armin@gmx.de>
Cc: rafael@kernel.org, lenb@kernel.org, linux-acpi@vger.kernel.org, 
	linux-kernel@vger.kernel.org
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

On Wed, May 22, 2024 at 11:37=E2=80=AFPM Armin Wolf <W_Armin@gmx.de> wrote:
>
> If an error code other than EINVAL, ENODEV or ETIME is returned
> by acpi_ec_read()/acpi_ec_write(), then AE_OK is wrongly returned.
>
> Fix this by only returning AE_OK if the return code is 0, and
> return AE_ERROR otherwise.
>
> Signed-off-by: Armin Wolf <W_Armin@gmx.de>
> ---
>  drivers/acpi/ec.c | 4 +++-
>  1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/acpi/ec.c b/drivers/acpi/ec.c
> index a68dce2147a4..68dd17f96f63 100644
> --- a/drivers/acpi/ec.c
> +++ b/drivers/acpi/ec.c
> @@ -1351,8 +1351,10 @@ acpi_ec_space_handler(u32 function, acpi_physical_=
address address,
>                 return AE_NOT_FOUND;
>         case -ETIME:
>                 return AE_TIME;
> -       default:
> +       case 0:
>                 return AE_OK;
> +       default:
> +               return AE_ERROR;
>         }
>  }
>
> --

Applied (with some edits in the subject and changelog) along with the
[1/2] as 6.10-rc material, thanks!