Received: by 2002:a89:d88:0:b0:1fa:5c73:8e2d with SMTP id eb8csp1973581lqb; Mon, 27 May 2024 04:01:43 -0700 (PDT) X-Forwarded-Encrypted: i=3; AJvYcCWyPIDVIlCEHrF7Tym+lCLu3tcarRzePrfTumXVjkYHD6ssQV2eoNTELJT0dakbWtO4fEfXeJbEXaWuFZywcHbdsPUpLDbRskYpo1O+Fg== X-Google-Smtp-Source: AGHT+IHQuRSDC3lfLEJNB5/u3SV+3OzDsXSwUyGPMWQzN5US4OTCZlBCUSMUW3ZdFr+F1TA7UT8z X-Received: by 2002:a17:902:e547:b0:1f4:b72d:a038 with SMTP id d9443c01a7336-1f4b72da2cdmr5633785ad.13.1716807703168; Mon, 27 May 2024 04:01:43 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1716807703; cv=pass; d=google.com; s=arc-20160816; b=q3p1XGQVervjgO6wBLsaAJZqUn3aZtDh0W46JoGaCIH28cBQIZA3qgIhJ+tFw+XbqK dqaOP/JCHaRSALaOMxnnkML7ToyUstFh3TMyCWvrVqWRfIkJ5Nc3HEgJYyaHjwwFjFc6 tIU52yZfqkcoYEnmY4P0Z1gm96dBToA7SPi0xhl+vocQYXGfB97su0TxXq/CN/HkLCGU vUiUsFSIk03fK4NqRv9vJBw+lTKSAJXI9bpj8v6iEPoNyk7hKSVR9rOQT5LZ4/ixxQi+ 0b9xd1LSDeeYuUPrJDGRGFFqwpzMAnP8PpsHO8sHm5nEkHOAX6jZlfL93vUuSkvBYTq5 0F6w== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=in-reply-to:references:to:from:subject:cc:message-id:date :content-transfer-encoding:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:dkim-signature; bh=SCl5FIk5Id/nLQQw5/gf5Kfb9XND05Sm7vVtqyaXE0Q=; fh=GjXiXElhpy4+cxj3bBs8Q/1N5YA6GLJ1qYKc+2tbynY=; b=bGpHvDJ47ziail4syH66RJBhp5DHzHKdu2snHwFr58OqmqJcj7jKebDnWVwUHx+wbx nvIskl1uNpNnU9ocSgT7/VVQqXP9z4DClI++W7SP3/g5ZPZNkMfwTzgA7KoxQeBiWnsu 7tk80ICWrNo7gpkmZxWWpEXSEm5vKAKULihLLPpc8ur/rX96ckkV03b0KE0qFfzlOXuQ yI1U/MLRpWOIYCtQIrY+5xalPKBorSyBA0gFQwq+BiAJf7EEdOKW03DmtqsrirVyvFhJ 4wiESEmeo2aOjUKUqjiBd4+/fsz/yCLcZ9YRWSKFFazsPxPIRk4/FaYjHLLDY3ZB5CEj Atyw==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=mVIYnWm9; arc=pass (i=1 dkim=pass dkdomain=kernel.org); spf=pass (google.com: domain of linux-kernel+bounces-190457-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) smtp.mailfrom="linux-kernel+bounces-190457-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from sv.mirrors.kernel.org (sv.mirrors.kernel.org. [139.178.88.99]) by mx.google.com with ESMTPS id d9443c01a7336-1f44c9cc391si57042735ad.503.2024.05.27.04.01.42 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 27 May 2024 04:01:43 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel+bounces-190457-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) client-ip=139.178.88.99; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=mVIYnWm9; arc=pass (i=1 dkim=pass dkdomain=kernel.org); spf=pass (google.com: domain of linux-kernel+bounces-190457-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) smtp.mailfrom="linux-kernel+bounces-190457-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sv.mirrors.kernel.org (Postfix) with ESMTPS id BCE99284727 for ; Mon, 27 May 2024 11:00:57 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 9F76A13BC20; Mon, 27 May 2024 11:00:51 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="mVIYnWm9" Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C093713B2BC; Mon, 27 May 2024 11:00:50 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1716807650; cv=none; b=lcQvcmPSj/Jg4rfZyV48EqDDwvzqChyH6jCQeftTVOTTvD9LxN1VfNOPazXO7QhACpViD1QHgpBOArsTD+duxcMflVwcsr63Q0fTpXZcquFIvVDMOvkuCS6mu2JNB0+PtTZ0KMvhWALOSyx+Th9s61lVF1nwk5JvfBvkqo7Gyr4= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1716807650; c=relaxed/simple; bh=SCl5FIk5Id/nLQQw5/gf5Kfb9XND05Sm7vVtqyaXE0Q=; h=Mime-Version:Content-Type:Date:Message-Id:Cc:Subject:From:To: References:In-Reply-To; b=R5MhK0yZRhk//YNMNO0O/KYJM8bxBU/oPghUukINflA8YLoPjHvBP279e4BBYamTuwCooZlVfaRnwXzP9T5aryQdqzuU8LKP43pKdoAD2q3N1Tjw32EfcmREBhxmo8/k2MyDa9/n3wxbc8yyQ+swYaR1Lq5bXomIPvWVq3xBA3s= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=mVIYnWm9; arc=none smtp.client-ip=10.30.226.201 Received: by smtp.kernel.org (Postfix) with ESMTPSA id 28CFCC2BBFC; Mon, 27 May 2024 11:00:46 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1716807650; bh=SCl5FIk5Id/nLQQw5/gf5Kfb9XND05Sm7vVtqyaXE0Q=; h=Date:Cc:Subject:From:To:References:In-Reply-To:From; b=mVIYnWm91n62JO71GIWwjjPrEFJvJ9UO/COzMgoLgkR9xLR6oY3y//mDlYvvua5f5 jv3Bv3Nu6MM2Gl+BhZuD1/Fe/Y7LyepDslaw5LVweEkIU0pUq1iJ1dTQA/2UuSbNNJ wk2idr1rNHlsmrgwt0vovrsyyKUlfiv5WAWy98wHaMBpgP/cbh2qFFOZntkYfS+A2q eUAZRNzCzMgzGKyCd1/ecE2bjhHVuENmMSOyB0/zgSYABC3cT7ttvTnbBsdyITFHVy lNA5/QkjgyNb1u3dj9zKY/pizsINBNUtaEn0KaLpCHp/a3GYpFz8XrAv3kIeop8Aam EyCSNgZCfxNSg== Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Mime-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=UTF-8 Date: Mon, 27 May 2024 14:00:45 +0300 Message-Id: Cc: , , , "Peter Huewe" , "Jason Gunthorpe" , "Mimi Zohar" , "David Howells" , "Paul Moore" , "James Morris" , "Serge E. Hallyn" , "Stefan Berger" , "Ard Biesheuvel" , "Mario Limonciello" , , Subject: Re: [PATCH] tpm: Open code tpm_buf_parameters() From: "Jarkko Sakkinen" To: "Paul Menzel" X-Mailer: aerc 0.17.0 References: <20240525154406.4811-1-jarkko@kernel.org> <17bbe39e-3c68-4e0b-9862-9658f684b19e@molgen.mpg.de> In-Reply-To: <17bbe39e-3c68-4e0b-9862-9658f684b19e@molgen.mpg.de> On Sun May 26, 2024 at 8:42 AM EEST, Paul Menzel wrote: > Dear Jarkko, > > > Thank you for your patch. > > Am 25.05.24 um 17:44 schrieb Jarkko Sakkinen: > > With only single call site, this no sense, and it actually slipped out > > this *makes* no sense? Thanks for the remark :-) > > > of the radar during the review. Open code and document the action > > directly to the site, to make it more readable. > > [=E2=80=A6] > > > Kind regards, > > Paul In order not to have to recycle this, does this now make sense to you: https://git.kernel.org/pub/scm/linux/kernel/git/jarkko/linux-tpmdd.git/comm= it/?id=3Db6b88cde77e7c30ab8f534d723ad9c4ec15b7753 Unless actual critical fixes for hmac, probably will save this to v6.11 but with some "real" fixes I'll piggy pack it to rcX. BR, Jarkko