Received: by 2002:a89:d88:0:b0:1fa:5c73:8e2d with SMTP id eb8csp1975295lqb; Mon, 27 May 2024 04:04:30 -0700 (PDT) X-Forwarded-Encrypted: i=3; AJvYcCXNG6ke08FCy54SMke5LCkaK/VsOZzg+FIdtphFei7Oy6Lw8LL7v8xkxA98FLUXH9cdZPz3ELyGeMMV3y/ZreboijihtWBzng7DkT5hgQ== X-Google-Smtp-Source: AGHT+IFFjHCXXvSnfO46265LzphTKc4GTSR5dZyDMJjBV/a9OJ8n1pRlOEVdjIRsQeIX8xrtufm8 X-Received: by 2002:a05:6102:e11:b0:48a:639b:2818 with SMTP id ada2fe7eead31-48a639b2bcamr1096872137.15.1716807870583; Mon, 27 May 2024 04:04:30 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1716807870; cv=pass; d=google.com; s=arc-20160816; b=gLXvoweOIPFvedXoC5HL+FVoQY3abI/oZEBUVXuKScM3sjCvtqhc44tz/WA0xrwLCl sOstvTg7kvce/ZnHsJJYG+vio8ANS2yzlaTmGFJNH/XvNNAczXyBO7hpBTgIkBStpSBA rtUbSlDznFx3yJZSzhjDrirOV+SkbY0HByODc/tCqZSIOQzpFfILRSRimbkdrqzdntdQ 56UdYjw76ugGi/noLmWzsR1zpPhcuCh8ry9SsFKZ+Ue5rXQW0ySqRzgqigzLG23od4Ms 4t6Pqwr9RpoodueneMS/41nwr8nxwtNCDhp8HoMd0pfHkPWnhTq5FHHjl253IFx8HW5Q SFcA== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:list-unsubscribe:list-subscribe:list-id:precedence :references:message-id:subject:cc:to:from:date:dkim-signature; bh=Ikk0MTqK6vpn61sKB0R5HgfSO+QOYsjG/QHNlCN938c=; fh=ppYev6ba+t8Q1o6x3ImvgYFVNs27vE+Lm04nbJCLYSo=; b=VPuRtyufhRKbGGdLnrfWO9m/8nYM07PvTX0BVUKHaRuAaXDkNsf0t6Y17unt+jJ5GO 0VLG1BQAntmWO783gNrj+IDHUPXx83icziNxXVCg53fbgqglXoFpyiC+zhgL0SIGB8bO zuB8gTEn5ApiIG5po2Q3K83it7m13nm0C4QtBwg2iPovWNd5hH/tX94ugYCtlxfQCDW0 d5KkxqyLX/21Ff9LQDUsfIKO/AToXOZqcgA5pETRILkpeyu5SWzB2JRVwiUgNugBf1Z6 X6VhjNZPb3Bz0LyvdjblJHJBn4LNhfcB5oZgFfvGKSfepKe1UNgET6S94pSA9Jr4Dgyq HYMA==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b="S/CGlSq2"; arc=pass (i=1 spf=pass spfdomain=linaro.org dkim=pass dkdomain=linaro.org dmarc=pass fromdomain=linaro.org); spf=pass (google.com: domain of linux-kernel+bounces-190460-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-190460-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from ny.mirrors.kernel.org (ny.mirrors.kernel.org. [2604:1380:45d1:ec00::1]) by mx.google.com with ESMTPS id a1e0cc1a2514c-804cbeb6cf6si1384166241.92.2024.05.27.04.04.30 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 27 May 2024 04:04:30 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel+bounces-190460-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) client-ip=2604:1380:45d1:ec00::1; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b="S/CGlSq2"; arc=pass (i=1 spf=pass spfdomain=linaro.org dkim=pass dkdomain=linaro.org dmarc=pass fromdomain=linaro.org); spf=pass (google.com: domain of linux-kernel+bounces-190460-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-190460-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ny.mirrors.kernel.org (Postfix) with ESMTPS id 23A421C21314 for ; Mon, 27 May 2024 11:04:30 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id A189313C3E6; Mon, 27 May 2024 11:04:15 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="S/CGlSq2" Received: from mail-lj1-f176.google.com (mail-lj1-f176.google.com [209.85.208.176]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id EDE9213B792 for ; Mon, 27 May 2024 11:04:11 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.208.176 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1716807854; cv=none; b=R/yUiefalSAkUVVjd2TjUFKo1PplsmaaZv/AMjnWwp95H6CXa8n+BH/Nz6GifFLVZkRL+ABPunww4Oy+eWwFJBWJlxTXaQegU/0XiHrLb+EESTgl0teiuHzfpAHIPCaxKo+f0pdlwLXVcvck2tc5wJCXutAs5kgrlSB+aMyeCfE= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1716807854; c=relaxed/simple; bh=yuX+wFP7fMTWfpbVBFssj2MGbALckEkCiS/YZH6S6Ns=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=DVz2ojR6lFD8p71mLC7v5ik0X1SHl0pK3nHHYxqAfR0GZrxKFN4XkbqQLYUDhQnBkvRAE2hg90jqd32hoQE3UPU+7fK1GGkkfSqsRJ9NSr8yCp4s+xd4rAYF7CaOn7DHhStPy0XHoK4vhWdC223lr+vVImnGmeL+ZDZoOXPNNcw= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=S/CGlSq2; arc=none smtp.client-ip=209.85.208.176 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Received: by mail-lj1-f176.google.com with SMTP id 38308e7fff4ca-2e95a1d5ee2so59627291fa.0 for ; Mon, 27 May 2024 04:04:11 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1716807850; x=1717412650; darn=vger.kernel.org; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date:from:to :cc:subject:date:message-id:reply-to; bh=Ikk0MTqK6vpn61sKB0R5HgfSO+QOYsjG/QHNlCN938c=; b=S/CGlSq2Gu6GLkF+nsvyeOZcm9yVP7NU2T4WfSBq9q3aKcAoDbP2rwnBYr5DRq9jxY BGRITp02iYr/u8Kc2nBjUCy7Dg8VcHKjamwfktw8Whu+/KsYOhZeZ5ourKfZ8Kbt6B/U R17yhjtP6inoyfyu9KQkxYDuUp1ygvkNMpT5KKarvN9K3+lzf1EAEZWHGfFJIU1PbT0/ etHady4QiTKtBoxtiIcqTDzRrWiAkGHkCLkTKUFv+dQiozwz50Zc+EYGF7W7a9VN0DAN mRdEFCe8Uzpjay2SwUx+hfq1V8yUf2L5BK5/i2ihehEWJB+YVJDCc9C2HlDwbJQZPKc1 qK3A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1716807850; x=1717412650; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=Ikk0MTqK6vpn61sKB0R5HgfSO+QOYsjG/QHNlCN938c=; b=wmoK7cxxpKYXLac20qUQ2WSVEBwoG1+0v1hkQN1UAs5vHvLVpuraDREkfQD5Idq4W5 AhoFG1cZlW26TzWm+/AZ+zcER3mNHzEnnseP/9eDmQavP4W25Sg1hRrr1Y64caCF9oGq CxCv5v1j866GZD7pKBwCfqa5xeG/Uxe7d7MCOhpbSiqQvyX5rsSu6hI3bJDv4E6qpKQb zOBFhGPmgAo0ctQR5xWwiuZLgh/dO8OuraSk5tR7lJScItaqRcplINOha4y+XgDYWMXB QukHibG2OdCrCDCU+qHzVpK6QCWe3zYUY+vLMPf2Wwiml3uVg5G55kSMe+GGS0uZOLqt 6jrQ== X-Forwarded-Encrypted: i=1; AJvYcCVuUA2zCRISBF5nI95HuNXgL/VWlkiDtf2i6ruHRHnvsIAHga7qYygvpOToZJibwz/lK6hKmptZ0gRcQL5YLeIQ4Ye/2mdbcRE+dWza X-Gm-Message-State: AOJu0YwqpgEpWbgIQ2GBD4ZklUZ1UV5R27btVEuqvexmDkTRKpB7dPyQ Qtnmymn1Elk8PCwpH7AOt2RqlV6CbXUHigB59xzJhtauab/gpxdWXY/pNP0XCOw= X-Received: by 2002:a2e:9899:0:b0:2e5:685a:85b5 with SMTP id 38308e7fff4ca-2e95b041622mr74590631fa.1.1716807849899; Mon, 27 May 2024 04:04:09 -0700 (PDT) Received: from eriador.lumag.spb.ru (dzdbxzyyyyyyyyyyyykxt-3.rev.dnainternet.fi. [2001:14ba:a0c3:3a00::227]) by smtp.gmail.com with ESMTPSA id 38308e7fff4ca-2e95bcd7bbcsm19087591fa.32.2024.05.27.04.04.09 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 27 May 2024 04:04:09 -0700 (PDT) Date: Mon, 27 May 2024 14:04:07 +0300 From: Dmitry Baryshkov To: Nikita Travkin Cc: Sebastian Reichel , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Bjorn Andersson , Hans de Goede , Ilpo =?utf-8?B?SsOkcnZpbmVu?= , Bryan O'Donoghue , Heikki Krogerus , Greg Kroah-Hartman , Konrad Dybcio , linux-pm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, platform-driver-x86@vger.kernel.org, linux-usb@vger.kernel.org, linux-arm-msm@vger.kernel.org, Krzysztof Kozlowski Subject: Re: [PATCH v3 1/6] dt-bindings: power: supply: Add Lenovo Yoga C630 EC Message-ID: References: <20240527-yoga-ec-driver-v3-0-327a9851dad5@linaro.org> <20240527-yoga-ec-driver-v3-1-327a9851dad5@linaro.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: On Mon, May 27, 2024 at 03:21:27PM +0500, Nikita Travkin wrote: > Dmitry Baryshkov писал(а) 27.05.2024 15:03: > > From: Bjorn Andersson > > > > Add binding for the Embedded Controller found in the Qualcomm > > Snapdragon-based Lenovo Yoga C630. > > > > Signed-off-by: Bjorn Andersson > > Reviewed-by: Krzysztof Kozlowski > > Signed-off-by: Dmitry Baryshkov > > --- > > .../bindings/power/supply/lenovo,yoga-c630-ec.yaml | 83 ++++++++++++++++++++++ > > 1 file changed, 83 insertions(+) > > > > diff --git a/Documentation/devicetree/bindings/power/supply/lenovo,yoga-c630-ec.yaml b/Documentation/devicetree/bindings/power/supply/lenovo,yoga-c630-ec.yaml > > new file mode 100644 > > index 000000000000..52a302850743 > > --- /dev/null > > +++ b/Documentation/devicetree/bindings/power/supply/lenovo,yoga-c630-ec.yaml > > @@ -0,0 +1,83 @@ > > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) > > +%YAML 1.2 > > +--- > > +$id: http://devicetree.org/schemas/power/supply/lenovo,yoga-c630-ec.yaml# > > Should this binding join aspire1 one in bindings/platform ? Good idea > > Nikita > > > +$schema: http://devicetree.org/meta-schemas/core.yaml# > > + > > +title: Lenovo Yoga C630 Embedded Controller. > > + > > +maintainers: > > + - Bjorn Andersson > > + > > +description: > > + The Qualcomm Snapdragon-based Lenovo Yoga C630 has an Embedded Controller > > + (EC) which handles things such as battery and USB Type-C. This binding > > + describes the interface, on an I2C bus, to this EC. > > + > > +properties: > > + compatible: > > + const: lenovo,yoga-c630-ec > > + > > + reg: > > + const: 0x70 > > + > > + '#address-cells': > > + const: 1 > > + > > + '#size-cells': > > + const: 0 > > + > > + interrupts: > > + maxItems: 1 > > + > > +patternProperties: > > + '^connector@[01]$': > > + $ref: /schemas/connector/usb-connector.yaml# > > + > > + properties: > > + reg: > > + maxItems: 1 > > + > > + unevaluatedProperties: false > > + > > +required: > > + - compatible > > + - reg > > + - interrupts > > + > > +additionalProperties: false > > + > > +examples: > > + - |+ > > + #include > > + i2c1 { > > + clock-frequency = <400000>; > > + > > + #address-cells = <1>; > > + #size-cells = <0>; > > + > > + embedded-controller@70 { > > + compatible = "lenovo,yoga-c630-ec"; > > + reg = <0x70>; > > + > > + interrupts-extended = <&tlmm 20 IRQ_TYPE_LEVEL_HIGH>; > > + > > + #address-cells = <1>; > > + #size-cells = <0>; > > + > > + connector@0 { > > + compatible = "usb-c-connector"; > > + reg = <0>; > > + power-role = "source"; > > + data-role = "host"; > > + }; > > + > > + connector@1 { > > + compatible = "usb-c-connector"; > > + reg = <1>; > > + power-role = "source"; > > + data-role = "host"; > > + }; > > + }; > > + }; > > +... -- With best wishes Dmitry