Received-SPF: pass (google.com: domain of linux-kernel+bounces-190462-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) client-ip=2604:1380:45e3:2400::1;
From: "Sukrit.Bhatnagar@sony.com" <Sukrit.Bhatnagar@sony.com>
To: Pavel Machek <pavel@ucw.cz>
CC: "Rafael J. Wysocki" <rafael@kernel.org>,
        Christian Brauner
	<brauner@kernel.org>,
        "Darrick J. Wong" <djwong@kernel.org>,
        Andrew Morton
	<akpm@linux-foundation.org>,
        "linux-xfs@vger.kernel.org"
	<linux-xfs@vger.kernel.org>,
        "linux-pm@vger.kernel.org"
	<linux-pm@vger.kernel.org>,
        "linux-fsdevel@vger.kernel.org"
	<linux-fsdevel@vger.kernel.org>,
        "linux-kernel@vger.kernel.org"
	<linux-kernel@vger.kernel.org>,
        "linux-mm@kvack.org" <linux-mm@kvack.org>
Subject: RE: [PATCH 0/2] Improve dmesg output for swapfile+hibernation
Thread-Topic: [PATCH 0/2] Improve dmesg output for swapfile+hibernation
Thread-Index: AQHarBuqqIQ7Mttzp0e7Oah3njC7eLGlO2CAgAW3O9A=
Date: Mon, 27 May 2024 11:06:11 +0000
Message-ID: 
 <TYAPR01MB4048D805BA4F8DEC1A12374DF6F02@TYAPR01MB4048.jpnprd01.prod.outlook.com>
References: <20240522074658.2420468-1-Sukrit.Bhatnagar@sony.com>
 <Zk+c532nfSCcjx+u@duo.ucw.cz>
In-Reply-To: <Zk+c532nfSCcjx+u@duo.ucw.cz>
Accept-Language: en-US, ja-JP, en-GB
Content-Language: en-US
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: 
 =?us-ascii?Q?fdx6G9y2aFBp4ZGwDvesiTIl/Vx3Vp66+WwCdnDvKvFCPiorFOzLaRvp38gG?=
 =?us-ascii?Q?lXu0HyXEM5HkjpImjfBnQTfP3LizzT6j2w870tmVrOFO/RuVc9Nxptimb5cC?=
 =?us-ascii?Q?ltRhKVTYXTTgr4ign9LTtSRVIw4FmkF1cN5ANPD5b66y8N8KKDZnayxvNIey?=
 =?us-ascii?Q?mvfFaPO4jKxUDFbrR+/50oGvaRpS3N+DoktkIsojOVPiYSXTYybdCbOLxNFc?=
 =?us-ascii?Q?HIdMjT7pZBC07rYfrxAiL3HXhflhS1qI7D808boPgJALwHqyMft9Erh72vVn?=
 =?us-ascii?Q?hSLcI/yeb2OWEYWtYxNBPjGLcpqKcsgPCMNGu2Spaa1McRdtZTArFim4IBiA?=
 =?us-ascii?Q?XBYVOpylh+s1hjTG2/m26p/4xUSP28DTAhmUOfwybVRHPuml+HNBqHyXQRcI?=
 =?us-ascii?Q?0WczBgAflQNo/JaC2uHTRRkJmO9yZfOlDewRveBNV2vvLPB8mDD4WmgG4DD2?=
 =?us-ascii?Q?9bCyPB58ojsVgiUwrv84oKHnQw9b6/cWoYRT35ybNyjIjF+5qd2GDvnOySJI?=
 =?us-ascii?Q?lYud4A85ibsHhG/oPCYpWHT7itWiuMw5syb59iRmdozONfAruMCYMtQuwWIb?=
 =?us-ascii?Q?enJwDRoCqph0SEBzHCbgNdLpw7kk1QzvE/M2PTRfp5fZXl0lHGyuDDm0XTo4?=
 =?us-ascii?Q?LA7EgE7DYsUXSu0FZaF6tLvC27rQiIRF4JGtUl4LCBIjWCSfjVysziUiW8P3?=
 =?us-ascii?Q?T/lDAOz8XrGoefAVYVGFl6TebQdvqihvnZ0HJc1VUCN5wUgrWEhZIeZ3jp7p?=
 =?us-ascii?Q?68YiJ79jYWru/BwU8e4OZdXcYaYfn/pRhKXpJjn0Sz+zOSPIdBcyVEq+S2v4?=
 =?us-ascii?Q?ESq88zGzZoH5t9Gi4p5UdXOM9pwih6pX2j7rNS9g4apQp97Y1JDNBLgt9G2o?=
 =?us-ascii?Q?zMZQT5Fqp4ormhiSjDMGN1h1reaqiB5mph8Lb2yeq0flc5cDCk3cjVUyy4Tb?=
 =?us-ascii?Q?0aKkePLhlIVZ9ATxsSLfEXcEsFY8/1V8s6ub3WC3wST9PxWyFy5eZ7ajufa9?=
 =?us-ascii?Q?SVoGR0X7wQmtn+5CsyY6hxAuG8NKZvcZmLrb9MOBzdXgnuud1Ft/cPP/xh4B?=
 =?us-ascii?Q?fcnghHSBjjYX14pfZVdIsLbhclHD837D96Kdoqe8oIc3kKAhg33tyHUG8MPM?=
 =?us-ascii?Q?p/DylfUd0NI4xmG7gn8zJFFGXkVtJ2zrxqxFNXZjPzL/wnzf0NEVquWvbo3y?=
 =?us-ascii?Q?3KekATyUHWUtyPcf+kbKZyo3ELDzjeguzkyj3VCbvbw8uvIGXhLZy8/wyrL+?=
 =?us-ascii?Q?zb6A4UzQmngO1THQ/+V7KLNfGhKDYBPx+05ykUP69Dllp48byvj3h8R4P9GV?=
 =?us-ascii?Q?mLD0O/dr9LQ2MAzWgGCG5kdmWd9qnWVz9BwzAMzdKcugB9iZj/c7OBicRXqe?=
 =?us-ascii?Q?742E+zjiLOb84QXT0Rqi0ab4BrFo6MmZdkhVD3CMJXi4xqlSPSLoyKZaDUgv?=
 =?us-ascii?Q?6i2HQnBXJuCV1jx8Xs38oOVXM42UPKXMcc25BpAc5IP3L33B02U5tgVeqQxY?=
 =?us-ascii?Q?E8lOhZBmNxBSujwYTdmAInVBqfUN27knJz5QCRJg6OtNRrYF2x8wzafl5Yx9?=
 =?us-ascii?Q?HlOCOmC4GxgSvbRCvPx2k6Sj1VcLNK8k+1WEBvq1?=
Precedence: bulk
X-Mailing-List: linux-kernel@vger.kernel.org
List-Id: <linux-kernel.vger.kernel.org>
List-Subscribe: <mailto:linux-kernel+subscribe@vger.kernel.org>
List-Unsubscribe: <mailto:linux-kernel+unsubscribe@vger.kernel.org>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: 
	D7n39ht1WNHaS+G4aaVA+pt8R3IE3dNpsDHPYgcYcTViV/ms2EKwHgZYuPcure65Ohrhj4i5yY0jBHmL05yswXK+SIxHJBoIWxm/nvHejVHUMchFHDCdMTUXZZpuQgQQ16K2Iv478c5LI2+C0ZAdjAv5bYbky934nVROyA97AxU7wT0J+LUltOLsHMMVOG0lcywX4qRAIgTbdSS3APS6KaojWFDnqJ0nbkFgEYooqnHrp8x3doqvgPbzemxRruH78Eb6kDdiwMZfHQYdPUpWVVTECk/e8wz5pEsykM62j2yqIgUEQfojXt7OnshBCGfnPJBxFNDvMsFqPTb8G9APQG5ATgaXFGk3Fiif8l5b+wm0t1scmot3ZrINsj9lbnlwXFnldbINriAoys8jQ+uMz2JrB4J8PlthPfnhm80zsYA5HlsQcuGv8e5N69kICgwEezB4WjsibTTlwvMkaDvlnvHWWdiaxbrndDwBEytT0RPsD/bYwtyKoMlc6stlIkLgS1jrhhKqBQv9NzIFkxT2JL+8q6sJOPT3Nicdu4Yu4dUMcOeDpRUC4rF8Gal5L2FqSC6/iy5qkILrRd4J3CzHPjHE1gR2OFmPZI4vtIs7OgPvwGWZOXh4AjfgUh6cp7VF
X-OriginatorOrg: sony.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: TYAPR01MB4048.jpnprd01.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: a48dfd77-1dab-4e5d-da9c-08dc7e3d0470
X-MS-Exchange-CrossTenant-originalarrivaltime: 27 May 2024 11:06:11.1911
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 66c65d8a-9158-4521-a2d8-664963db48e4
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: oZF+nnuh9wPxTocsKtoaSWrF3D1xmvFKDjiR3+t0Gh6+ydAUny7W4Uo4NghQEwug05CBSs1MXmBjj0i0pEWike0B+FgC7N7jobo6sfqr6XI=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: OSZPR01MB6971
X-Proofpoint-ORIG-GUID: 0eGumd5mIWifSoqH5gVp6QHYmSzu06wS
X-Proofpoint-GUID: 0eGumd5mIWifSoqH5gVp6QHYmSzu06wS
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
X-Sony-Outbound-GUID: 0eGumd5mIWifSoqH5gVp6QHYmSzu06wS
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.293,Aquarius:18.0.1039,Hydra:6.0.650,FMLib:17.12.28.16
 definitions=2024-05-27_01,2024-05-24_01,2024-05-17_01

Hi Pavel!

On 2024-05-24 04:45, Pavel Machek wrote:
> Hi!
>=20
>> While trying to use a swapfile for hibernation, I noticed that the suspe=
nd
>> process was failing when it tried to search for the swap to use for snap=
shot.
>> I had created the swapfile on ext4 and got the starting physical block o=
ffset
>> using the filefrag command.
>=20
> How is swapfile for hibernation supposed to work? I'm afraid that
> can't work, and we should just not allow hibernation if there's
> anything else than just one swap partition.

I am not sure what you mean.

We can pass the starting physical block offset of a swapfile into
/sys/power/resume_offset, and hibernate can directly read/write
into it using the swap extents information created by iomap during
swapon. On resume, the kernel would read this offset value from
the commandline parameters, and then access the swapfile.

I find having a swapfile option for hibernate useful, in the scenarios
where it is hard to modify the partitioning scheme, or to have a
dedicated swap partition.

Are there any plans to remove swapfile support from hibernation?

--
Sukrit