Received: by 2002:a89:d88:0:b0:1fa:5c73:8e2d with SMTP id eb8csp1978107lqb; Mon, 27 May 2024 04:09:24 -0700 (PDT) X-Forwarded-Encrypted: i=3; AJvYcCVnUvZdOqE/UgehYCzEMiFYUXhTWVb8vQdlxiQvyapI0Z8CnLVXLFg+sVHaF75RNr0GHxH0sl5yQ4/BzjbPckN1B2T/i5T09iaOiJidVg== X-Google-Smtp-Source: AGHT+IE2RkEUAqDMeZbK7STYdqG+cXNjJHyn3cnRxSYm1WVGZYxE1XyCpxH+2fTCTbz+P+LnqZIP X-Received: by 2002:a17:90a:c7c8:b0:2bd:d6d1:c54a with SMTP id 98e67ed59e1d1-2bf5f4075cbmr7855631a91.40.1716808163967; Mon, 27 May 2024 04:09:23 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1716808163; cv=pass; d=google.com; s=arc-20160816; b=rFFaScQCbdxZdavDzz4ccLgWGOf4lfA0m9xT/pyzZkrINXZKKBtlyWhDxspB+EzgkQ zitLPmOW17iHTlxfjztSzYVi4roOYet42vsQ/IF7SYz5J2V4awPh4IA1JqyXUNtrn+HM OBMaJ/SIgi7NteOK2GeOPhPH7Iz6XKBaRlhsWmmiIhGq7na0Tt7KwfMtPx0qFxznmpoC CJVbo5EYjxvsS2oGGkW75J2djF6+eV+S35l16nZR3NcQqorqzB/embjaM8WTEbBOdxJF j/8ki+4J13/+eewP38q6Mh+XvW/xlSPmLEMxfdyf/vkSwsUanZeESIG86OEltlJtfZqx w9wA== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:references:in-reply-to:message-id :date:subject:cc:to:from:dkim-signature; bh=xxcjw+nPqGEdJw0/SbPX+5mskR6uKuXv0PzckwOH3QA=; fh=TEY5m/Y4wNA6xbTkod+bxT0po2C3ht+AOkOgcSDxnls=; b=xRSKZmom/YhEdON8sOJWM4BcNWxhbM9kYL2tanXlnQGPM7d7+N2xLXgSJVQ9v0sST+ ZkIJVWBKVR5iMc57SZoaW6m13LPpyuf3eNrmnDKTpeRM4r1vDZm45IybyZQs+4n242fN rfmoFktRSkZCNsbwdBTeahzwGiBlzYRIOyCQ1Jm9ITSErzSk9NV+vTqCk0KISlY89aL7 y7mme24RZVBXcFMCrzdm7QXGAfLlLvczwLuOYzxD1bjPljbJG2nlqd9Y40K0AO4SeXcX PUNgH7oK93eZw9aTpK9L9nPWs+l/tXTlGyZ1BJmTLEu4FHAo730HRzgxgBvxXTMNC9Wk eZcA==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=sJxRuRSy; arc=pass (i=1 dkim=pass dkdomain=kernel.org); spf=pass (google.com: domain of linux-kernel+bounces-190463-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-190463-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from sv.mirrors.kernel.org (sv.mirrors.kernel.org. [2604:1380:45e3:2400::1]) by mx.google.com with ESMTPS id 98e67ed59e1d1-2bfc2c5cc43si1966834a91.171.2024.05.27.04.09.23 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 27 May 2024 04:09:23 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel+bounces-190463-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) client-ip=2604:1380:45e3:2400::1; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=sJxRuRSy; arc=pass (i=1 dkim=pass dkdomain=kernel.org); spf=pass (google.com: domain of linux-kernel+bounces-190463-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-190463-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sv.mirrors.kernel.org (Postfix) with ESMTPS id 1EB8D28350A for ; Mon, 27 May 2024 11:09:22 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id D524113C3CC; Mon, 27 May 2024 11:09:13 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="sJxRuRSy" Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E7F7C249FF; Mon, 27 May 2024 11:09:12 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1716808153; cv=none; b=gVlWuUNlmXceAMZsa7lJX5JRFZpecp7ucvAjogpKkb11MLIHAYb4aoRG35tEWq7RlhsGnjPb7TX955n6PXXbRwxSOi9Rn85B0EgKRXGId5yMuPk0zJjjlEnAF143+ZPDK1uctcq8eNqYUzLxZcryEoAucaayqPFPdiEl5d2V0BU= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1716808153; c=relaxed/simple; bh=62hMWxUD6NFUz/J34q8tsRJOtZmuEttxuaWbk0zbTEE=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=p7DTZJw7GtVaSI9fmCX8+AMInk9QPN6dzvcjl7PEj+l+XzW8/W6OybGYnL0YY3pg2sEHXu9tgSiJsL/wP0c1s2yrbIEbuju+A1cGqT79gg+50TppjlUJOle+rl0HK4K/iZgPMSkLIMG9FJQaiLt9o9qIbFRnwyrK+WwXWXj+DUc= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=sJxRuRSy; arc=none smtp.client-ip=10.30.226.201 Received: by smtp.kernel.org (Postfix) with ESMTPSA id 1F31AC2BBFC; Mon, 27 May 2024 11:09:07 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1716808152; bh=62hMWxUD6NFUz/J34q8tsRJOtZmuEttxuaWbk0zbTEE=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=sJxRuRSyF8aZl6lcHv4GNNbUtVqSVlKp+Xe/+i+D6yW1/oO/ot6EalwOzSHtrCo4K s0dQbDVSkXR6WepDxxDij1Q54BKKBWWhdmNiSj8TTkMqt9MTvIiiPdh49TRPO6Pj86 rWP0aK1OzS00I+zfo7KiYPoyReQVkRqVHKqOwaqlnSGP7f2HTBJ/5G1FScQj0Q9Dz8 keqj6K/C1AuubkdWkfcykho2TfTj7Ukds7jbRtwZZjliN36IBWlvehAG7mXvXGjSMy UG9U+OMvUnqNU5ZqRlchB7sVZE4/zAiYA1s8HL5QllUGwa5ynmsu52/Nml3RMEB9vg dGhHN3oDTUPBA== From: Christian Brauner To: David Howells Cc: Christian Brauner , syzbot+df038d463cca332e8414@syzkaller.appspotmail.com, syzbot+d7c7a495a5e466c031b6@syzkaller.appspotmail.com, syzbot+1527696d41a634cc1819@syzkaller.appspotmail.com, Eric Van Hensbergen , Latchesar Ionkov , Christian Schoenebeck , Jeff Layton , Steve French , Hillf Danton , v9fs@lists.linux.dev, linux-afs@lists.infradead.org, linux-cifs@vger.kernel.org, netfs@lists.linux.dev, linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org, Dominique Martinet Subject: Re: [PATCH v3] netfs, 9p: Fix race between umount and async request completion Date: Mon, 27 May 2024 13:09:00 +0200 Message-ID: <20240527-losgefahren-albern-a9b1d8be3835@brauner> X-Mailer: git-send-email 2.43.0 In-Reply-To: <755891.1716560771@warthog.procyon.org.uk> References: <755891.1716560771@warthog.procyon.org.uk> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" X-Developer-Signature: v=1; a=openpgp-sha256; l=1313; i=brauner@kernel.org; h=from:subject:message-id; bh=62hMWxUD6NFUz/J34q8tsRJOtZmuEttxuaWbk0zbTEE=; b=owGbwMvMwCU28Zj0gdSKO4sYT6slMaSFZJ7zelnJM7U+5vs16+iDzU/eHak22+8zK2h3/Nxtx kt0hJJkO0pZGMS4GGTFFFkc2k3C5ZbzVGw2ytSAmcPKBDKEgYtTACbiZ8/wP5lhXd2tnn2lDrHe S064NiWHCmp8PyXfyLxJ4KB6Y7f0U0aGtffmxsec3rSGNywtN+FVmNpSSVFb/R/TPYJj8uSzQl6 wAwA= X-Developer-Key: i=brauner@kernel.org; a=openpgp; fpr=4880B8C9BD0E5106FC070F4F7B3C391EFEA93624 Content-Transfer-Encoding: 8bit On Fri, 24 May 2024 15:26:11 +0100, David Howells wrote: > netfs, 9p: Fix race between umount and async request completion > > There's a problem in 9p's interaction with netfslib whereby a crash occurs > because the 9p_fid structs get forcibly destroyed during client teardown > (without paying attention to their refcounts) before netfslib has finished > with them. However, it's not a simple case of deferring the clunking that > p9_fid_put() does as that requires the p9_client record to still be > present. > > [...] Applied to the vfs.fixes branch of the vfs/vfs.git tree. Patches in the vfs.fixes branch should appear in linux-next soon. Please report any outstanding bugs that were missed during review in a new review to the original patch series allowing us to drop it. It's encouraged to provide Acked-bys and Reviewed-bys even though the patch has now been applied. If possible patch trailers will be updated. Note that commit hashes shown below are subject to change due to rebase, trailer updates or similar. If in doubt, please check the listed branch. tree: https://git.kernel.org/pub/scm/linux/kernel/git/vfs/vfs.git branch: vfs.fixes [1/1] netfs, 9p: Fix race between umount and async request completion https://git.kernel.org/vfs/vfs/c/e20fe12bfb0b