Received-SPF: pass (google.com: domain of linux-kernel+bounces-190470-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:40f1:3f00::1 as permitted sender) client-ip=2604:1380:40f1:3f00::1;
From: "Sukrit.Bhatnagar@sony.com" <Sukrit.Bhatnagar@sony.com>
To: Matthew Wilcox <willy@infradead.org>
CC: Petr Mladek <pmladek@suse.com>, Steven Rostedt <rostedt@goodmis.org>,
        Andy
 Shevchenko <andriy.shevchenko@linux.intel.com>,
        Rasmus Villemoes
	<linux@rasmusvillemoes.dk>,
        Sergey Senozhatsky <senozhatsky@chromium.org>,
        Jonathan Corbet <corbet@lwn.net>, Christoph Lameter <cl@linux.com>,
        Pekka
 Enberg <penberg@kernel.org>,
        David Rientjes <rientjes@google.com>,
        Joonsoo
 Kim <iamjoonsoo.kim@lge.com>,
        Andrew Morton <akpm@linux-foundation.org>,
        Vlastimil Babka <vbabka@suse.cz>,
        Roman Gushchin <roman.gushchin@linux.dev>,
        Hyeonggon Yoo <42.hyeyoo@gmail.com>,
        Masami Hiramatsu <mhiramat@kernel.org>,
        Mathieu Desnoyers <mathieu.desnoyers@efficios.com>,
        "linux-doc@vger.kernel.org" <linux-doc@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "linux-mm@kvack.org" <linux-mm@kvack.org>,
        "linux-trace-kernel@vger.kernel.org" <linux-trace-kernel@vger.kernel.org>
Subject: RE: [PATCH 2/2] mm: debug: print correct information for slab folios
Thread-Topic: [PATCH 2/2] mm: debug: print correct information for slab folios
Thread-Index: AQHarBujHL/xNkAGiUyj8nEOMN94/7GjL+8AgAe8CtA=
Date: Mon, 27 May 2024 10:46:19 +0000
Message-ID: 
 <TYAPR01MB4048A7A5E95A4BB4BAE9A202F6F02@TYAPR01MB4048.jpnprd01.prod.outlook.com>
References: <20240522074629.2420423-1-Sukrit.Bhatnagar@sony.com>
 <20240522074629.2420423-3-Sukrit.Bhatnagar@sony.com>
 <Zk3lzjVbXVrLW0XR@casper.infradead.org>
In-Reply-To: <Zk3lzjVbXVrLW0XR@casper.infradead.org>
Accept-Language: en-US, ja-JP, en-GB
Content-Language: en-US
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: 
 =?us-ascii?Q?+ajgu1Wp7E4QPELBh1Q6G79kflYCPc31zZYMKYVDu93GySK+IvJRGW8qzpga?=
 =?us-ascii?Q?O+pr1it4+IPDHgKPTaHyi4vTBNvJ8oihUBaCVEl7WjIOp0abjXJ0y5JOBYTQ?=
 =?us-ascii?Q?tPWpDGmrtNbhk1VyFR8wiHMGT9JcHjQ57/kbJz/N22T5VQHHpsR/h+lwLAAj?=
 =?us-ascii?Q?IjNOmymqkMg8HEL562ckxYHeZAYcKG7icG0IBRXPHHC2AoPOVb7JsQLaQ/VV?=
 =?us-ascii?Q?QuQIl9M8DHWv5HYzyy/+4ClmlWJVRSW04cms1J8olK5p+009vbhVJKXoN9nK?=
 =?us-ascii?Q?w0zgdk9XMelclQv//3vlpeRsi8Zt6CkwQmxjBO42n9ZUEDcGIr6vKfwHYzIJ?=
 =?us-ascii?Q?iFWM3j7HcHsGk2pwiEc3Pi/cIFplbq/a6s+BWCUJOFaXP6TGdyf1+w+GgJ8X?=
 =?us-ascii?Q?AVXUczWGPy1KgPMtZ4B/qJexy5jLLvEyscyjGqHqvX5UoY/B3C0cfkobBmDn?=
 =?us-ascii?Q?H8zcl9igcEh3my/n9HM9L74IK4vHJIIyuQHacKSyqmcqVwy/PhD5ewC7+KX1?=
 =?us-ascii?Q?4kAHL/lMfe9Pb2Sc918mFIOIvozsp2AlhTblQD1Uvs1FUdgyoJU7kiw/DR0P?=
 =?us-ascii?Q?r0D07LG31g7sOYR8RZbVC6Mayk8RrfHgE4gBLSPKJT3ZW/xmmX1LlftIAQLq?=
 =?us-ascii?Q?Px90OYy29CegkkqG4y7o0OhYrtMbevUOXOnp0jwHBtAvURK8grntavmngL6S?=
 =?us-ascii?Q?YNJOxQ3Q0gSscfmMvsQT+XgpCa+gX+XEQVO9fJFrKeDTxc6HS8S8IJ+cKI/q?=
 =?us-ascii?Q?jrIDWDop+7d2xG+iCPRICERQZ0FAbXGcXDUg5tmn92hc2paaaKGzm6oPnlot?=
 =?us-ascii?Q?cS/GUJZdMTnSSCv0AQUfdJgcnA/jbfBeD9l1ojQa732CoS8yq62OyalQcni4?=
 =?us-ascii?Q?JBoEp5ZVemMb0o8r8L0uMV0o8rzoadbq2cDnA/t/9r9IrJlMsCm4O9BiF4TT?=
 =?us-ascii?Q?wNm9CX7Bn5fLpQGlUhPtM1IFHZOJ34T/BDhLXLZgRyqpgzB16FGuK6WVShBL?=
 =?us-ascii?Q?8YM56fdSywyyRJp6Psyj3apfUh1nReIjT4+8MikejatSGnSlvhdAbV/azz3w?=
 =?us-ascii?Q?b2mMjKR+DIprLq9Z17FKolHGLOx0v20dZ0m4ZsLndWPXh9XufbrRzvwDAq8M?=
 =?us-ascii?Q?HiNXuMp9rXdEouSqmi1S566HyIppU0DL6xZ8sRq1y8YI6eTEtk6Kh1RIDYqN?=
 =?us-ascii?Q?lt0HDY83sQJ7Yy767bWaaoHzsvYjUELAW1h75e+fHAiD+DsyAbt0Dw1PPioe?=
 =?us-ascii?Q?8NmFaxH4vDPg6h1sU6ItRw19JzPreOy7s2egSWLt1UNyB78l2OH7H7N4Q3wu?=
 =?us-ascii?Q?mr0ijVhOrchI+CV/UhG+p4xTraabQbSYKdcn78hzU8TM42VDfag1rm4pH+xL?=
 =?us-ascii?Q?8ibyH3S9xzKY2MiV+EhWMilePzVxuQZFBRZqFSctuWQti5VdVYMFfK0ZgeiC?=
 =?us-ascii?Q?wO8Uts/gdBH4TihmtY9UOLOSc4ghJdmxieO8N/+FVD6mqjw6R3Tl2OADJLH3?=
 =?us-ascii?Q?apSrUb1BsNFXYokcF2T2BGBxOfYzeXjGSlegk3lkEswv53WYUbTb1afp7sRh?=
 =?us-ascii?Q?qHfqQwHzBtqedqycG0RzjpW/5keXlQMsXFLaS2Fj?=
Precedence: bulk
X-Mailing-List: linux-kernel@vger.kernel.org
List-Id: <linux-kernel.vger.kernel.org>
List-Subscribe: <mailto:linux-kernel+subscribe@vger.kernel.org>
List-Unsubscribe: <mailto:linux-kernel+unsubscribe@vger.kernel.org>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: 
	knUGBC+SYWzlu/+CzFOSd616ppG6YMIvcZ5c6htfwrK4ZQXAGqUc9trFB+dIy7+zpBthXOp7fd2HlBJ0PIUw8bHjsZ7w2cvXVaeRcU6y76EDOQbJVx4WR25VEPmL9RjTz/k2ITMXUEJ/EpbY3gevBTKrJsVcB6Sw7G8/EeLCJNe06TgB8DieQ+MIgzN8Gp9F/g60YAH+dtpL1rr/1jX3w9cx3vniFs2DFsmfkknBATbcCV1d001sbWOS6uNepHSY2PoIbbAXLptaMKV2fc0wkZKwrZqZcBTqOvL/odtH/YZ54xuMFdWUTc2iBzAqXRVYzRORfK9BcftOSFGb+uBDBHtGJN58yhpRx7ymDZHYQIG7mldALw3cQa2PhtX01xc7ZsgJje9nrZC12olZsjnyxdRVmpV+kkmhDE7o9Ri2QlaX5CmdZsmcy5bGrvPw7jhVCGzODDFLtaxevHgkA5Z1+yYxYv/D89Bw5GXzS6T7zxd9uQ43TR3lPD4Th/75u62uoxfEqO5EQFbJM0RUBb0Yc/xMhAbYdqO2YvRJW65xLkitehFSKV4bkAgYlxQQf4jrZT2LO76wGpj2cy4QoHxjY/IbqssYAB3V8NFJyUqBHZY+zD5uLcRZqUEf1UocT0lS
X-OriginatorOrg: sony.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: TYAPR01MB4048.jpnprd01.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 98b94482-785e-47e6-e855-08dc7e3a3df0
X-MS-Exchange-CrossTenant-originalarrivaltime: 27 May 2024 10:46:19.1960
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 66c65d8a-9158-4521-a2d8-664963db48e4
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: ZXsrT8qotow8fMUKLnRPIYhnUoVlNzBDiaHtvlPdXdqgM+AgygbV0KItH6uKjqW5FW5imvcJe5gpV4Pa2ivfUAKdEAEQKKDvqnATJRHx7+I=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: TYCPR01MB6303
X-Proofpoint-ORIG-GUID: YhF108i88Es6Oa7yQSJtmFQaYIyXdSIZ
X-Proofpoint-GUID: YhF108i88Es6Oa7yQSJtmFQaYIyXdSIZ
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
X-Sony-Outbound-GUID: YhF108i88Es6Oa7yQSJtmFQaYIyXdSIZ
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.293,Aquarius:18.0.1039,Hydra:6.0.650,FMLib:17.12.28.16
 definitions=2024-05-26_09,2024-05-24_01,2024-05-17_01

Hi Matthew,

On 2024-05-22 21:32, Matthew Wilcox wrote:
> On Wed, May 22, 2024 at 04:46:29PM +0900, Sukrit Bhatnagar wrote:
>> If the folio tests true for slab, do not print information that does not
>> apply to it. Instead, print the slab flags stored in the kmem_cache fiel=
d.
>>=20
>> [    7.248722] page: refcount:1 mapcount:0 mapping:0000000000000000 inde=
x:0xffff888103e6aa87>
>> [    7.249135] head: order:3 entire_mapcount:0 nr_pages_mapped:0 pincoun=
t:0
>> [    7.249429] slab flags: 0x8000000000000840(slab|head|zone=3D2)
>> [    7.249664] cache flags: 0x10310(HWCACHE_ALIGN|PANIC|TYPESAFE_BY_RCU|=
CMPXCHG_DOUBLE)
>> [    7.249999] raw: 8000000000000000 ffffea00040f9a01 ffffea00040f9bc8 d=
ead000000000400
>=20
> You haven't tested this against the current codebase ...
>
>> @@ -98,6 +101,8 @@ static void __dump_folio(struct folio *folio, struct =
page *page,
>>  		is_migrate_cma_folio(folio, pfn) ? " CMA" : "");
>>  	if (page_has_type(&folio->page))
>>  		pr_warn("page_type: %pGt\n", &folio->page.page_type);
>> +	else if (folio_test_slab(folio))
>> +		pr_warn("cache flags: %pGs\n", &((struct slab *)&folio->page)->slab_c=
ache->flags);
>>=20
>=20
> ... because page_has_type() is now true for slab; there is no more
> PG_slab.  I think you also want:
>=20
> 	folio_slab(folio)->slab_cache->flags

I didn't notice your other patch about removing PG_slab; it pretty much sol=
ves
this issue and much more.
(I had created these patches a few weeks ago.)

> Anyway, we have print_slab_info() which is currently static in slub.c.
> Maybe that needs to become non-static and dump_page() should call that
> for slabs?

Thank you for the suggestions.

print_slab_info() has a slightly different output string format, which does=
 not
match with the dump_page() output style.
Adding it as-it-is looks a bit weird to me.
Other than that, I think it may be useful to print it (which would happen o=
nly
when SLAB_DEBUG is enabled).

Also: print_slab_info() is printing the folio's flags. Maybe that needs a c=
hange?

--
Sukrit