Received: by 2002:a89:d88:0:b0:1fa:5c73:8e2d with SMTP id eb8csp1997064lqb; Mon, 27 May 2024 04:50:04 -0700 (PDT) X-Forwarded-Encrypted: i=3; AJvYcCVFjqrRW9svyfCkBc8wurIysLcjaoodGsP4Od0xu7QXCoIBAuIb4drl+NOUECUlMaJoBDGdWA9rrLw99hoEPfNILoaQLevPtpuHBJwHQg== X-Google-Smtp-Source: AGHT+IFv8OQ+oP3JjYYotWDGkc9Yzu2R//QSe5C41j4zh8lKAJZAmkV7hxamYy2q3Uxho86fyI+D X-Received: by 2002:a17:90a:9ac:b0:2bf:8eef:ab3e with SMTP id 98e67ed59e1d1-2bf8eefac04mr5177775a91.15.1716810604583; Mon, 27 May 2024 04:50:04 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1716810604; cv=pass; d=google.com; s=arc-20160816; b=iFputmpjt3s7nSTvHfhK+OvX5ZpNPbE0x0V4gIYbT3Mm+pRTG7WWaFSZB0ZjM0CTVd b6FLbsVIjkn7g5OuLy3gss9CAy0382rS1LfhyTBTJQtW8IVQq7Ti6MU5ymaqxBtSNMPn qQIkGpjY7/T49BVyOhphA53vmmopr97DsWdNorDQcNGoIAlGKFpIrj2p1vq/MVlN1GPL kqdtpz9wkoobuiWZRmrZhOFdsO0AfJCr688hAXyfmIMe2DqSjDr1TlkO/C/snv5ceEkh PQSVNx2Yhh4KQwWA37d/wm7F/XNUC58h78tmLtzveUalJI1QHdpOMIKMozWiGQJGpOvo bJjw== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:message-id:date:subject:cc:to :from:dkim-signature; bh=LZDFs+EfwGumJItQ2ccG0Q/lf1bl4Vi0YX3CxfEyHHM=; fh=+fEw3/zQrmpgsgtgl9f9CsaDRovpb+9b/IJZeo8A5zw=; b=L3fPxLRsmtP+XTRZQbgaK2TVXYqZfCpirxUE9V5ENku6A0+1SR3YFYd527SoqbAU3g lRPHAVeiP5zPXceKGe66WOORZupW/2HfzZ2LTtZ9EIZ9zFjYUt+x4ZOGxlH5lWl225HE M1XIRp7gJP0NmSqCyVESJlpLmEUkEjODzRLmRwBofLal6vQ7zPEvk9713bubpedIXVVo ov0dIGPMzf0tz3YyRmGfxy/fbV6IS+e/fvZqrwosuXORaZFe1UiTBi5Lo8t9NKoCqm1m GGIUtP1v7XLUPbDsIh+lhGmot/OkyJL++cbQcE4YDWwoDB1ULjVR89X62Cz3SgjlWDUt xxKg==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@habana.ai header.s=default header.b=AVTOolle; arc=pass (i=1 spf=pass spfdomain=habana.ai dkim=pass dkdomain=habana.ai dmarc=pass fromdomain=habana.ai); spf=pass (google.com: domain of linux-kernel+bounces-190504-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) smtp.mailfrom="linux-kernel+bounces-190504-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=habana.ai Return-Path: Received: from sv.mirrors.kernel.org (sv.mirrors.kernel.org. [139.178.88.99]) by mx.google.com with ESMTPS id 98e67ed59e1d1-2bdd9f4d8desi8033165a91.119.2024.05.27.04.50.04 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 27 May 2024 04:50:04 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel+bounces-190504-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) client-ip=139.178.88.99; Authentication-Results: mx.google.com; dkim=pass header.i=@habana.ai header.s=default header.b=AVTOolle; arc=pass (i=1 spf=pass spfdomain=habana.ai dkim=pass dkdomain=habana.ai dmarc=pass fromdomain=habana.ai); spf=pass (google.com: domain of linux-kernel+bounces-190504-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) smtp.mailfrom="linux-kernel+bounces-190504-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=habana.ai Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sv.mirrors.kernel.org (Postfix) with ESMTPS id E0BE6283B5B for ; Mon, 27 May 2024 11:50:03 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 9A16C15EFA3; Mon, 27 May 2024 11:48:45 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=habana.ai header.i=@habana.ai header.b="AVTOolle" Received: from mail02.habana.ai (habanamailrelay02.habana.ai [62.90.112.121]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 486CA15E5BE for ; Mon, 27 May 2024 11:48:43 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=62.90.112.121 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1716810524; cv=none; b=XraOimwGCi9npm6mwEh4ddC9iXEGGUAZl48JDmnx7nbWByf2Gyaowt/tIeW/ZKv2tOI1eaQ70CqszIJxMjHzmRWM2GNYR3BEDGqW+tAT3YU3/irSM95roalFw8foKt8bA8Uz1zwxIcHTTdW+P2xfZspcPpdKKUk4sNfa1grBr1A= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1716810524; c=relaxed/simple; bh=x6tqM8fBidIiiw78QtTBz20JiOc/vpqs+EK1lmsNOKc=; h=From:To:Cc:Subject:Date:Message-Id:MIME-Version; b=W5AwYAplJz+J3OHiW0j/ZNmh2Febeh5J65pdDskT/PTkWmX2sx6YAzXvYJw6rwO6gBcbv6spQFe8sDHR6uLXY1fqoWSEOJNkE9OmRI6ie1RVdRd831WAf9CHdQnJ7BXxYjoFJej8F+h2msJaa/v7KdZv9++clw6LWirSEbWX/IA= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=habana.ai; spf=pass smtp.mailfrom=habana.ai; dkim=pass (2048-bit key) header.d=habana.ai header.i=@habana.ai header.b=AVTOolle; arc=none smtp.client-ip=62.90.112.121 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=habana.ai Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=habana.ai Received: internal info suppressed DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=habana.ai; s=default; t=1716810481; bh=x6tqM8fBidIiiw78QtTBz20JiOc/vpqs+EK1lmsNOKc=; h=From:To:Cc:Subject:Date:From; b=AVTOollesVWN0FmcbNvyWhHx3idcaLiBLndGrGy29oMLV0zD9Hh1W5RfHvjuZjezA OatrqsaEv+J9DiGVdgi3SCJW2gH5BBa0APEBjz1FZzVtyyLOpPSsubXLYt1wqlx3ii 2UyvvWkUWRXBe2vrFufQhEyKohFoP3+ec/jHXfpPxuS5hzSqZDVtZjYqNKZqrKJfEP CkWg3ev1rJFL/MIWnmX56w0Dhzvml8Foz7hC0qwjWvRgO+92UK0zTKnwlqhOd5Lluq hjIkMEeyR5gZo8ajRrILUd+KJz2cM9kQbsZg+B9IxbKyBLPtA++Nq5iqYzFeDfjbnN Geu8CkqVyOfgQ== Received: from obitton-vm-u22.habana-labs.com (localhost [127.0.0.1]) by obitton-vm-u22.habana-labs.com (8.15.2/8.15.2/Debian-22ubuntu3) with ESMTP id 44RBltNf1919357; Mon, 27 May 2024 14:47:55 +0300 From: Ofir Bitton To: dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org Cc: Dani Liberman Subject: [PATCH 1/9] accel/habanalabs: add device name to error print Date: Mon, 27 May 2024 14:47:38 +0300 Message-Id: <20240527114746.1919292-1-obitton@habana.ai> X-Mailer: git-send-email 2.34.1 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit From: Dani Liberman The extra info will help in better traceability and debug. Signed-off-by: Dani Liberman Signed-off-by: Ofir Bitton Reviewed-by: Ofir Bitton --- drivers/accel/habanalabs/common/device.c | 17 ++++++++++------- 1 file changed, 10 insertions(+), 7 deletions(-) diff --git a/drivers/accel/habanalabs/common/device.c b/drivers/accel/habanalabs/common/device.c index 8f92445c5a90..a381ece25592 100644 --- a/drivers/accel/habanalabs/common/device.c +++ b/drivers/accel/habanalabs/common/device.c @@ -439,16 +439,19 @@ static void print_idle_status_mask(struct hl_device *hdev, const char *message, u64 idle_mask[HL_BUSY_ENGINES_MASK_EXT_SIZE]) { if (idle_mask[3]) - dev_err(hdev->dev, "%s (mask %#llx_%016llx_%016llx_%016llx)\n", - message, idle_mask[3], idle_mask[2], idle_mask[1], idle_mask[0]); + dev_err(hdev->dev, "%s %s (mask %#llx_%016llx_%016llx_%016llx)\n", + dev_name(&hdev->pdev->dev), message, + idle_mask[3], idle_mask[2], idle_mask[1], idle_mask[0]); else if (idle_mask[2]) - dev_err(hdev->dev, "%s (mask %#llx_%016llx_%016llx)\n", - message, idle_mask[2], idle_mask[1], idle_mask[0]); + dev_err(hdev->dev, "%s %s (mask %#llx_%016llx_%016llx)\n", + dev_name(&hdev->pdev->dev), message, + idle_mask[2], idle_mask[1], idle_mask[0]); else if (idle_mask[1]) - dev_err(hdev->dev, "%s (mask %#llx_%016llx)\n", - message, idle_mask[1], idle_mask[0]); + dev_err(hdev->dev, "%s %s (mask %#llx_%016llx)\n", + dev_name(&hdev->pdev->dev), message, idle_mask[1], idle_mask[0]); else - dev_err(hdev->dev, "%s (mask %#llx)\n", message, idle_mask[0]); + dev_err(hdev->dev, "%s %s (mask %#llx)\n", dev_name(&hdev->pdev->dev), message, + idle_mask[0]); } static void hpriv_release(struct kref *ref) -- 2.34.1