Received: by 2002:a89:d88:0:b0:1fa:5c73:8e2d with SMTP id eb8csp1998886lqb; Mon, 27 May 2024 04:54:25 -0700 (PDT) X-Forwarded-Encrypted: i=3; AJvYcCXCExHRkJWG3XFHzTVDCxUV5xNIHZqt6GOWT012nIhejIbOmBWmxGRJaINdspgZc2o+rIBPVisGaVhHTmfGRcpKbc7lKcYCU+I8DNYv/g== X-Google-Smtp-Source: AGHT+IGfwhvVtqiEunuU4gZTzeHZZgGIMpaIE/29slnL0xc9ymf355261aBeoNFK0/j3zY7K4ipk X-Received: by 2002:a05:6359:a381:b0:197:b7d8:357b with SMTP id e5c5f4694b2df-197e51017acmr1149296955d.14.1716810865119; Mon, 27 May 2024 04:54:25 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1716810865; cv=pass; d=google.com; s=arc-20160816; b=EBcn492xVjyXw8GnAbLc5QC2X1FO7UGc6MGwZf1EhSoxHqfZ2Oi4omfmGwKvzvTet6 /ELihB5Atj9TWzqyYR6axnh34tejHNkQszMMX0QaaDVbH24NNnQFRF1dNeLqDoci5bys q2DmI0M0y0OWqc+wKJaGOqT8bHUEyeidFJlZ6u02fSMfXJFv03TT7kjw342hpFDrbWmU RYcTebjfzU0ZoBiDa2RTZP8s9g1Kzu4sVHtX28n92jMc6zRLWJDeuWqOTNqKz1dhRIVJ I6u/FnH+M0QdacYDNXt1jfjGgkNbDQLlkCyg52db7XrNU8iidOfr5fgobly1lqkBAjzo PFGw== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:references:in-reply-to:message-id :date:subject:cc:to:from:dkim-signature; bh=3gboNArhl0EDiM8DD0A3vipAdoq3zGd7oMxLIKQYlLo=; fh=apK1POaS46pePSLqHuZV6UJpaSAnb3YNM/T0eSe4Mfg=; b=0JkpcRK4irUY0SbZX197TL3xhxvTzECHusO12Nsi53xcQxzUaWZWCRqEhxQqeWgKuz Iw0mMitUtesm+Ib/HL/HGh1xCykctevt69lK0KRrD2JvwD/8Kv0hMBooaoO+FSO4ehJ+ +U/v/pHsAnabjV93XiHsmhX1mc3qmABF0/WaNADcpKEIdAV1sKE+CLPFkJny+nE6FoaQ M3AUoxPi65DSEtCYhfNCIJCiLm+ib0HEV7dT4blAPgd+8K1I4meziycSVZLVSbthvOCk MajO9T/VMDmg90hqT+CAfUREPxijQJ1+Zo4oTyXJFIbw/eOzy9TBu39BeCbDsHdu4RrQ 0FIg==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@habana.ai header.s=default header.b=hW8JHFtW; arc=pass (i=1 spf=pass spfdomain=habana.ai dkim=pass dkdomain=habana.ai dmarc=pass fromdomain=habana.ai); spf=pass (google.com: domain of linux-kernel+bounces-190502-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.48.161 as permitted sender) smtp.mailfrom="linux-kernel+bounces-190502-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=habana.ai Return-Path: Received: from sy.mirrors.kernel.org (sy.mirrors.kernel.org. [147.75.48.161]) by mx.google.com with ESMTPS id 41be03b00d2f7-682288e7575si6023387a12.451.2024.05.27.04.54.24 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 27 May 2024 04:54:25 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel+bounces-190502-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.48.161 as permitted sender) client-ip=147.75.48.161; Authentication-Results: mx.google.com; dkim=pass header.i=@habana.ai header.s=default header.b=hW8JHFtW; arc=pass (i=1 spf=pass spfdomain=habana.ai dkim=pass dkdomain=habana.ai dmarc=pass fromdomain=habana.ai); spf=pass (google.com: domain of linux-kernel+bounces-190502-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.48.161 as permitted sender) smtp.mailfrom="linux-kernel+bounces-190502-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=habana.ai Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sy.mirrors.kernel.org (Postfix) with ESMTPS id B8E4FB235E4 for ; Mon, 27 May 2024 11:49:40 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 56DA615E5D5; Mon, 27 May 2024 11:48:43 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=habana.ai header.i=@habana.ai header.b="hW8JHFtW" Received: from mail02.habana.ai (habanamailrelay02.habana.ai [62.90.112.121]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 1FDA915DBBB for ; Mon, 27 May 2024 11:48:40 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=62.90.112.121 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1716810522; cv=none; b=UT/TMF+6KDDVi4VxcDmudhuOtFb+QZtJgXxpabC3a1JPHLDmuYr4uOijv+XlovVVF7VVDZl9MdKwOv4B3py3sAEizxhyenDbSngy3PGo0J79NChwfXtmKUiGrhzsVA8ugg4LYZsWKTnqDe4pNt7QMucBTeaGsIDq7M47MdjHkps= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1716810522; c=relaxed/simple; bh=ilFlKvDjUOWwDTTLLUhcCL8nUKgNxe8o+4Fl4gvGbvk=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=Y0JOtgjon1ZkGnk8bz1poB2nhFVvyq/tHGQXif5PBx3DwSOInCB5Ykr95p6ZWK1AffLybHP/6Vje9ZeJLCfETPRjIpWVuoOG87UyUGrd8ED1kroAefq8AnBrwMddAPgdMR7HowdvNFMjfcniYZjozivqs+Vt0czmB4cLESXn2JY= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=habana.ai; spf=pass smtp.mailfrom=habana.ai; dkim=pass (2048-bit key) header.d=habana.ai header.i=@habana.ai header.b=hW8JHFtW; arc=none smtp.client-ip=62.90.112.121 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=habana.ai Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=habana.ai Received: internal info suppressed DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=habana.ai; s=default; t=1716810481; bh=ilFlKvDjUOWwDTTLLUhcCL8nUKgNxe8o+4Fl4gvGbvk=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=hW8JHFtWJEuEKxKrXTYIP2v4tu6yLxLvTWog/t/c2BN4HMoSjJ3hkHMgaoJE7p+lV D9Irj8K0sw5TUouEe+9J9kz6NX9U/nVSSoPKTi1agWGUeSVK9g7jxXkzFjnqiWaX4m 4Xu6SvSVloohX0FhzsskLYuc4jvv0O7lible8rPEtZgixSjyVVtPgJkn0hbsApTMGp ea/dAX4OrVpZ4mFoYl1riTMBjQ7vVgzvRDUL40qE+6Gq6PNb3Z78oVPwRManRGcW1A 63B2cekzew7A/erGrhmj5rKktTMUzu9n0hULE/qDI5x16f8t+B7QBuUBHrmV/36lUW DfDfkb94YrOfA== Received: from obitton-vm-u22.habana-labs.com (localhost [127.0.0.1]) by obitton-vm-u22.habana-labs.com (8.15.2/8.15.2/Debian-22ubuntu3) with ESMTP id 44RBltNm1919357; Mon, 27 May 2024 14:47:55 +0300 From: Ofir Bitton To: dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org Cc: Ohad Sharabi Subject: [PATCH 8/9] accel/habanalabs: add device name to invalidation failure msg Date: Mon, 27 May 2024 14:47:45 +0300 Message-Id: <20240527114746.1919292-8-obitton@habana.ai> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20240527114746.1919292-1-obitton@habana.ai> References: <20240527114746.1919292-1-obitton@habana.ai> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit From: Ohad Sharabi This addition helps log parsers better define the error without the need to go back and search the device name on former log lines. Signed-off-by: Ohad Sharabi Reviewed-by: Ofir Bitton --- drivers/accel/habanalabs/common/mmu/mmu.c | 8 +++++--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/drivers/accel/habanalabs/common/mmu/mmu.c b/drivers/accel/habanalabs/common/mmu/mmu.c index 166c7da8b937..a9813ffcde14 100644 --- a/drivers/accel/habanalabs/common/mmu/mmu.c +++ b/drivers/accel/habanalabs/common/mmu/mmu.c @@ -645,7 +645,8 @@ int hl_mmu_invalidate_cache(struct hl_device *hdev, bool is_hard, u32 flags) rc = hdev->asic_funcs->mmu_invalidate_cache(hdev, is_hard, flags); if (rc) dev_err_ratelimited(hdev->dev, - "%s cache invalidation failed, rc=%d\n", + "%s: %s cache invalidation failed, rc=%d\n", + dev_name(&hdev->pdev->dev), flags == VM_TYPE_USERPTR ? "PMMU" : "HMMU", rc); return rc; @@ -660,8 +661,9 @@ int hl_mmu_invalidate_cache_range(struct hl_device *hdev, bool is_hard, asid, va, size); if (rc) dev_err_ratelimited(hdev->dev, - "%s cache range invalidation failed: va=%#llx, size=%llu, rc=%d", - flags == VM_TYPE_USERPTR ? "PMMU" : "HMMU", va, size, rc); + "%s: %s cache range invalidation failed: va=%#llx, size=%llu, rc=%d", + dev_name(&hdev->pdev->dev), flags == VM_TYPE_USERPTR ? "PMMU" : "HMMU", + va, size, rc); return rc; } -- 2.34.1