Received-SPF: pass (google.com: domain of linux-kernel+bounces-190518-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) client-ip=2604:1380:4601:e00::3;
Date: Mon, 27 May 2024 13:54:29 +0200
From: Michal =?utf-8?Q?Koutn=C3=BD?= <mkoutny@suse.com>
To: "T.J. Mercier" <tjmercier@google.com>
Cc: Tejun Heo <tj@kernel.org>, Zefan Li <lizefan.x@bytedance.com>, 
	Johannes Weiner <hannes@cmpxchg.org>, shakeel.butt@linux.dev, cgroups@vger.kernel.org, 
	linux-kernel@vger.kernel.org
Subject: Re: [RFC] cgroup: Fix /proc/cgroups count for v2
Message-ID: <rwb5lqorevlmywo6da623oc4vacy3wjfxaokfx3it52fkvhrvx@qyef5cmd5sgr>
References: <20240519174650.559538-1-tjmercier@google.com>
 <h5xdtfh7dc4rjh74b4cwkpjszro73hfbxzdobwtivyx4hl4hyn@p5lp5h5gzjuj>
 <CABdmKX149mbOkjo6fwZdx1LKX+xXH1TicUx+92Ud99RS9hSy7A@mail.gmail.com>
Precedence: bulk
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
	protocol="application/pgp-signature"; boundary="7ypbevvviesi2cei"
Content-Disposition: inline
In-Reply-To: <CABdmKX149mbOkjo6fwZdx1LKX+xXH1TicUx+92Ud99RS9hSy7A@mail.gmail.com>


--7ypbevvviesi2cei
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Fri, May 24, 2024 at 10:36:45AM GMT, "T.J. Mercier" <tjmercier@google.co=
m> wrote:
> On Fri, May 24, 2024 at 7:23=E2=80=AFAM Michal Koutn=C3=BD <mkoutny@suse.=
com> wrote:
> Sometimes? Take freezer as an example. If you don't mount it on v1
> then /proc/cgroups currently advertises the total number of v2
> cgroups. I thought that was reasonable since there exists a
> cgroup.freeze in every cgroup, but does freezer really count as a
> controller in this case?

v1 freezer controller and freezing implementation in v2 are different
things.
Before v1 mounting, the freezer* entry points to the v2 hierarchy (which
causes listing it as realized for each (v2) cgroup but that's not true).

> There's no freezer css for each cgroup=20

Exactly.

> so I guess the better answer is just to report 1 like you suggest.

It matches better the reality of alloc'd css objects.

Michal

*) Same for any v1-only controller.

--7ypbevvviesi2cei
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iHUEABYKAB0WIQQpEWyjXuwGT2dDBqAGvrMr/1gcjgUCZlR0agAKCRAGvrMr/1gc
jrqRAP9TQP6j5DmHoxLheRwnbqIY6gmYi7uqeFtypt2h0JJDPgEA+TjFacW3QA0k
c8Uy1NUReoZDyx4nhMhOQXRT2wFcygQ=
=Vtbf
-----END PGP SIGNATURE-----

--7ypbevvviesi2cei--