Received-SPF: pass (google.com: domain of linux-kernel+bounces-190566-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.48.161 as permitted sender) client-ip=147.75.48.161;
Date: Mon, 27 May 2024 14:19:01 +0200
From: Christian Brauner <brauner@kernel.org>
To: Wolfram Sang <wsa+renesas@sang-engineering.com>
Cc: Eric Sandeen <sandeen@redhat.com>, linux-renesas-soc@vger.kernel.org, 
	linux-fsdevel@vger.kernel.org, Greg Kroah-Hartman <gregkh@linuxfoundation.org>, 
	"Rafael J. Wysocki" <rafael@kernel.org>, David Howells <dhowells@redhat.com>, 
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH] debugfs: ignore auto and noauto options if given
Message-ID: <20240527-pittoresk-kneipen-652000baed56@brauner>
References: <20240522083851.37668-1-wsa+renesas@sang-engineering.com>
 <20240524-glasfaser-gerede-fdff887f8ae2@brauner>
 <20240527100618.np2wqiw5mz7as3vk@ninjato>
Precedence: bulk
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
In-Reply-To: <20240527100618.np2wqiw5mz7as3vk@ninjato>

On Mon, May 27, 2024 at 12:06:18PM +0200, Wolfram Sang wrote:
> Hi Christian,
> 
> > Afaict, the "auto" option has either never existent or it was removed before
> > the new mount api conversion time ago for debugfs.
> 
> Frankly, I have no idea why I put this 'auto' in my fstab ages ago. But
> it seems, I am not the only one[1].
> 
> [1] https://www.ibm.com/docs/en/linux-on-systems?topic=assumptions-debugfs
> 
> > diff --git a/fs/debugfs/inode.c b/fs/debugfs/inode.c
> > index dc51df0b118d..713b6f76e75d 100644
> > --- a/fs/debugfs/inode.c
> > +++ b/fs/debugfs/inode.c
> > @@ -107,8 +107,16 @@ static int debugfs_parse_param(struct fs_context *fc, struct fs_parameter *param
> >         int opt;
> > 
> >         opt = fs_parse(fc, debugfs_param_specs, param, &result);
> > -       if (opt < 0)
> > +       if (opt < 0) {
> > +               /*
> > +                * We might like to report bad mount options here; but
> > +                * traditionally debugfs has ignored all mount options
> > +                */
> > +               if (opt == -ENOPARAM)
> > +                       return 0;
> > +
> >                 return opt;
> > +       }
> > 
> >         switch (opt) {
> >         case Opt_uid:
> > 
> > 
> > Does that fix it for you?
> 
> Yes, it does, thank you.
> 
> Reported-by: Wolfram Sang <wsa+renesas@sang-engineering.com>
> Tested-by: Wolfram Sang <wsa+renesas@sang-engineering.com>

Thanks, applied. Should be fixed by end of the week.