Received-SPF: pass (google.com: domain of linux-kernel+bounces-190611-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) client-ip=147.75.199.223;
From: "Sukrit.Bhatnagar@sony.com" <Sukrit.Bhatnagar@sony.com>
To: Christoph Hellwig <hch@infradead.org>
CC: Pavel Machek <pavel@ucw.cz>, "Rafael J. Wysocki" <rafael@kernel.org>,
        Christian Brauner <brauner@kernel.org>,
        "Darrick J. Wong"
	<djwong@kernel.org>,
        Andrew Morton <akpm@linux-foundation.org>,
        "linux-xfs@vger.kernel.org" <linux-xfs@vger.kernel.org>,
        "linux-pm@vger.kernel.org" <linux-pm@vger.kernel.org>,
        "linux-fsdevel@vger.kernel.org" <linux-fsdevel@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "linux-mm@kvack.org" <linux-mm@kvack.org>
Subject: RE: [PATCH 0/2] Improve dmesg output for swapfile+hibernation
Thread-Topic: [PATCH 0/2] Improve dmesg output for swapfile+hibernation
Thread-Index: AQHarBuqqIQ7Mttzp0e7Oah3njC7eLGlO2CAgAW3O9CAAATqAIAABjfQ
Date: Mon, 27 May 2024 12:51:07 +0000
Message-ID: 
 <TYAPR01MB40481A5A5DC3FA97917404E2F6F02@TYAPR01MB4048.jpnprd01.prod.outlook.com>
References: <20240522074658.2420468-1-Sukrit.Bhatnagar@sony.com>
 <Zk+c532nfSCcjx+u@duo.ucw.cz>
 <TYAPR01MB4048D805BA4F8DEC1A12374DF6F02@TYAPR01MB4048.jpnprd01.prod.outlook.com>
 <ZlRseMV1HgI4zXNJ@infradead.org>
In-Reply-To: <ZlRseMV1HgI4zXNJ@infradead.org>
Accept-Language: en-US, ja-JP, en-GB
Content-Language: en-US
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: 
 =?us-ascii?Q?Nml9l4MzJhpIK7T7d2zXvBLkIxDrM0Onjcl9OzxSPhdnVTQ8iJEHaJFe+v+r?=
 =?us-ascii?Q?6JETqzEEjj7FTE6S8ZeVA3JJH2tmslM8RRG8yMDesY1Z1/OMhVsq8A2hKZgT?=
 =?us-ascii?Q?7GreRcZJ9gGVuN0BbklZHt5TSCeIiDgNftlTuJzjUMls9x81/6pk8tB5DRBo?=
 =?us-ascii?Q?OkUh3cWUcXldDoZagj5WhqciAdhuyTLLAtowJTMEEPCZT1X6zFeuew6yTPiT?=
 =?us-ascii?Q?JZiKqFwWYSYAFmy5Qpooo86Pu5UsZOSySes5GoxgK0DnNs4AWqoQwybnX23k?=
 =?us-ascii?Q?+tFL7yW1dvYhjcxjKtpL9OPJ5wmiF82wVXtHXwUPavS/0KWWLbLXr9mJMryO?=
 =?us-ascii?Q?7dtZn7XvdOoJcqG2ozTzrxKkndF0e2b4YPUhaxd5kY/gNIFvIxEYEyNxb0Xp?=
 =?us-ascii?Q?LKSqmcwcBOzYQ2ouinabLEfE+O/nhqqqmCWjddWCY2ipsgNUNhJM+T8lkQgg?=
 =?us-ascii?Q?yxzGeKVh9qwWXNBh3u1iMdr/i0D5rK+2tcQxhUtg5CYmrtqjYZdhgi3gs6Ee?=
 =?us-ascii?Q?FhhhdDGu8l31oQ3AXu4kOOH1shOtfqsvZLl+11QiCuP1H09FawKsn19TL59Q?=
 =?us-ascii?Q?IIGwY5j3MjeaSzpgwcS6A0m/IE8t97EccF0yYy7IwgDT/X5i0uFKqezk7xkk?=
 =?us-ascii?Q?dPmFps2R+PodC+geXUZ4lOd1DKkn24zVUSeT537vB9TMcNp6aTjEjVE6OYyX?=
 =?us-ascii?Q?WaDVkSMbMVCssCU16JKWTafCj1Xmqgm7GzT+IJ3rAWDt4YNPB0LI8ikpGaa7?=
 =?us-ascii?Q?cjSKN1ZD9gqaElB7cAs6tTJ3YTo7IJ7JE/bWoMkuMiv46xBieVwcDBiXk8nf?=
 =?us-ascii?Q?+37cbIiM/7GTI1LmSSSSJRWLulAgfOeEfWRot1Oz9fhE99RvdootLvfel6GD?=
 =?us-ascii?Q?/4t16eegc6fwJof5DyCR+i2RrwCD2584ylo6bMzztZnpDW4WC5hXRYjVvlG3?=
 =?us-ascii?Q?fS7YL0b6VsLSnHQFsHL71kzT1MYe4uajixzRisSAf5KhwQobmGu5igjoY6s2?=
 =?us-ascii?Q?J+PjfVJwkHMOQH9nMOj8/DeFcN07NSZB8pqnUOIMcYfm/rU2pKC117pvb5bg?=
 =?us-ascii?Q?DoQrpZXtP3FQl6OtYnAH1qN8B2pljuYV8PMrSRTM/Hl1XscSb2HBaZgNziLT?=
 =?us-ascii?Q?zWilh2xiH0K6ENy8CyaswleEwKf6pQwit4SeTxtBbOyihYrBhbFaqRr+I1a2?=
 =?us-ascii?Q?vG0zU4SGMNxUKLjQiOJWFzX8LaWhQv/KEVRX9KO4Q00Ymqft4phYm70hDkKf?=
 =?us-ascii?Q?1xBUcaNDk/hGcwNolu7zlEDOJHJqkDLgNzCDL5Te+GLbhikTeSbwtDs7kbol?=
 =?us-ascii?Q?9J+GEhD3uNEK03J5LUYgFN9rCW/9An3j8ykGuA/Sis78zHGlMF4l2nQO1bXW?=
 =?us-ascii?Q?0AFkKvh3NdCBndjiwoqnNsE+a2gclWYrccTdd4MbGi+yl2CatovHW08ueVjO?=
 =?us-ascii?Q?cUj4s8AlTostuGfzsBtqwUVRGE72+CU0E0jNC5829y7WdhoVh2AoLePrwkjM?=
 =?us-ascii?Q?TOIlWkA20Hfn/+0wScQP9iLZiT8TzbNpRuCRdBHZ1tPB1aZb4FDjrgZyp0Cr?=
 =?us-ascii?Q?gYQ3o0P0mMVmLh61E9HaZT5ve9BlJuFNEmZSTkttbYzNUyfRHW+G7HmRcZlB?=
 =?us-ascii?Q?PE5B4a24QNLu9o4c37D967NfHhdPEnz/fBn0wMd+ffZg?=
Precedence: bulk
X-Mailing-List: linux-kernel@vger.kernel.org
List-Id: <linux-kernel.vger.kernel.org>
List-Subscribe: <mailto:linux-kernel+subscribe@vger.kernel.org>
List-Unsubscribe: <mailto:linux-kernel+unsubscribe@vger.kernel.org>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: 
	hvmsTXZ2Vun+VSg31JEChK+tDhPj9/lOPKFs6mCYVTgGS5+abEXPvBMIblKPYpcWtJymy1bWn/C6JVRPqYLKjLX1GMQwpOTRP7P33gfsc03GolNPQtGupaTGj/POr3Upjw50oD7f9m6FmV3mfkkYRIAoxvgU89WyOFaba9DDZcNZCVuF3oYYAZyvjyfJOMlHrMWiV+NSbv2E6a/rUWWGsxK9B3W6fjip/49lBFIvJcJ/5K648iUw2SAd91LLlLfp1SPgfHE+jXeFK0QQWHutnUnhEb2PRgqmdn0qY0nwW14HZKLyMAAESuoXg6jYjTusasl/ZbTK2qDv85uzlnNFf8vsk3riIaCdOFc/jsUDP5T3ezdjyPVGZq5ebn0zihTsQHO9IpgRHtqC8f4xMZ3nyZLlh0D9/19dEbO5csJ6yMN1T8Wl00ulQBCy0Cd4CkSOkm5QOz4L2qOxclR0V3Fu3nT0ZiO+v+qmxUoyOX5dcWcJuoOF2U4SNLATzOFXiclnxzfCniHHg+57qsDe+pyoVxqP4CiTQofHTrc6Eeg7zy0aXEiZ+YI4ZORZOHzCSBjXyzBKf8IIiNyUKnQQwqzkeZFSkNVVManZSdDTUzlbdnJRwuWisLJczEUxd7b713sJ
X-OriginatorOrg: sony.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: TYAPR01MB4048.jpnprd01.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: ea657b5d-be93-4782-a4c4-08dc7e4bad12
X-MS-Exchange-CrossTenant-originalarrivaltime: 27 May 2024 12:51:07.0752
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 66c65d8a-9158-4521-a2d8-664963db48e4
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: FV3Y+G5u6rgARZUfE4JVrWi3BipxdeI8nYDTRzcEB+NAcV7YZ2Res+Ixhb6SDB8eJbZU62llEJ1DsUVGZTfoXV0YHFquWwcgIyiCKY5WxXc=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: TYWPR01MB9308
X-Proofpoint-GUID: IfdeQyA8BGmzp-krjflx-Yf6utxDA6Mg
X-Proofpoint-ORIG-GUID: IfdeQyA8BGmzp-krjflx-Yf6utxDA6Mg
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
X-Sony-Outbound-GUID: IfdeQyA8BGmzp-krjflx-Yf6utxDA6Mg
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.293,Aquarius:18.0.1039,Hydra:6.0.650,FMLib:17.12.28.16
 definitions=2024-05-27_02,2024-05-24_01,2024-05-17_01

Hi Christoph,

On 2024-05-27 20:20, Christoph Hellwig wrote:
> On Mon, May 27, 2024 at 11:06:11AM +0000, Sukrit.Bhatnagar@sony.com wrote=
:
>> We can pass the starting physical block offset of a swapfile into
>> /sys/power/resume_offset, and hibernate can directly read/write
>> into it using the swap extents information created by iomap during
>> swapon. On resume, the kernel would read this offset value from
>> the commandline parameters, and then access the swapfile.
>=20
> Reading a physical address from userspace is not a proper interface.
> What is this code even trying to do with it?

I understand your point. Ideally, the low-level stuff such as finding
the physical block offset should not be handled in the userspace.

In my understanding, the resume offset in hibernate is used as follows.

Suspend
- Hibernate looks up the swap/swapfile using the details we pass in the
  sysfs entries, in the function swsusp_swap_check():
  * /sys/power/resume - path/uuid/major:minor of the swap partition (or
                        non-swap partition for swapfile)
  * /sys/power/resume_offset - physical offset of the swapfile in that
                               partition
  * If no resume device is specified, it just uses the first available swap=
!
- It then proceeds to write the image to the specified swap.
  (The allocation of swap pages is done by the swapfile code internally.)
- When writing is finished, the swap header needs to be updated with some
  metadata, in the function mark_swapfiles().
  * Hibernate creates bio requests to read/write the header (which is the
    first page of swap) using that physical block offset.

Resume
- Hibernate gets the partition and offset values from kernel command-line
  parameters "resume" and "resume_offset" (which must be set from
  userspace, not ideal).
- It checks for valid hibernate swap signature by reading the swap header.
  * Hibernate creates bio requests again, using the physical block offset,
    but the one from kernel command-line this time.
- Then it restores image and resumes into the previously saved kernel.

--
Sukrit