Received: by 2002:a89:d88:0:b0:1fa:5c73:8e2d with SMTP id eb8csp2030310lqb; Mon, 27 May 2024 05:54:01 -0700 (PDT) X-Forwarded-Encrypted: i=3; AJvYcCViM0ebZQTZKmm9qR8eAl5N3dc6As6IqbTsv0CtDu1yGVY2llo+SpnW0Q5oMQNf7iPyWE/nrEe1N1r+1LpAHSPjAsr/2F+w3QLF4mwQqw== X-Google-Smtp-Source: AGHT+IEOKfTQR5u2OyNeyhaMCVXvxPWNs9ECjnmy9fx+f+b1d6HPL8L4Kk9HmKRBSi0q78HiDhIg X-Received: by 2002:a05:6a21:62f:b0:1af:f8e7:76d4 with SMTP id adf61e73a8af0-1b212d08708mr8297836637.18.1716814441626; Mon, 27 May 2024 05:54:01 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1716814441; cv=pass; d=google.com; s=arc-20160816; b=xLA7nZKL7af4WC10pWzegi79aG0e4Dfn+67v7MNs9kzOsb8U1kGafuV60wzsbaqiOR 5LlVbysipZdcynSjIZJjv2xxnsN9D0mBfGEaPee+d3pcfqMluSEn1tq/pGo3WGtfm61s h7/W+WR376F3TqzRC1CFqdDiW3J39UTTZBGcx6ESn/VaE1sbr/+U5y5pbR6FXSRIB9q3 wCsriBMijkwVZ1YQ1FIyP4fgokkhZdQtLUx5Zsjluhp4e4mtXn8Wc/7XdX/1IUxPwBFG 7/9qCZI/AgK8whI19A92yYC6y6qvdPR1qY1Us6fw9mKZuTwCS77tGWbYM0DSLJDODez/ JfKQ== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:list-unsubscribe:list-subscribe :list-id:precedence:dkim-signature; bh=n38xc1OaRNv1MJQDIDghtRWtDAZeB5O1XOyPBUpnu/Y=; fh=m68ywPstd2SK4KP/JX+VenL3dr0MlPCmrzKvIFLWW54=; b=0dXQ21eeyFj41m6Xn66N+4wR84R8AQt4DVzO9enhLNVXi9epoUgehDvikefAi+aOyF VwjEyoCk7imQB8fRtrw+9IaV3hzcicH2WQGVxYgTsKqrsd1oSwggRbkpZ+zgHLjy8hPy T3Tp+ojj6UNtjzgj4+SiNvyUNqecw8vBMDr/FHXL5X/Vgj8mtCX+6dQuRW9VfhUpZqOe VBS0arQJmyV3cXYcqO2i+4W6FQ6MO+H0kPcS2bitrans8H7bcETjcV3NeUD8j1Vn22VG fYjQ7OTMeaYFrAq3XZFHK5yu+Oh6hZUbpOpHOdYO7Z53QQzXRcxcgub1Zq/sz4jqa9kv cGjg==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b="fHuA/6Gp"; arc=pass (i=1 spf=pass spfdomain=linaro.org dkim=pass dkdomain=linaro.org dmarc=pass fromdomain=linaro.org); spf=pass (google.com: domain of linux-kernel+bounces-190615-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-190615-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from sv.mirrors.kernel.org (sv.mirrors.kernel.org. [2604:1380:45e3:2400::1]) by mx.google.com with ESMTPS id 41be03b00d2f7-68221b7591dsi6625332a12.98.2024.05.27.05.54.01 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 27 May 2024 05:54:01 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel+bounces-190615-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) client-ip=2604:1380:45e3:2400::1; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b="fHuA/6Gp"; arc=pass (i=1 spf=pass spfdomain=linaro.org dkim=pass dkdomain=linaro.org dmarc=pass fromdomain=linaro.org); spf=pass (google.com: domain of linux-kernel+bounces-190615-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-190615-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sv.mirrors.kernel.org (Postfix) with ESMTPS id 44466281333 for ; Mon, 27 May 2024 12:54:01 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 2264315E5DF; Mon, 27 May 2024 12:53:54 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="fHuA/6Gp" Received: from mail-yb1-f182.google.com (mail-yb1-f182.google.com [209.85.219.182]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E61401DDC9 for ; Mon, 27 May 2024 12:53:51 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.219.182 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1716814433; cv=none; b=HgVY7zqHGYIEhHbpzQk0qi26JTOK+5l1SfK427P/bRs7HnW6eKgQHJCszmPi3UEd4Y3e8c/DriwIjT3jO0D6orwh6fzxQoTKGoRptXGN4iFiPdwOPnExIAO+pYcnng99EsPDFHL1+bZAWdUQf9uYy8wfB0ykZxQN7N8MQFU44XM= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1716814433; c=relaxed/simple; bh=kRzIkfk9aA6AIARat06tGUsnw6dX00qMxa9B4WK7jyU=; h=MIME-Version:References:In-Reply-To:From:Date:Message-ID:Subject: To:Cc:Content-Type; b=GyYKiFNkPW7rP3az3/GxI/EpBn3oysKn9aVu4ooQg7C4wDXfPoPPOq1yJHsvhGHw8QhRQzxRJEXEZMHFFhfwNGZFN40L8XavX1/XXj2f6ixA8Q60sDdbl9nW4IgZvYkg+X71DXpnkxMek8FWhFAhWkMmbrO5IhfYa/quLXFW5tU= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=fHuA/6Gp; arc=none smtp.client-ip=209.85.219.182 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Received: by mail-yb1-f182.google.com with SMTP id 3f1490d57ef6-df771b6cf71so3419972276.2 for ; Mon, 27 May 2024 05:53:51 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1716814431; x=1717419231; darn=vger.kernel.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=n38xc1OaRNv1MJQDIDghtRWtDAZeB5O1XOyPBUpnu/Y=; b=fHuA/6GpxbFta6a2KX9JdEHNG6t+L6ldm26F55NMH3FVFDYSmaI4b8hfgB9elpuPE8 4QOi7ghU1ZJ+aEvgPDvzFMAzicQ9ciDAx4wZlNqt35IGHzvRz8QT4ezg3lVUKMGJ1i8p PasFVK1F3HTj61j90aXdVEKFBGFfKEPbnoLl+0Bmwl5UsrKMduzD1VLlLT7ll4X4CEVB th33+gx5wbhrOy8ArFLXwq8foalOZpDCOLI3ASrnmvhXFhRSm6ePV+/n3Uo3xxp3g8z4 8CjKpD9rPfd7bMqCidsUp07WXvjRshPbpet+UB3iLo7U6uZFvlJdd0dwPA8yT2mKxurM l9cg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1716814431; x=1717419231; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=n38xc1OaRNv1MJQDIDghtRWtDAZeB5O1XOyPBUpnu/Y=; b=GZsn0sqx6ECO3vjvdKDt73gtEJY6NDvIjyHKFIyEvJorY7rknWqXg/psmvb+zvPm/W bJ+OAmYVPtcPzQPUx8aRrGQSmwG0yAHRInXIJYkcVvKTmIdZ7S+MlHkYn7SGrKfhDxnP eeuqI511kiiI9GJM4T+GQryUMWkFq8P7icveNFrc17KZBFQnvLv5mOseNgDZFu1XahX7 vsLtUttHdhK2wt/FDy5mfco0UNmyYsie9F6FgLnnt/mRNLzGx5NO//HsHbuwj20sD24G p3MYcSmhxuWgCLi9wHNLKKFI509CcmwnFVtb4SmfZS0ZX/a+A9yzDIDvn3zv7y60h866 xWYA== X-Forwarded-Encrypted: i=1; AJvYcCWHraJhIAyKf+TEV3bzWBBJQrIUZpeGTEtGnrTMKI7SPqJPk4i3CuV5lw3/j2RSBpGRJGS0BZ85Na3acfLnKMIOXRBiwCU0xj86x3O5 X-Gm-Message-State: AOJu0YxTnJ7DRYrnNu4a8znYhzkY/VfRubnzdGJQCo4uQhlgHpbcErSA 5VDlCc9sCZocVf7PjonNOHbm6kt8GgaXfOnKx1UZFB5JNwpNTcVSZU59Ux03qm3xmFoEjD2VEKJ YwU1RSdbWaBpopjFDca2Tv6SLIxvM6Eisyq+eWw== X-Received: by 2002:a25:ad50:0:b0:df7:887b:abfb with SMTP id 3f1490d57ef6-df7887bb0f3mr6066354276.15.1716814430908; Mon, 27 May 2024 05:53:50 -0700 (PDT) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 References: <20240521-pinctrl-scmi-imx95-v1-0-9a1175d735fd@nxp.com> <20240521-pinctrl-scmi-imx95-v1-3-9a1175d735fd@nxp.com> In-Reply-To: <20240521-pinctrl-scmi-imx95-v1-3-9a1175d735fd@nxp.com> From: Linus Walleij Date: Mon, 27 May 2024 14:53:40 +0200 Message-ID: Subject: Re: [PATCH 3/3] pinctrl: imx: support SCMI pinctrl protocol for i.MX95 To: "Peng Fan (OSS)" Cc: Sudeep Holla , Cristian Marussi , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Shawn Guo , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam , Dong Aisheng , Jacky Bai , linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, imx@lists.linux.dev, linux-gpio@vger.kernel.org, Peng Fan Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Tue, May 21, 2024 at 8:17=E2=80=AFAM Peng Fan (OSS) wrote: > +static int pinctrl_scmi_imx_dt_node_to_map(struct pinctrl_dev *pctldev, > + struct device_node *np, > + struct pinctrl_map **map, > + unsigned int *num_maps) (...) > +static int pinctrl_scmi_imx_pinconf_set(struct pinctrl_dev *pctldev, > + unsigned int pin, > + unsigned long *configs, > + unsigned int num_configs) The code in these functions look suspiciously similar to same code in pinctrl-imx.c, I bet it is copy/pase/modify. Can you look a second time if it is possible to share code between the drivers? It's not super much code, I'm mostly worried about bugs having to be fixed in two places. What is the opinion of the othe i.MX pinctrl maintainers? Yours, Linus Walleij