Received: by 2002:a89:d88:0:b0:1fa:5c73:8e2d with SMTP id eb8csp2050494lqb; Mon, 27 May 2024 06:27:21 -0700 (PDT) X-Forwarded-Encrypted: i=3; AJvYcCXsh0UuGW1eC1jnLFbnGG1UMTJV+kHuBSqnFE19UjB4D7vPITUacvMtmvQGgPowerEOip/PuzAAedcOgBDBKZZmq+tzvB1cuTCQWiwH5A== X-Google-Smtp-Source: AGHT+IFXOsqObC3plwMkA1FbTOdJI+jZMoJ/GkEYqONC68CftMwqr655UP3HTVKzSZDOKcnRFaQq X-Received: by 2002:a17:906:3f87:b0:a59:aa3a:e6b6 with SMTP id a640c23a62f3a-a62641ded24mr554160566b.18.1716816441093; Mon, 27 May 2024 06:27:21 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1716816441; cv=pass; d=google.com; s=arc-20160816; b=F56Xyz5tRZ5IpehlMRSyTuvnLk9fd+ZshBBaPXPHFq8mY9qqCGjXoMaZ/X4A+9EPd5 zKiL4EVdG+8mmNeY1dQ2ZevLLqM84+u+Av6Rs9+Jn1WS6OS8680s/fMRTtsX3yCdX/X9 QNiCqUqq6p40dhX5WLfWlSHMpYgSm1Pt+Hr5ZHThJ/OvYxsQO3how8KVlaO/F9aXwME7 GfGyLjTu46Komhfy/Xz/iwwnK+B34A48eQBqEydiwe/YRsoCb1aITqvTQGAY8eLnBCAv yRAm1FGHJOEVKCisrpr7F23pZz+fieHwebVX7erynUOEjCjWyuhvgPCYw/3+RnPiY5fN 47fA== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=mime-version:list-unsubscribe:list-subscribe:list-id:precedence :user-agent:message-id:date:references:in-reply-to:subject:cc:to :from:dkim-signature; bh=bNW+BY699b5iYr+DDJnoljybPfFAuktSptvDouu8T0c=; fh=3ognBAdOuXuAfXDG9lNjaYTw/RQAfmGmjXdP/QeXG4Q=; b=T+ZoHxRohCMTTkX9LvZnTyX11szjmY+COI+8t6aoYNLEB+T3EygkBzVSk3jCVNN7nE nT+lTWd4IQGf+3NNLwzReoER3eUgUcmWibZDWWUEeOYymiU4nzf1U+REplaiPj5iGhq4 S4yncHuN/zs3nOcwYvtOWF68ydzRsXZGSlRbpoaCGGsgy8vK9mxEd5Doyd/fedSwEIxQ qd92ptukEV4eVZOT/XD/veREHOejhxsfUXNeSiURCOQV3jCATVfvC+k1BEnCT30eYlwN 38xtQx5CS4hJZGXsh3+Mpovb5Ql0STPDcoW4BdvxIkQMLur8lGl6WmBOp047vszWxTcY 3MSA==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=CiZxRfwf; arc=pass (i=1 dkim=pass dkdomain=kernel.org); spf=pass (google.com: domain of linux-kernel+bounces-190691-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) smtp.mailfrom="linux-kernel+bounces-190691-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from am.mirrors.kernel.org (am.mirrors.kernel.org. [147.75.80.249]) by mx.google.com with ESMTPS id a640c23a62f3a-a626cc67682si389072366b.574.2024.05.27.06.27.21 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 27 May 2024 06:27:21 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel+bounces-190691-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) client-ip=147.75.80.249; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=CiZxRfwf; arc=pass (i=1 dkim=pass dkdomain=kernel.org); spf=pass (google.com: domain of linux-kernel+bounces-190691-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) smtp.mailfrom="linux-kernel+bounces-190691-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by am.mirrors.kernel.org (Postfix) with ESMTPS id CC9771F24682 for ; Mon, 27 May 2024 13:27:20 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id B798415ECE0; Mon, 27 May 2024 13:27:14 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="CiZxRfwf" Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id DFC5715ECE7 for ; Mon, 27 May 2024 13:27:13 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1716816434; cv=none; b=g5EQM0Nb8H052SOdfM3Fj784QC6WOCzNL/QzHXRaeHVfrGAgNKbpB8YTQNrijHPzXeiB6HCmqVqXveiErhrvDbOqz3vVXYUjsnhyEOoyc6iCC8cDSC+94SVy56SueelCC8eomRHylb+Bx/araeRLHgBIP12dXGOYILHHErriqaM= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1716816434; c=relaxed/simple; bh=ZyDOV+M5aNRQcxoeRg24V5eddc/YAovsvaL/j6YVyGw=; h=From:To:Cc:Subject:In-Reply-To:References:Date:Message-ID: MIME-Version:Content-Type; b=LMP6cuCplhjvGIWSmlJGFvgU2t3sxT5y4K8H55rtMnnnyPgE472rbpxRFBkXJM6eRWfkzdPHxZ8V545yfBjPrh4LkY9pQOCZQ61rKM04cDRwbkVRKWDocdPuEJxoCYFERVK+BsB+UbkECwghk5FiAxVWZaviTEB+wshzIlgfh8s= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=CiZxRfwf; arc=none smtp.client-ip=10.30.226.201 Received: by smtp.kernel.org (Postfix) with ESMTPSA id 24221C2BBFC; Mon, 27 May 2024 13:27:12 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1716816433; bh=ZyDOV+M5aNRQcxoeRg24V5eddc/YAovsvaL/j6YVyGw=; h=From:To:Cc:Subject:In-Reply-To:References:Date:From; b=CiZxRfwfJp8nIKYRU8dJ5T6vBGq+Bt0Mkn28mthMikZxjE1870baR737ift0Y+t0R uukJ4B6ZoozamSouwyN8VhzVFaLY/afL7Vu+ajw0eiBl9pHbppFk42Sfv1JdO5Opyg LOWpQUrPcypzvWmy3vFRPR3dWLrZ34AaEgPu336YDaBBgCZ+DG8pC0rCImd+gS7b4l uLVRVXRXjuGjp3NCyP3cY/NGxdfvydmMD6Qlt4AqES/KFIxpezDi7Lc4OrmdWTbZfw Jrg70BgDbsSu/Jd8V9BuEwlixKcnzyhu2niHteXuBh46vQUM/yR4vKfnyoFTlw43K0 4X8xpfRj+CBGw== From: Pratyush Yadav To: Michael Walle Cc: Tudor Ambarus , Pratyush Yadav , Miquel Raynal , Richard Weinberger , Vignesh Raghavendra , Ricardo Ribalda , linux-kernel@vger.kernel.org, linux-mtd@lists.infradead.org Subject: Re: [PATCH v2 3/6] mtd: spi-nor: remove .setup() callback In-Reply-To: <20240419141249.609534-4-mwalle@kernel.org> (Michael Walle's message of "Fri, 19 Apr 2024 16:12:46 +0200") References: <20240419141249.609534-1-mwalle@kernel.org> <20240419141249.609534-4-mwalle@kernel.org> Date: Mon, 27 May 2024 15:27:10 +0200 Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain Hi, On Fri, Apr 19 2024, Michael Walle wrote: > With the removal of the Xilinx flashes, there is no more flash driver > using that hook. The original intention was to let the driver configure > special requirements like page size an opcodes. This is already > possible by other means and it is unlikely a flash will overwrite the > (more or less complex) setup function. Just for comparison, I checked if U-Boot does anything with the setup hook that we might also need. It looks like it mostly uses it for handling non-uniform erases on Spansion flashes, since U-Boot doesn't have proper support for them. This shouldn't be needed by Linux since it can already do those erases. Reviewed-by: Pratyush Yadav -- Regards, Pratyush Yadav