Date: Sat, 2 Feb 2008 15:02:33 +0100
From: Sam Ravnborg <sam@ravnborg.org>
To: Peter Teoh <htmldeveloper@gmail.com>
Cc: LKML <linux-kernel@vger.kernel.org>
Subject: Re: Section mismatch warning patch - microcode.c
Message-ID: <20080202140233.GA23877@uranus.ravnborg.org>
References: <804dabb00802020039j7ec7b66dlbf05fc9a80e1600a@mail.gmail.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <804dabb00802020039j7ec7b66dlbf05fc9a80e1600a@mail.gmail.com>
User-Agent: Mutt/1.4.2.1i
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1050
Lines: 31

On Sat, Feb 02, 2008 at 04:39:02PM +0800, Peter Teoh wrote:
> The following errors during compilation is corrected by the following
> patch (against the latest linus tree):
> 
> WARNING: arch/x86/kernel/microcode.o(.exit.text+0x6): Section mismatch
> in reference from the function cleanup_module() to the variable
> .cpuinit.data:mc_cpu_notifier

I have missed this one when I did my last fix to that file.
But your patch is not good.

Annotating the microcode_exit() function with __init will
cause the kernel to drop the code long before we need it.

I will look into this later and post a fix for the warning.

	Sam

> @@ -831,7 +831,7 @@ static int __init microcode_init (void)
>         return 0;
>  }
> 
> -static void __exit microcode_exit (void)
> +static void __init microcode_exit (void)
>  {

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/