Received-SPF: pass (google.com: domain of linux-kernel+bounces-190799-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) client-ip=147.75.199.223;
From: Jani Nikula <jani.nikula@intel.com>
To: Andy Shevchenko <andy.shevchenko@gmail.com>
Cc: linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org,
 intel-gfx@lists.freedesktop.org, Kees Cook <keescook@chromium.org>, Andy
 Shevchenko <andy@kernel.org>
Subject: Re: [PATCH 2/2] drm: use mem_is_zero() instead of !memchr_inv(s, 0, n)
In-Reply-To: <CAHp75Ve0vyOv3KNY_7286wLKd8u6HOvu0Trm17rs46h-BOGsfA@mail.gmail.com>
Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo
References: <20240527094320.2653177-1-jani.nikula@intel.com>
 <20240527094320.2653177-2-jani.nikula@intel.com>
 <CAHp75Ve0vyOv3KNY_7286wLKd8u6HOvu0Trm17rs46h-BOGsfA@mail.gmail.com>
Date: Mon, 27 May 2024 17:08:34 +0300
Message-ID: <87h6ejmjod.fsf@intel.com>
Precedence: bulk
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable

On Mon, 27 May 2024, Andy Shevchenko <andy.shevchenko@gmail.com> wrote:
> On Mon, May 27, 2024 at 12:43=E2=80=AFPM Jani Nikula <jani.nikula@intel.c=
om> wrote:
>>
>> Use the mem_is_zero() helper where possible.
>
> ...
>
>> -       if (memchr_inv(guid, 0, 16) =3D=3D NULL) {
>> +       if (mem_is_zero(guid, 16)) {
>>                 tmp64 =3D get_jiffies_64();
>>                 memcpy(&guid[0], &tmp64, sizeof(u64));
>>                 memcpy(&guid[8], &tmp64, sizeof(u64));
>
> What is the type of guid? Shouldn't it be guid_t with the respective
> guid_is_null()

I can leave out these parts of the patch.

BR,
Jani.

>
> ...
>
>> -       if (memchr_inv(guid, 0, 16))
>> +       if (!mem_is_zero(guid, 16))
>>                 return true;
>
> Ditto.

--=20
Jani Nikula, Intel