Received-SPF: pass (google.com: domain of linux-kernel+bounces-190698-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) client-ip=2604:1380:45e3:2400::1;
Content-Type: text/plain;
	charset=us-ascii
Precedence: bulk
Mime-Version: 1.0 (Mac OS X Mail 16.0 \(3774.600.62\))
Subject: Re: [PATCH] w1: Fix number of bytes in error message
From: Thorsten Blum <thorsten.blum@toblux.com>
In-Reply-To: <98f19584-9851-46f0-a9dc-8dbae1793b72@kernel.org>
Date: Mon, 27 May 2024 15:29:43 +0200
Cc: linux-kernel@vger.kernel.org
Content-Transfer-Encoding: quoted-printable
Message-Id: <C3C8C8AE-C5F8-45CE-8319-0985A78DA91F@toblux.com>
References: <20240513154354.185974-3-thorsten.blum@toblux.com>
 <98f19584-9851-46f0-a9dc-8dbae1793b72@kernel.org>
To: Krzysztof Kozlowski <krzk@kernel.org>

On 27. May 2024, at 13:51, Krzysztof Kozlowski <krzk@kernel.org> wrote:
> On 13/05/2024 17:43, Thorsten Blum wrote:
>> Fix the number of bytes that failed to be allocated for a new w1 =
device.
>>=20
>> Signed-off-by: Thorsten Blum <thorsten.blum@toblux.com>
>> ---
>> drivers/w1/w1_int.c | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>=20
>> diff --git a/drivers/w1/w1_int.c b/drivers/w1/w1_int.c
>> index 3a71c5eb2f83..677e7167806c 100644
>> --- a/drivers/w1/w1_int.c
>> +++ b/drivers/w1/w1_int.c
>> @@ -34,7 +34,7 @@ static struct w1_master *w1_alloc_dev(u32 id, int =
slave_count, int slave_ttl,
>> dev =3D kzalloc(sizeof(struct w1_master) + sizeof(struct =
w1_bus_master), GFP_KERNEL);
>> if (!dev) {
>> pr_err("Failed to allocate %zd bytes for new w1 device.\n",
>> - sizeof(struct w1_master));
>> + sizeof(struct w1_master) + sizeof(struct w1_bus_master));
>=20
> No, instead error message should be dropped. Core handles printing
> memory allocation failures.

Ok, I'll submit a v2 shortly.