Received-SPF: pass (google.com: domain of linux-kernel+bounces-190981-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) client-ip=2604:1380:45d1:ec00::1;
Message-ID: <f59f4cc3-6327-2f1e-dc32-03eeaffe1f54@amd.com>
Date: Mon, 27 May 2024 22:36:57 +0800
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101
 Thunderbird/102.15.0
Subject: Re: [PATCH v3 1/2] x86/cpufeatures: Add AMD FAST CPPC feature flag
Content-Language: en-US
To: Dave Hansen <dave.hansen@intel.com>, Xiaojian Du <Xiaojian.Du@amd.com>,
 linux-kernel@vger.kernel.org, x86@kernel.org, linux-pm@vger.kernel.org
Cc: tglx@linutronix.de, mingo@redhat.com, bp@alien8.de,
 dave.hansen@linux.intel.com, hpa@zytor.com, daniel.sneddon@linux.intel.com,
 jpoimboe@kernel.org, pawan.kumar.gupta@linux.intel.com,
 sandipan.das@amd.com, kai.huang@intel.com, ray.huang@amd.com,
 rafael@kernel.org, Perry.Yuan@amd.com, gautham.shenoy@amd.com,
 Borislav.Petkov@amd.com, mario.limonciello@amd.com
References: <691ec6cf79788e6db919965f787505434b072fac.1716444920.git.Xiaojian.Du@amd.com>
 <5c14a151-25c9-41f5-af65-d2a8ffe548fa@intel.com>
From: Xiaojian Du <xiaojidu@amd.com>
In-Reply-To: <5c14a151-25c9-41f5-af65-d2a8ffe548fa@intel.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?a0hMMjEwd0RSTG5UdnF6VEIrbFhtelhuQmM0dlQzM0RaMndLenJQUzJPMUxF?=
 =?utf-8?B?a01ZVGZ6a00rMXZjbVJHc0VKckNHdExwZFhqeWJyVzd2TGlRMm44RzJCS2s0?=
 =?utf-8?B?Um13YnZEbVZjQ1MrTnE5NjhLWkFTNUxkNGtEUFRRckEvRDJ0TUwvd3FaSXZY?=
 =?utf-8?B?SDhsRkhUMUx3TGUzc0lxakdDSUc5ai84Nlg5SUFyZHFML0ZSSTI5eVdzaTVE?=
 =?utf-8?B?eHlKczlNU2tZRGhUUDJxRC8wSzE1U1VLWHAwdDIwRytnVk9DWjdHWDRaakJI?=
 =?utf-8?B?ejZ1TnkzYXk4RjdvVE5IaDhoTTRUcHlhV00rMldzczgxamk4aVhsVWNRZWhD?=
 =?utf-8?B?Sm5PbVJpL1hmMVY2cXFOeE9kZWdqL1Z5d0hja1lRMXR3dmdIdnI3YXBUamwv?=
 =?utf-8?B?eWVEakdxaUNOUSt5TmVDWFRiVWYxZVkzdjBJMENhbGI1YVBTQitvSW9rNXJw?=
 =?utf-8?B?T3R4RjdwQTFyTmo1anFIVjVCMDZyNVpJQ0ROSzhIOWlQVUJBekhZMXBRTEwz?=
 =?utf-8?B?bDBlTEtkd25JV1BVZlRrL1FjTmdlMUpwc3BkNnZ5RVZ4WWpXNTVxc0llbGxL?=
 =?utf-8?B?Ykd4Ny9XYVoyeklPRWlraWh3bUNKb1VPbTFyVDRReFEzVVJYY0F1Y0ZlMWZD?=
 =?utf-8?B?aG1MdUhxUzFXWGdWMnBIZFY4M3Q4RDdqeUNRU0g2NmFjbHRRam1pRFJDdEZM?=
 =?utf-8?B?WlhTemltcWhNbTk1UFdpWVBTalJUN0V0enU2MG9oME1aNWRyL1pIQWJ2WVZL?=
 =?utf-8?B?Mmk0VE83Z1B5STRJRmw5UFhWV2p6QWt0dmVKaEpjcHRuQ0psTkM3Vy9ld2JT?=
 =?utf-8?B?eVpHSlNuWmJUZ2NyZENweUpJMExYQ1BOQk02Nmh5Nk9LZGNleDY4VFlvajBo?=
 =?utf-8?B?R3Q0VFN6T1pMQkpScEhGYmE1T0daUzN2Tmhvb2JVMEQ3bmRxblpNSjVWcUto?=
 =?utf-8?B?bWxCb3dsbVRzTHlZMjhTYklDRHJxWGl2R2k5Wkc3TDl5L2RHR1dhK2JHL2Yx?=
 =?utf-8?B?VU5WZHNhZnprQ0RMcHo4S0o2WW1SbU5LYnNWRDBFL0Z5R0Y5YnQvYTFSSk82?=
 =?utf-8?B?bi9mRHVLbGFTZmJrcXFBdVIvQ3QxVEhXTDhRcHVWV2Y3RTJJUVRUdTZoWlF5?=
 =?utf-8?B?NGJEdUM0ekNoSVkyM3dmbnJaUFB1V1JJOEoyeU0vZlZnUmRySWZrbld3Q1ly?=
 =?utf-8?B?QVJ4UjR6cGVFbU1xZTJUOXRDUWlzNldSOVJsMDg2V0luYzRWRHhUVmFvaHdh?=
 =?utf-8?B?TmxZWFRaTE16VURYMHNWRWt1QkpVa0FiRnkwb0Y4S2J5SFd6YmtXMlBPdWRB?=
 =?utf-8?B?a2Z4UVFvNTY1WVpPcXVBMjQycmN5R2xQS3hHTCtmNjNYUFVYZXRRMDdJU05y?=
 =?utf-8?B?YTFta2c3azdqM0FWQkw2cVpjTzFNcWxUSGNBeW1yM3VmSEZkeEg1cE5tVXBF?=
 =?utf-8?B?Rld1ckdCR1FONE5FQmZZYW9BdzFEYVMveXVLWG5ZS3pNaktYR2p6SnFVdDcx?=
 =?utf-8?B?SG5uV0JhSHFQYTFJQ0t2OGhQdTc4a1l6N0dkYmlkNWVBOGxSMXp4Ti85MUNs?=
 =?utf-8?B?ejg5Q24xdWNWSGNlV25YS0IyeURMRy84VzV5VVV0alFtRy9ZMysrZFFIVm5o?=
 =?utf-8?B?bnI4b1l5L1V2eDF6cUxmd2JnTXdrWHBqZkJIcmZjbHV5d1NNTysvMHNZeGNU?=
 =?utf-8?B?VjhscVkrYnNXK2ZDeVBPakw2M3ZMbU1DT3RNa3UzU1R1R2Y1VXN5YzZGSkxq?=
 =?utf-8?B?M3hhOXBlL2FqVjBPMVR6bllmQldLSEtZMlFCV1ZOYTRiVHk5cEJqZGhRbVI5?=
 =?utf-8?B?alhWY25IR2cxOUxINml5OFF4MkVteVgxdTYrZWZVK3VQUTVtRGphWXFPc2VR?=
 =?utf-8?B?ekRpd296bUZFakdGWFhES0lqRWNzT0xuTkxGeGhOWnBSQ1o1VSsvTnhJWmpY?=
 =?utf-8?B?cEJIL3d3RzhGTVh5bHM5bzhJTGN4RkUxQ3ZJaGJjeHVRb1dCNWRoSkV3NGV0?=
 =?utf-8?B?Uis2S1F0TFBWeUVudnhNVURoT0lpMDZkWkdrTUlVa1VIVnZ0aElQbGlLQi8z?=
 =?utf-8?B?Mlc5VG5VRlpBb0JNRkRmOUQvWm8xUnBmQXRCOHNSVXBKdmcxdmVDSFREUnlZ?=
 =?utf-8?Q?tBGvzjoGPL+S4pzMY26BWnW56?=
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 90a76e08-ec50-4011-82bb-08dc7e5a8074
X-MS-Exchange-CrossTenant-AuthSource: DM4PR12MB5136.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 27 May 2024 14:37:15.0722
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: Kt16DdTstXh/MXC5t9LBo0I7jwagHyvZGzWfr25QlwJbmZVfGz5iK5xcN3jGjQ4l448dPcpjr5GuI0chRJJyTQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: IA1PR12MB6434

Thanks Dave.

Because "CPPC" has existed in the "cpufeatures.h", thinking it will add 
duplicated line so I don't expand it.
Making this new flag hidden is to avoid causing user confusion about two 
"CPPC" flags.
This new feature flag is added to choose code branch, if not, it has to 
choose a ugly way and use CPU model ID.

Thanks,
Xiaojian


On 2024/5/24 0:31, Dave Hansen wrote:
> On 5/22/24 23:16, Xiaojian Du wrote:
>>   #define X86_FEATURE_BHI_CTRL		(21*32+ 2) /* "" BHI_DIS_S HW control available */
>>   #define X86_FEATURE_CLEAR_BHB_HW	(21*32+ 3) /* "" BHI_DIS_S HW control enabled */
>>   #define X86_FEATURE_CLEAR_BHB_LOOP_ON_VMEXIT (21*32+ 4) /* "" Clear branch history at vmexit using SW loop */
>> +#define X86_FEATURE_FAST_CPPC		(21*32 + 5) /* "" AMD Fast CPPC */
> It'd be nice to expand the CPPC acronym at least _once_.
>
> Also, this is used _once_ at boot and not exposed in /proc/cpuinfo.  Is
> it even worth defining an X86_FEATURE_ for it?