Received-SPF: pass (google.com: domain of linux-kernel+bounces-191021-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) client-ip=147.75.199.223;
From: Jonathan Corbet <corbet@lwn.net>
To: Yunseong Kim <yskelg@gmail.com>
Cc: skhan@linuxfoundation.org, Jinwoo Park <pmnxis@gmail.com>, Austin Kim
 <austindh.kim@gmail.com>, shjy180909@gmail.com, workflows@vger.kernel.org,
 linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org,
 linux-kernel-mentees@lists.linuxfoundation.org
Subject: Re: [PATCH v3] Documentation: cve Korean translation
In-Reply-To: <8880b0ec-9315-428e-b9c4-e578690d3c08@gmail.com>
References: <20240527103003.29318-1-yskelg@gmail.com>
 <87ikyzpgqz.fsf@meer.lwn.net>
 <bf37bf39-32d3-457f-abd6-115215d631af@gmail.com>
 <87o78rnz3a.fsf@meer.lwn.net>
 <8880b0ec-9315-428e-b9c4-e578690d3c08@gmail.com>
Date: Mon, 27 May 2024 08:55:33 -0600
Message-ID: <877cffnw2i.fsf@meer.lwn.net>
Precedence: bulk
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable

Yunseong Kim <yskelg@gmail.com> writes:

> On 5/27/24 10:50 =EC=98=A4=ED=9B=84, Jonathan Corbet wrote:
>> Yunseong Kim <yskelg@gmail.com> writes:
>>=20
>>>> 1) Why do I have three versions of it in my mailbox, sent over a period
>>>>    of 13 minutes?  What changed between the versions?
>>>
>>> Sorry, I forgot the name of the reviewer when I first sent the
>>> documentation content related patch version 2.
>>=20
>> Which is fine, but...
>>=20
>>>>    Normally, you want to wait for reviews to come in on one version
>>>>    before posting the next, and you should put a comment after the "--=
-"
>>>>    line saying what changed.
>>>>
>>>> 2) When did this review from Jinwoo Park happen?  I was not copied on
>>>>    that.
>>=20
>> You did not answer this question.  Reviews should generally be done in
>> public, but that does not seem to have happened here?
>
> Oops, sorry about that, Jonathan.
>
> Jinwoo Park sent me the review below, and I've updated some of ambiguous
> words in patch version 2.
>
> https://lore.kernel.org/linux-doc/57f0d90c-4cc6-4418-ab79-6ae026d8ae09@gm=
ail.com/T/#t

It does look like the patch was reviewed, but no Reviewed-by tag was
offered.  *Never* apply a Reviewed-by tag that has not been explicitly
given to you.

Jinwoo, would you like to offer that tag for this patch?

Thanks,

jon