Received-SPF: pass (google.com: domain of linux-kernel+bounces-191017-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) client-ip=2604:1380:45e3:2400::1;
Message-ID: <f553b3f2-d895-446a-a741-7a151ebeb3ed@baylibre.com>
Date: Mon, 27 May 2024 16:53:20 +0200
Precedence: bulk
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH 5/5] arm64: dts: mediatek: mt8188: Add support for Mali
 GPU on Panfrost
To: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>,
 linux-mediatek@lists.infradead.org
Cc: lee@kernel.org, robh@kernel.org, krzk+dt@kernel.org, conor+dt@kernel.org,
 matthias.bgg@gmail.com, mandyjh.liu@mediatek.com,
 devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
 linux-arm-kernel@lists.infradead.org, kernel@collabora.com
References: <20240527093908.97574-1-angelogioacchino.delregno@collabora.com>
 <20240527093908.97574-6-angelogioacchino.delregno@collabora.com>
Content-Language: en-US
From: Julien Panis <jpanis@baylibre.com>
In-Reply-To: <20240527093908.97574-6-angelogioacchino.delregno@collabora.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit

On 5/27/24 11:39, AngeloGioacchino Del Regno wrote:
> Add the necessary OPP table for the GPU and also add a GPU node
> to enable support for the Valhall-JM G57 MC3 found on this SoC,
> using the Panfrost driver.
>
> Signed-off-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>
> ---

[...]

>   
> +		gpu: gpu@13000000 {
> +			compatible = "mediatek,mt8188-mali", "arm,mali-valhall-jm";
> +			reg = <0 0x13000000 0 0x4000>;
> +
> +			clocks = <&mfgcfg CLK_MFGCFG_BG3D>;
> +			interrupts = <GIC_SPI 383 IRQ_TYPE_LEVEL_HIGH 0>,
> +				     <GIC_SPI 382 IRQ_TYPE_LEVEL_HIGH 0>,
> +				     <GIC_SPI 381 IRQ_TYPE_LEVEL_HIGH 0>;
> +			interrupt-names = "job", "mmu", "gpu";
> +			operating-points-v2 = <&gpu_opp_table>;
> +			power-domains = <&spm MT8188_POWER_DOMAIN_MFG2>,
> +					<&spm MT8188_POWER_DOMAIN_MFG3>,
> +					<&spm MT8188_POWER_DOMAIN_MFG4>;
> +			power-domain-names = "core0", "core1", "core2";

Hi Angelo,

I think you should add something like that here:
#cooling-cells = <2>;
(the warning is raised when I run 'make dtbs_check')

Julien