Received-SPF: pass (google.com: domain of linux-kernel+bounces-190987-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:40f1:3f00::1 as permitted sender) client-ip=2604:1380:40f1:3f00::1;
Message-ID: <929aec0d-690b-4277-90b0-d0b4adb437d3@amd.com>
Date: Mon, 27 May 2024 09:40:21 -0500
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH] cpufreq: amd-pstate: Fix the inconsistency in max
 frequency units
To: Dhananjay Ugwekar <Dhananjay.Ugwekar@amd.com>, rafael@kernel.org,
 ray.huang@amd.com, viresh.kumar@linaro.org, gautham.shenoy@amd.com
Cc: ananth.narayan@amd.com, linux-pm@vger.kernel.org,
 linux-kernel@vger.kernel.org, Perry.Yuan@amd.com
References: <20240527051128.110091-1-Dhananjay.Ugwekar@amd.com>
Content-Language: en-US
From: Mario Limonciello <mario.limonciello@amd.com>
In-Reply-To: <20240527051128.110091-1-Dhananjay.Ugwekar@amd.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?M3hDWUMxN1JQb0dETmNqbUw1TVhWdEhyWno0WHpUOUIxNDBsRG1nZmRqTHNZ?=
 =?utf-8?B?ZGdsa29abEtDUElkd3FuSEw3a21PMUlNS01UMXlQckVxNld5aU02Vlp0RGRJ?=
 =?utf-8?B?TksxVDJHUHlqYkQ3UGsvWWJwTVJTbWFYOEhwQ3ZYak81YUlNSHl3emVGWDVw?=
 =?utf-8?B?UHFxOTlXdUNqNW5yQVV5a2hpQ0ZKb0tLQUpzaXNuRXBXRkRQUjNzL1ViekRN?=
 =?utf-8?B?T0lROUl5ak10dE9KbkZRMGRQYXY3ZFlvaUlXVE80OHZUUXNCa3FJbUl6RkVs?=
 =?utf-8?B?Qy9BSTY5WWVZWWlWUjIvUmQ4MVR6QUpIMjVCdlVOaFlwRzZ0L2V3dmlZR1ND?=
 =?utf-8?B?Vmh3bjZnSmVUSzNPODJoeXlZdzJBTzRHdXNCUmhueDVQUjAwMHlxaUh0eDF4?=
 =?utf-8?B?OUpWNTcxYnl1ZkQycE5ZamRKamtTVnFaRkVqZ0kvTXdIU1A2UHFoMmw2QkZC?=
 =?utf-8?B?NVJnVXNNU3QrTnVGUEtjSHRQVEVMTGFsT2tPZnFiNHFYZ044K3RjQ2hSbVpI?=
 =?utf-8?B?UkJLdzQydGUyZlhBTXplai8wSTd3ZEpIbmFaU0RQbkpKZzJOYnZScVlRZkIw?=
 =?utf-8?B?aDF2ZXRwK2EveGV1empnaFdrRFRwWG44em9BWlhiZ1lRVVR6NSt3bFJXR3Jm?=
 =?utf-8?B?UVZmeTNIa1Jza3hjVlNBV2czVUl4Mm9DWDI1b2RUUGdWWTQzd2hZYXdmZ3Ja?=
 =?utf-8?B?MFRVUndKTWxYMlFjeThKdUE3NDh3dUFidlR5ckRHbnV6bUVuekN0dGF3QTlJ?=
 =?utf-8?B?R1hHT2NQb1JMOGdhb0lsTXJ5MUtORnJxdGxSVlFMZGZ6WVhERVJNV2pZQVB0?=
 =?utf-8?B?RDBFdktyclVqbDB0cWFlWjN1Rm1Tc2x3UXlDU3RMQUI2dlNhRU52QWtZNVZK?=
 =?utf-8?B?ODROa2dKRmpjdi82ZXVOUjdEYlAxeFBVU1M4NVJTOFREaTJ1YU5MVElPcm9O?=
 =?utf-8?B?WVVmQVVJdVA1ckxvYW9zOFZPT1huQmdVRXR2RWoyVlRmYW9wM0hqT1hteTNY?=
 =?utf-8?B?Rm5tVTZ3SUhtdWZVWHUwa0RCM3E5QUdzU1RPRWdiZElqb3pBalhPY3l0dEZQ?=
 =?utf-8?B?K3BTWmIxYW9YZ1dBNWN1ek85WldUOVVFbVdmMFU4dThQQmlyeDJBYS9BYkM4?=
 =?utf-8?B?RytwR3pwaXBaQUxtM0thbWFBcEJFVTRUYUg0REwvd0xwTDdzdnBaQ2lUSCt1?=
 =?utf-8?B?N2lDRmVCU3YyVmZmaDh1aXNUaGsza3RpYWNhQzN2c3R3RnRWbU1oN09hUU1J?=
 =?utf-8?B?Z3ZtYWhqNkJNRWR1aC9VdVZBbjRNcWozaDlkcXB6THpVUkh1aGNGRFUyeGFa?=
 =?utf-8?B?OTRTamtEa0o5b1hqQk5kWU1HWCt4TXl6czV6R3dmK1hySDJsNG9QUXJENFlN?=
 =?utf-8?B?TUxJQk9wS1Y1RlVDNC9UYnI0Y3htQWM2MTZWSU83VERsdi9OMVlPOXNETFVq?=
 =?utf-8?B?L05VODUveVhLdCtvSm1zeUY4Rlc1NDQrU0g0a3M1UmZOUno5K0E4c1p6MW9j?=
 =?utf-8?B?WWhxNGJNSDUxMi9QcjN3SlZKdUxRQ1JwTlQzOWIzYU1Tbk5uMGlORmdCQ0xX?=
 =?utf-8?B?RHZWRWtldEFFZFp2RXNmOTBVcVRydmVuOStSKzFyL0hENmRIUEg2NlVoZWNm?=
 =?utf-8?B?d1ZNL3hRcnhEeHg3UjFmOXpqcm0zWTJicGhCSHNkNi9sNTVDc0V1UEM0VTl4?=
 =?utf-8?B?SWFSUUJPQzRqZGVwQ3o5Ky92RVQxcHg2UXVIM2Q2M0FpTTZHTytrNVpJejdC?=
 =?utf-8?B?M2ZPU1IrT1k0Uy9WTEJYQWdJY3hoUXhpTWVhV01JWjEwQkJEWjc3d1JtYlFU?=
 =?utf-8?B?MmgxTmJORGxMNUpzcGQ2T29uWkk0NTZnd3krWitid1R6QjVjQjUydEluNUVu?=
 =?utf-8?B?VHdmNGF0VzU0QitId2NLM3NXSjF1OGhSZExRN0JST3FOUVk0RUVTS2dUUHZs?=
 =?utf-8?B?UTJiby9sMnJTbVZ4UW1VMHFMM2lJTzcxdkN3L0Z6QVBtYTE0RDUvd2ZtYVNY?=
 =?utf-8?B?LzNmVkxEczNSR2wvZDU0aDRtRVJpRmVEcDV5Y1BwT21XQ3JMaGRraTVqQXc1?=
 =?utf-8?B?T1NwL080R0svWStXeWRjWSs5ejY2WG9zUk9jYitTUHc3TmFNa3NXQmx0NGRZ?=
 =?utf-8?Q?O6KrMcn41iXoan7poLc+oEdkg?=
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 3b28770d-290d-4d9a-f656-08dc7e5af174
X-MS-Exchange-CrossTenant-AuthSource: MN0PR12MB6101.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 27 May 2024 14:40:24.4456
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: lWfjOFEjbszk58CycjOzcqAsrMGokgFCKaWpx6TApw+Og4L+Y5r7INeU/Zy61acNjOqGCvIkab2HEyo45uFyaQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CH3PR12MB8909

On 5/27/2024 00:11, Dhananjay Ugwekar wrote:
> The nominal frequency in cpudata is maintained in MHz whereas all other
> frequencies are in KHz. This means we have to convert nominal frequency
> value to KHz before we do any interaction with other frequency values.
> 
> In amd_pstate_set_boost(), this conversion from MHz to KHz is missed,
> fix that.
> 
> Tested on a AMD Zen4 EPYC server
> 
> Before:
> $ cat /sys/devices/system/cpu/cpufreq/policy*/scaling_max_freq | uniq
> 2151
> $ cat /sys/devices/system/cpu/cpufreq/policy*/cpuinfo_min_freq | uniq
> 400000
> $ cat /sys/devices/system/cpu/cpufreq/policy*/scaling_cur_freq | uniq
> 2151
> 409422
> 
> After:
> $ cat /sys/devices/system/cpu/cpufreq/policy*/scaling_max_freq | uniq
> 2151000
> $ cat /sys/devices/system/cpu/cpufreq/policy*/cpuinfo_min_freq | uniq
> 400000
> $ cat /sys/devices/system/cpu/cpufreq/policy*/scaling_cur_freq | uniq
> 2151000
> 1799527
> 

Cc: stable@vger.kernel.org

> Fixes: ec437d71db77 ("cpufreq: amd-pstate: Introduce a new AMD P-State driver to support future processors")
> Signed-off-by: Dhananjay Ugwekar <Dhananjay.Ugwekar@amd.com>

Acked-by: Mario Limonciello <mario.limonciello@amd.com>

> ---
>   drivers/cpufreq/amd-pstate.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/cpufreq/amd-pstate.c b/drivers/cpufreq/amd-pstate.c
> index 1b7e82a0ad2e..cde3b91b4422 100644
> --- a/drivers/cpufreq/amd-pstate.c
> +++ b/drivers/cpufreq/amd-pstate.c
> @@ -669,7 +669,7 @@ static int amd_pstate_set_boost(struct cpufreq_policy *policy, int state)
>   	if (state)
>   		policy->cpuinfo.max_freq = cpudata->max_freq;
>   	else
> -		policy->cpuinfo.max_freq = cpudata->nominal_freq;
> +		policy->cpuinfo.max_freq = cpudata->nominal_freq * 1000;
>   
>   	policy->max = policy->cpuinfo.max_freq;
>