Received-SPF: pass (google.com: domain of linux-kernel+bounces-191090-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) client-ip=2604:1380:4601:e00::3;
Date: Mon, 27 May 2024 21:15:29 +0530
From: "Gautham R. Shenoy" <gautham.shenoy@amd.com>
To: Mario Limonciello <mario.limonciello@amd.com>
Cc: Dhananjay Ugwekar <Dhananjay.Ugwekar@amd.com>, rafael@kernel.org,
	ray.huang@amd.com, viresh.kumar@linaro.org, ananth.narayan@amd.com,
	linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org,
	Perry.Yuan@amd.com
Subject: Re: [PATCH] cpufreq: amd-pstate: Fix the inconsistency in max
 frequency units
Message-ID: <ZlSqmYDaPNE8jybO@BLR-5CG11610CF.amd.com>
References: <20240527051128.110091-1-Dhananjay.Ugwekar@amd.com>
 <929aec0d-690b-4277-90b0-d0b4adb437d3@amd.com>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <929aec0d-690b-4277-90b0-d0b4adb437d3@amd.com>
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?us-ascii?Q?WozrBNoG9EdkR/KrwkvJbF0OGUsLPxll9o2FlWA7PHWHobfIc/owYtWs0+v9?=
 =?us-ascii?Q?uYOOuq89mbjhoGkcor6wmFNtyRAuiFSpF7qrT4KOhXX5AZ+SZbwuGBJjeTsi?=
 =?us-ascii?Q?CJHKDoo5ddx6pFl+ymVGUEdcDfNcI9x3DqRdrEaXFAHbZjPfSTwHcLpMA/B0?=
 =?us-ascii?Q?eCtarnUAaPJyAXmK+EdHYsjXfqma9gCFv7ilVp2+vgBJgeCvbv9Ysz7eq7YK?=
 =?us-ascii?Q?va6cMlxJHmL3JQBvwHxU5ChqtuhKXIOYSHQqprKhXRX9jtmSrN6sOR7XMjUO?=
 =?us-ascii?Q?z3GN6NG3Ui0YfgHXeWH+5QsKFXSN8GmeCmFxoTwJ4VbwsnJyfcdf4gBzs6aH?=
 =?us-ascii?Q?i81YfVkdOPv31llZ5VHnp3SHvzcbOnX3079lHezHoFxMRGg+/5tFhc4l5N70?=
 =?us-ascii?Q?eo0QzkDzJKg80sFiL8+ITnf8FZkrq4KY1igIIGfXqF+e8OLPOOvNfzraBNcX?=
 =?us-ascii?Q?EVbetRyzXutoBHXkveUjBOCVoRMgnP6B1pbAYjh8zY9k+q6gOcnJEeNpax3g?=
 =?us-ascii?Q?W4hRo3Q6vn7FbCsjpbGw4ghTq+kcDac31CR2Il16G6WaCdj5R2/UFdXk2OoM?=
 =?us-ascii?Q?8xIyFvVlvRY9StC3gJ6BWPkrkcWMzXlgb6aCykqA9KTptDZ9uc+QbVRNYc+N?=
 =?us-ascii?Q?EIeU+XxB2WWciW6W3j/vFT15f/BR0/32ITvc6n6TFgyVWgyNifZc2K9YAO5P?=
 =?us-ascii?Q?m5uzTx6xbBbEIPkJ4ROEo6TBt6uYeVrNubAzu4g8iM6dN+64XZzqrwICAtO/?=
 =?us-ascii?Q?JsRg2bDg4/RFcMiP319rRP5UNm8atWkxSgmOwjyqT9WZR3hldiJzCYXkvjYA?=
 =?us-ascii?Q?Yi/X01SlCTOWzfqf9Hs7xTw5JqcJjW04qdHBdSbBug2sh3hPUouEL4DnmYd+?=
 =?us-ascii?Q?APGehVxrddUOILtyRwc2ROfX/NgwbcdDF+kdBxXeFg8m7FCy1Uncd2JcJ1kO?=
 =?us-ascii?Q?qCfcV4P8bB/Cwe1UeBr8IV6IsxfvctItPT0g0Liq2n1GfYi1w/BrcStwJ9pj?=
 =?us-ascii?Q?fvvYQO5xQMLnjFE+/fnjA4SbDN130fTPqoD/Dr9asgVtaVjDsMHTTIatFVg0?=
 =?us-ascii?Q?fN4S7RSlujSrcUtUJ2jizwCEns7tK0BVt7Bv+tfxvdmQOJRfEaIdneRo0gEh?=
 =?us-ascii?Q?qbm7ARAwbYwsZbqAh3i0/V9CWC8QQRuB3beOVACWJMH6Tx1tTNTa9o8NRh8F?=
 =?us-ascii?Q?QPL04hDbL0lcFgj2DjRWA6yz+DnPtsjtfRqJ2kzmUSBgTK8y843m36YRucBk?=
 =?us-ascii?Q?SkXXj8NuXWBTJ+lHaDAb6yCqnCK5SC0J9gH7waHfHtAKht7NDwEuZI5OteGl?=
 =?us-ascii?Q?ho/umeYgOmAxIefwSCVDdcwPcZR2exMLiESZ+3bf6raEnUX9jmb8H6Vs/UL/?=
 =?us-ascii?Q?W0Z8LcPscnDQUuTi4FPcEmOQH+G4lUvojiBGxR/UPP/Rz31zOg3GZ1mnv08u?=
 =?us-ascii?Q?TqEept6Kdr6ay8IqAFsc7MakeQsbQSMqu2tcgyfwxej7Rguel/aTLX4+E5gu?=
 =?us-ascii?Q?tceBFGfhPm2+3SWPuxOdbdteAqIt2OL4u5Qim+rVhqU4W5F+7hkRn/C6TJd9?=
 =?us-ascii?Q?YGfllxJ146mstiLTx/0UqB0Z1z7tUNqKIFYY41a1?=
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 1a7969f2-3124-4aa1-b3bc-08dc7e640a57
X-MS-Exchange-CrossTenant-AuthSource: DS7PR12MB8252.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 27 May 2024 15:45:31.8624
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: S8Bfe6hTlTwoX4agAIwYpi6qzIotJ+Rf6Vzmh5B/zB1iRZPEPaiVs9mj1BV4QA0pb6PXViMcxR3a8yz2X5v7Xg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: IA1PR12MB7520


On Mon, May 27, 2024 at 09:40:21AM -0500, Mario Limonciello wrote:
> On 5/27/2024 00:11, Dhananjay Ugwekar wrote:
> > The nominal frequency in cpudata is maintained in MHz whereas all other
> > frequencies are in KHz. This means we have to convert nominal frequency
> > value to KHz before we do any interaction with other frequency values.
> > 
> > In amd_pstate_set_boost(), this conversion from MHz to KHz is missed,
> > fix that.
> > 
> > Tested on a AMD Zen4 EPYC server
> > 
> > Before:
> > $ cat /sys/devices/system/cpu/cpufreq/policy*/scaling_max_freq | uniq
> > 2151
> > $ cat /sys/devices/system/cpu/cpufreq/policy*/cpuinfo_min_freq | uniq
> > 400000
> > $ cat /sys/devices/system/cpu/cpufreq/policy*/scaling_cur_freq | uniq
> > 2151
> > 409422
> > 
> > After:
> > $ cat /sys/devices/system/cpu/cpufreq/policy*/scaling_max_freq | uniq
> > 2151000
> > $ cat /sys/devices/system/cpu/cpufreq/policy*/cpuinfo_min_freq | uniq
> > 400000
> > $ cat /sys/devices/system/cpu/cpufreq/policy*/scaling_cur_freq | uniq
> > 2151000
> > 1799527
> > 
> 
> Cc: stable@vger.kernel.org
> 
> > Fixes: ec437d71db77 ("cpufreq: amd-pstate: Introduce a new AMD P-State driver to support future processors")
> > Signed-off-by: Dhananjay Ugwekar <Dhananjay.Ugwekar@amd.com>
> 
> Acked-by: Mario Limonciello <mario.limonciello@amd.com>

Acked-by: Gautham R. Shenoy <gautham.shenoy@amd.com>

> 
> > ---
> >   drivers/cpufreq/amd-pstate.c | 2 +-
> >   1 file changed, 1 insertion(+), 1 deletion(-)
> > 
> > diff --git a/drivers/cpufreq/amd-pstate.c b/drivers/cpufreq/amd-pstate.c
> > index 1b7e82a0ad2e..cde3b91b4422 100644
> > --- a/drivers/cpufreq/amd-pstate.c
> > +++ b/drivers/cpufreq/amd-pstate.c
> > @@ -669,7 +669,7 @@ static int amd_pstate_set_boost(struct cpufreq_policy *policy, int state)
> >   	if (state)
> >   		policy->cpuinfo.max_freq = cpudata->max_freq;
> >   	else
> > -		policy->cpuinfo.max_freq = cpudata->nominal_freq;
> > +		policy->cpuinfo.max_freq = cpudata->nominal_freq * 1000;
> >   	policy->max = policy->cpuinfo.max_freq;
>