Received-SPF: pass (google.com: domain of linux-kernel+bounces-191098-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) client-ip=2604:1380:45e3:2400::1;
From: Thomas Gleixner <tglx@linutronix.de>
To: Jiaxun Yang <jiaxun.yang@flygoat.com>, Huacai Chen
 <chenhuacai@kernel.org>, Thomas Bogendoerfer <tsbogend@alpha.franken.de>,
 Daniel Lezcano <daniel.lezcano@linaro.org>
Cc: linux-kernel@vger.kernel.org, linux-mips@vger.kernel.org, Jiaxun Yang
 <jiaxun.yang@flygoat.com>
Subject: Re: [PATCH v2] clocksource: Add node counter timer driver for
 MIPS/Loongson64
In-Reply-To: <20240517-loongson_nodecnt-v2-1-5bd0bb20ff5f@flygoat.com>
References: <20240517-loongson_nodecnt-v2-1-5bd0bb20ff5f@flygoat.com>
Date: Mon, 27 May 2024 17:51:25 +0200
Message-ID: <87sey3b6de.ffs@tglx>
Precedence: bulk
MIME-Version: 1.0
Content-Type: text/plain

Jiaxun!

On Fri, May 17 2024 at 18:13, Jiaxun Yang wrote:

> +static void __iomem *nodecnt_reg;
> +static u64 (*nodecnt_read_fn)(void);
> +
> +static u64 notrace nodecnt_read_2x32(void)
> +{
> +	unsigned int hi, hi2, lo;
> +
> +	do {
> +		hi = readl_relaxed(nodecnt_reg + 4);
> +		lo = readl_relaxed(nodecnt_reg);
> +		hi2 = readl_relaxed(nodecnt_reg + 4);
> +	} while (hi2 != hi);
> +
> +	return (((u64) hi) << 32) + lo;
> +}
> +
> +static u64 notrace nodecnt_read_64(void)
> +{
> +	return readq_relaxed(nodecnt_reg);
> +}
> +
> +static u64 notrace nodecnt_read_csr(void)
> +{
> +	return csr_readq(LOONGSON_CSR_NODECNT);
> +}
> +
> +static u64 nodecnt_clocksource_read(struct clocksource *cs)
> +{
> +	return nodecnt_read_fn();

What's this indirection for? Why dont you update 

> +static struct clocksource nodecnt_clocksource = {
> +	.name	= "nodecnt",
> +	.read	= nodecnt_clocksource_read,

the read function pointer here and spare the indirection?

Thanks

        tglx