Received-SPF: pass (google.com: domain of linux-kernel+bounces-191155-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:40f1:3f00::1 as permitted sender) client-ip=2604:1380:40f1:3f00::1;
From: Sunil Kovvuri Goutham <sgoutham@marvell.com>
To: Frank Wunderlich <linux@fw-web.de>, Felix Fietkau <nbd@nbd.name>,
        Sean
 Wang <sean.wang@mediatek.com>,
        Mark Lee <Mark-MC.Lee@mediatek.com>,
        Lorenzo
 Bianconi <lorenzo@kernel.org>,
        "David S. Miller" <davem@davemloft.net>,
        Eric
 Dumazet <edumazet@google.com>, Jakub Kicinski <kuba@kernel.org>,
        Paolo Abeni
	<pabeni@redhat.com>,
        Matthias Brugger <matthias.bgg@gmail.com>,
        AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>
CC: Frank Wunderlich <frank-w@public-files.de>,
        John Crispin
	<john@phrozen.org>,
        "netdev@vger.kernel.org" <netdev@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "linux-arm-kernel@lists.infradead.org"
	<linux-arm-kernel@lists.infradead.org>,
        "linux-mediatek@lists.infradead.org"
	<linux-mediatek@lists.infradead.org>,
        Daniel Golle <daniel@makrotopia.org>
Subject: RE: [net v2] net: ethernet: mtk_eth_soc: handle dma buffer size soc
 specific
Thread-Topic: [net v2] net: ethernet: mtk_eth_soc: handle dma buffer size soc
 specific
Thread-Index: AQHasE5bT9grtdxWqkylIIRYxgKV6Q==
Date: Mon, 27 May 2024 15:55:55 +0000
Message-ID: 
 <BY3PR18MB4737D0ED774B14833353D202C6F02@BY3PR18MB4737.namprd18.prod.outlook.com>
References: <20240527142142.126796-1-linux@fw-web.de>
In-Reply-To: <20240527142142.126796-1-linux@fw-web.de>
Accept-Language: en-US
Content-Language: en-US
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: 
 =?us-ascii?Q?tCbFQr1UarXCsGli9TqgOApEP2KxXfvvtKsxmCNUuHzxocmJjGHsAfsjY5+U?=
 =?us-ascii?Q?ozBobDqCXyzr8JChxYXjqVRgg+QB4KBFXyjcWiQBHxB9/tSepOhJMHE6Cc6d?=
 =?us-ascii?Q?zBeGCckVf6h1a6Zxv5q5FuFDOpP/wU2ntfVWBKQpeAQ+b+JKf+v0rZO3jONs?=
 =?us-ascii?Q?neWuUYTWVcqyKVLB6OSFLYYWOs1MTUyuqLvpZHObQubWy5FlUkK8CLhAF8qN?=
 =?us-ascii?Q?sQY7j0CtUSh2ogYxtVmuCDUadpprnE2tXJrNBoVuxxh6VyRZcWcAJRP6LI0Z?=
 =?us-ascii?Q?AK8BsY6X7H+rikq71KAXLczglXFjZRyx8kJrCTD0T+uX9R7aCZdHbrlGZsmG?=
 =?us-ascii?Q?i3up9ikUg1lbpqZLMOijs2A6EuiyDPfcU0bvn4AGXbcOCB49o6J84ytxZ2sL?=
 =?us-ascii?Q?/fcoIPX0alzgORmWjnxhfdfLm8M4Y8IAiJGM3rZ52nw6DqvTKOaXvweEKwKS?=
 =?us-ascii?Q?1gbKscWERQZa826L9smcm4zpnPxT4q5aAppqlMoEo7ZLz+wIkAOJl0ToMMbn?=
 =?us-ascii?Q?DzzaMMcnX48m8n+sLysYshQ3eaImckqQpSXPAf6vdlDYtYEYGXjBDdM+l06v?=
 =?us-ascii?Q?WqQedNEtQdrRQaouhiXkH8kFy55G7Gb0pxjPJ9bzuOpWFIHnIBKyJkGrTH7z?=
 =?us-ascii?Q?jpdIHR9sJXjITyGHYNhnL8oEiSyTxxcuMXfcm6MkNbBCgXr7n+o9FxJ7Fa6G?=
 =?us-ascii?Q?RJxcmL5U+DvSOrU7xkK9Oi+D/4KSZuo2DlDq7MnIeVJBICwvX7EFeJG9OOz+?=
 =?us-ascii?Q?MLeQ95Nv1AHkaCSwenV3ykdFC6GAOAivFDN6cn4S2q9CI6gQC6z94TPXS9h+?=
 =?us-ascii?Q?esy+0wZh8TEpMGUNKO/b7adpRGOU2K/8ptE1dofLLV6KxFmoHYPMUSmGBDzv?=
 =?us-ascii?Q?BChvI3S8EBpRRyslX9OMNTimABFJdqgUv2ge7asDjyGeIpcWzNuUZ8tH8bJ9?=
 =?us-ascii?Q?7+W/u7gX6DL2pyjJj+rZPesQ9m09vrRnaXAN36nVDz1mSwGIACO/1jJsq0oU?=
 =?us-ascii?Q?bd7CLz8K7wc30ZHdcEiqHHEfocEGnfMN3u6pNnH+j4iNe1xG033GPCly5G53?=
 =?us-ascii?Q?zVu/hFresCB5xt1DuJg26UkpCZBJj0CTkqZMg1WOyCLg8Q1PJxaGRXvZaBbX?=
 =?us-ascii?Q?1WDt4NSDVgF9L6F6F5RWTS93kK+fYww5fK45QIVE5/+X1rv3vOCOpnQlwSYh?=
 =?us-ascii?Q?yTNIzkACo8aJ7qFss9COnWbtCYX8cVjL+hvXePqPNEo95US86zT5xGIkyGdc?=
 =?us-ascii?Q?C07NQRXObtcKO6xgaSe4ObRpPc4ajw/Hi/JR1Zi1v0pSVxx6ktMUgIABysjY?=
 =?us-ascii?Q?eG8+R8S35hK97iVkhaIGXqH9O97wR5iDMTEKD6LXH6mA6sSE5YWEUOVK0KMq?=
 =?us-ascii?Q?fmZa3vE0LMMOoXCj2Wf4Osuh8J+17t6rmlTUULMwFjIvA8oytnGNbeMXVkSR?=
 =?us-ascii?Q?5EjOTvvEZa7MCFNoXMABmADkJOcpqfTd6TKoAyg1xm/jsllTU7WrwNYfRo8u?=
 =?us-ascii?Q?paCOBFpPl7v1/old53yWzq8YbgYMXOb3Eimwtp2NnGChMqffesZq0oVtOERK?=
 =?us-ascii?Q?N4ULg4/C3FQdkbk/BCQMOGA9qzhR6po5j74EtbzV?=
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk
X-Mailing-List: linux-kernel@vger.kernel.org
List-Id: <linux-kernel.vger.kernel.org>
List-Subscribe: <mailto:linux-kernel+subscribe@vger.kernel.org>
List-Unsubscribe: <mailto:linux-kernel+unsubscribe@vger.kernel.org>
MIME-Version: 1.0
X-OriginatorOrg: marvell.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: BY3PR18MB4737.namprd18.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 854ccd55-66d6-4522-d420-08dc7e657e33
X-MS-Exchange-CrossTenant-originalarrivaltime: 27 May 2024 15:55:55.3622
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 70e1fb47-1155-421d-87fc-2e58f638b6e0
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: AnKoOodxMIe0a/bdIDhbneLSaZUOYCDy2eXl7Xf3p+oAsS2rnJqNZwkZx9J3KJFpstOHiyYHA0tjD8pba5IOtQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ0PR18MB4961
X-Proofpoint-GUID: hy3t5txix1qyKluvirs4JMDyOvyEWQjD
X-Proofpoint-ORIG-GUID: hy3t5txix1qyKluvirs4JMDyOvyEWQjD
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.293,Aquarius:18.0.1039,Hydra:6.0.650,FMLib:17.12.28.16
 definitions=2024-05-27_04,2024-05-27_01,2024-05-17_01


> -----Original Message-----
> From: Frank Wunderlich <linux@fw-web.de>
> Sent: Monday, May 27, 2024 7:52 PM
> To: Felix Fietkau <nbd@nbd.name>; Sean Wang <sean.wang@mediatek.com>;
> Mark Lee <Mark-MC.Lee@mediatek.com>; Lorenzo Bianconi
> <lorenzo@kernel.org>; David S. Miller <davem@davemloft.net>; Eric Dumazet
> <edumazet@google.com>; Jakub Kicinski <kuba@kernel.org>; Paolo Abeni
> <pabeni@redhat.com>; Matthias Brugger <matthias.bgg@gmail.com>;
> AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>
> Cc: Frank Wunderlich <frank-w@public-files.de>; John Crispin
> <john@phrozen.org>; netdev@vger.kernel.org; linux-kernel@vger.kernel.org;
> linux-arm-kernel@lists.infradead.org; linux-mediatek@lists.infradead.org;
> Daniel Golle <daniel@makrotopia.org>
> Subject: [net v2] net: ethernet: mtk_eth_soc: handle dma buffer size soc =
specific
>=20
> From: Frank Wunderlich <frank-w@public-files.de>
>=20
> The mainline MTK ethernet driver suffers long time from rarly but annoyin=
g tx
> queue timeouts. We think that this is caused by fixed dma sizes hardcoded=
 for
> all SoCs.
>=20
> Use the dma-size implementation from SDK in a per SoC manner.
>=20
> Fixes: 656e705243fd ("net-next: mediatek: add support for MT7623
> ethernet")
> Suggested-by: Daniel Golle <daniel@makrotopia.org>
> Signed-off-by: Frank Wunderlich <frank-w@public-files.de>

.............
>=20
> diff --git a/drivers/net/ethernet/mediatek/mtk_eth_soc.c
> b/drivers/net/ethernet/mediatek/mtk_eth_soc.c
> index cae46290a7ae..f1ff1be73926 100644
> --- a/drivers/net/ethernet/mediatek/mtk_eth_soc.c
> +++ b/drivers/net/ethernet/mediatek/mtk_eth_soc.c

............
> @@ -1142,40 +1142,46 @@ static int mtk_init_fq_dma(struct mtk_eth *eth)
>  						       cnt * soc->tx.desc_size,
>  						       &eth->phy_scratch_ring,
>  						       GFP_KERNEL);

.............
> -	for (i =3D 0; i < cnt; i++) {
> -		dma_addr_t addr =3D dma_addr + i * MTK_QDMA_PAGE_SIZE;
> -		struct mtk_tx_dma_v2 *txd;
> +		dma_addr =3D dma_map_single(eth->dma_dev,
> +					  eth->scratch_head[j], len *
> MTK_QDMA_PAGE_SIZE,
> +					  DMA_FROM_DEVICE);
>=20

As per commit msg, the fix is for transmit queue timeouts.
But the DMA buffer changes seems for receive pkts.
Can you please elaborate the connection here.

Thanks,
Sunil.