Received: by 2002:a89:d88:0:b0:1fa:5c73:8e2d with SMTP id eb8csp2157605lqb; Mon, 27 May 2024 09:34:09 -0700 (PDT) X-Forwarded-Encrypted: i=3; AJvYcCU1mTfGicRVN36zHgtnG96xLyAWrGMP1vUshkgVS1fywYWMjIq0DwlOoqkj27OM6ukqSPRqHLMcWO5Y83OtMMOAuI2qPkLZA5FEVbaIcg== X-Google-Smtp-Source: AGHT+IEQjeAMvO/bldXN+JejWIe4oju8lUDbzQ7rdzOK8ygSjfUGG0LRdwsTEUWlUrpoS//Gf+sJ X-Received: by 2002:a50:999a:0:b0:578:5f1b:421a with SMTP id 4fb4d7f45d1cf-5785f1b434bmr5660250a12.27.1716827649254; Mon, 27 May 2024 09:34:09 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1716827649; cv=pass; d=google.com; s=arc-20160816; b=LKAhlYdriAiu2vOhR3i7BPf0Yo+f04Jere5km+gBCPTunCImub0AGVS4F5nuEucm20 QvfJfW3CYZO6nhKnaxvacvsQRB/csSW2mj7QvNuedwqO7CYMWblg4CF1F81Z6jO/Q7NR WPVNMduqwNp7PGqr9q0yjDzH4Oz8mWfU0g3bj2ZsvA+0UwF9z1E/r+FEuKbJ1T70ywOm bxtZrWCZy+iyRUi7N6/9YGwbKQMfvrfAi6nW4vnNW+swosDJLaH6fJYrwyYkxQ7W3ZaI gaVgDwJsJybaXqxj0JqOpb+gKNqKgWA2lJoQWLp3f/J+UJFUJo103Jre271NysS4U8Wq /Hfw== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=in-reply-to:content-disposition:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:references:message-id:subject:cc :to:from:date:dkim-signature; bh=49lm/vM0/ydeaO5FYX8e8asLS3CdDVmI98hU6Rv2hXI=; fh=n3HoGFaGDf1XyaOlMgqdO/FIBoPHfqs/Oz1MZ5g5608=; b=OSLR+xamYBCDYFzZh6sEip4p0qLH3i/2xEmHMCSM+ZRZjEko1br4tKkNf3/9LRdfL9 r8vLENS6++n8RRQLnaJ1MStnqZqZ+k/C0zFZBbN5RULyjhrsPahy4e8apaG65cjWnOJ5 XAbOUBgw0mOgm2lfwZV5Th43WyxLqz0I5WN2BfG6eZ+qx2s/OKtYp16HnJhdY6VCxKRq mGnklV18KgQzGYbuMjVUasZb8O/qA/5k/ms+pEq2fSpbZX7GtaDnJsLmd8Bl/0dQXRS0 xKmmxYvTZu0Wwj5MaIC8hA6PcJ0HkKHuzX4FDe67lwG/8I9dWSTo29D9lrDupce8ZINr y0mg==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=WJPYjlpf; arc=pass (i=1 dkim=pass dkdomain=kernel.org); spf=pass (google.com: domain of linux-kernel+bounces-191251-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) smtp.mailfrom="linux-kernel+bounces-191251-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from am.mirrors.kernel.org (am.mirrors.kernel.org. [2604:1380:4601:e00::3]) by mx.google.com with ESMTPS id 4fb4d7f45d1cf-578699f7d42si2823764a12.14.2024.05.27.09.34.09 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 27 May 2024 09:34:09 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel+bounces-191251-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) client-ip=2604:1380:4601:e00::3; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=WJPYjlpf; arc=pass (i=1 dkim=pass dkdomain=kernel.org); spf=pass (google.com: domain of linux-kernel+bounces-191251-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) smtp.mailfrom="linux-kernel+bounces-191251-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by am.mirrors.kernel.org (Postfix) with ESMTPS id F134E1F2128C for ; Mon, 27 May 2024 16:34:08 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id A428A73452; Mon, 27 May 2024 16:33:59 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="WJPYjlpf" Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id BC40E61FE1; Mon, 27 May 2024 16:33:58 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1716827638; cv=none; b=ajjWKDP+Yl0fwIw4HgXJq6bvOk0RoM3eSkYrkK+pXaNpYcGJ72j9kSEFfLsAS8kpxA7oJlPY7iCuNB0pKEuR8lQwd+zsGKBc2ETqJ+a4hv14+dR9ELMLf/XQMdmyeFDiG7FAfbcxVwQoo8jCebNdyyrHsykLfh7pHzCMa3ELBRA= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1716827638; c=relaxed/simple; bh=FqwLRmZq7+sdJul6dGAtnX2DgoqP9PXXAfeDCFAU9F0=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=V0FAx6hA+6Gj+TWrxtIvuKZ1w7IyUMxJYREa0afsuxo70LXe4hOZkN9DAl0nNiSvUmaDoOsNyO9P3rlXOLFcdxNgQnHDbjQla7vqB6+VyxXRtS8Z8c81rHacCDjWYy/s6b+2twqaChtB8+t3F0nBlq+U9s7JNMHEx1sBI6/U/KE= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=WJPYjlpf; arc=none smtp.client-ip=10.30.226.201 Received: by smtp.kernel.org (Postfix) with ESMTPSA id 61CD7C2BBFC; Mon, 27 May 2024 16:33:57 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1716827638; bh=FqwLRmZq7+sdJul6dGAtnX2DgoqP9PXXAfeDCFAU9F0=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=WJPYjlpfQfU1/Omo2Hf+yu0gJGY/UyDbMlGw+tPR1grvIwXGPv8YVJxVIZ7Mymkoj pio6+HfD+hWdU4TwlPSe9XtlJnM8Ix5kRh8jSUPFgUFjtrZZ2YtItH2N95gou//KtY CKL397Fvt5D8QtnkIxu3091HHRFzaC+gmxv+bTipNF91tZP1p02LnL9y3/1PFbcwE9 z6/aoDbAYv1m4QiCykYoWjFEumHi6X8QkdWyxeatpOnj7h9KT5JxJtR/J6atyzw+Xi wgUchisEMjGRqxgNyDO5EBwueCVglI/nkflD5NdS04iUC9GNWh0yx7AGujlBg0hp2J rXVOEsBIuEanw== Date: Mon, 27 May 2024 11:33:54 -0500 From: Bjorn Andersson To: Neil Armstrong Cc: Konrad Dybcio , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Joerg Roedel , Will Deacon , Robin Murphy , linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, iommu@lists.linux.dev Subject: Re: [PATCH 3/3] arm64: dts: qcom: sdm450: add Lenovo Smart Tab M10 DTS Message-ID: References: <20240523-topic-sdm450-upstream-tbx605f-v1-0-e52b89133226@linaro.org> <20240523-topic-sdm450-upstream-tbx605f-v1-3-e52b89133226@linaro.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240523-topic-sdm450-upstream-tbx605f-v1-3-e52b89133226@linaro.org> On Thu, May 23, 2024 at 09:59:35AM GMT, Neil Armstrong wrote: > diff --git a/arch/arm64/boot/dts/qcom/sdm450-lenovo-tbx605f.dts b/arch/arm64/boot/dts/qcom/sdm450-lenovo-tbx605f.dts [..] > +&rpm_requests { > + regulators { > + compatible = "qcom,rpm-pm8953-regulators"; [..] > + pm8953_l8: l8 { > + regulator-min-microvolt = <2900000>; > + regulator-max-microvolt = <2900000>; > + }; [..] > + pm8953_l11: l11 { > + regulator-min-microvolt = <3300000>; > + regulator-max-microvolt = <3300000>; > + }; [..] > + }; > +}; > + > +&sdhc_1 { > + vmmc-supply = <&pm8953_l8>; JFYI. Not ensuring that the vmmc-supply is in HPM mode bitten us multiple times in the past. Regards, Bjorn