Received-SPF: pass (google.com: domain of linux-kernel+bounces-190645-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) client-ip=139.178.88.99;
Precedence: bulk
MIME-Version: 1.0
References: <20240511145200.226295-1-linux@treblig.org>
In-Reply-To: <20240511145200.226295-1-linux@treblig.org>
From: Gilad Ben-Yossef <gilad@benyossef.com>
Date: Mon, 27 May 2024 15:58:09 +0300
Message-ID: <CAOtvUMfYbNZ2G7-qkO8PFX5shdZmYvAQa6Uy4XbdvxsmKnDttQ@mail.gmail.com>
Subject: Re: [PATCH] crypto: ccree: Remove unused struct 'tdes_keys'
To: linux@treblig.org
Cc: herbert@gondor.apana.org.au, linux-crypto@vger.kernel.org, 
	linux-kernel@vger.kernel.org
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

Hi David,

On Sat, May 11, 2024 at 5:52=E2=80=AFPM <linux@treblig.org> wrote:
>
> From: "Dr. David Alan Gilbert" <linux@treblig.org>
>
> 'tdes_keys' appears unused.
> Remove it.
>

Acked-by: Gilad Ben-Yossef <gilad@benyossef.com>

Thank you for the patch and your patience.

> Signed-off-by: Dr. David Alan Gilbert <linux@treblig.org>
> ---
>  drivers/crypto/ccree/cc_cipher.c | 6 ------
>  1 file changed, 6 deletions(-)
>
> diff --git a/drivers/crypto/ccree/cc_cipher.c b/drivers/crypto/ccree/cc_c=
ipher.c
> index cd66a580e8b64..3fb667a17bbb1 100644
> --- a/drivers/crypto/ccree/cc_cipher.c
> +++ b/drivers/crypto/ccree/cc_cipher.c
> @@ -261,12 +261,6 @@ static void cc_cipher_exit(struct crypto_tfm *tfm)
>         kfree_sensitive(ctx_p->user.key);
>  }
>
> -struct tdes_keys {
> -       u8      key1[DES_KEY_SIZE];
> -       u8      key2[DES_KEY_SIZE];
> -       u8      key3[DES_KEY_SIZE];
> -};
> -
>  static enum cc_hw_crypto_key cc_slot_to_hw_key(u8 slot_num)
>  {
>         switch (slot_num) {
> --
> 2.45.0
>


--=20
Gilad Ben-Yossef
Chief Coffee Drinker

values of =CE=B2 will give rise to dom!