Received: by 2002:a89:d88:0:b0:1fa:5c73:8e2d with SMTP id eb8csp2227128lqb; Mon, 27 May 2024 12:01:27 -0700 (PDT) X-Forwarded-Encrypted: i=3; AJvYcCUrQmNRx/BFImALyAhdEr7uE3NbKgze4WfaCurAMB+xaKAnMBug51RpN7Cy85ofoou2H5YCqXwm/AbfeIkX7Zdd1/DwQnOWm+BrXCbGtw== X-Google-Smtp-Source: AGHT+IGphUDfinnM+b7+4czhFUj1HfO/ljDl5J38AmcXdTzQVLuzur9ULnr9gGqg/RpsUuSALguN X-Received: by 2002:a05:6a21:3981:b0:1af:f514:97cb with SMTP id adf61e73a8af0-1b212d5b19emr11733511637.8.1716836486907; Mon, 27 May 2024 12:01:26 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1716836486; cv=pass; d=google.com; s=arc-20160816; b=IvGnxW0zcN44Q0zzVE5j0lTrI92JDRMobwO2IWz49cR2tguk/dDevQd8U9nvG6oIDC ZvgBP1UBgI1V4Cu+Kk7aeBKEcS3+kM9vLUn1Wf0CsaAorizbwr0VcvbxTsycZqHThLSR OYapoY73kru/rzysxmOsPtadLP3VuJXK839uPXcIYgGGfmu19TNLiIMhEcaosFCnNK8x KmtAkvWk4gCPL7sHw1ZD8ChkgBWCYOW1E2i9PvjatlQqRpGCNglDqB2Y3y3K5Dx4MeSy NWTnzmjMZZPqJzU2xXXh1QXZNWW6G8locao147czP52WHncAMxluFb2LuLi2anNs/jiF Hcig== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=in-reply-to:content-disposition:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:references:message-id:subject:cc :to:from:date:dkim-signature; bh=37lIg3s+t3b4qmG4nLG2iDBlAi6+bbFulGijMGLbRU8=; fh=hp8atxxGZbLYGQm1At2WukzBq1aPu4M12m1gWQ41t5M=; b=YushKOq18k3f0NcUzItbtfKgu0M6yKGnyhyskTGIdUX2fmtjUsgEeV2KYpqNr65/XO 8B3LR9hfWVLVNlBF43j5IFHDycb7S1Z6FuVjwGmycbfAFjzd7HNSMadYMxdegjU8Pc7/ dF3Mxpw3VSD/m8F9lleerRpeG1jERQS11y2pGmmV/eRpV9YiJc1aqkWnB0lYiyfNatVj 6QJYWrbEi8J5Yrys0luYJLBKckDPAWsT//TnWy3Wm9Hhtx2Z9tTCkbUDJyfa9T0qCfqB MmhqzzX3i0H0wW5xnWnlHL6wkgbVqaUGEWWGiEGPSTdLil3M/FNgSF2etD0dRJAqPF0R yJUg==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@lunn.ch header.s=20171124 header.b=OB5XT4Rd; arc=pass (i=1 spf=pass spfdomain=lunn.ch dkim=pass dkdomain=lunn.ch dmarc=pass fromdomain=lunn.ch); spf=pass (google.com: domain of linux-kernel+bounces-191353-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:40f1:3f00::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-191353-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=lunn.ch Return-Path: Received: from sy.mirrors.kernel.org (sy.mirrors.kernel.org. [2604:1380:40f1:3f00::1]) by mx.google.com with ESMTPS id 41be03b00d2f7-68221b73e23si6713183a12.41.2024.05.27.12.01.26 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 27 May 2024 12:01:26 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel+bounces-191353-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:40f1:3f00::1 as permitted sender) client-ip=2604:1380:40f1:3f00::1; Authentication-Results: mx.google.com; dkim=pass header.i=@lunn.ch header.s=20171124 header.b=OB5XT4Rd; arc=pass (i=1 spf=pass spfdomain=lunn.ch dkim=pass dkdomain=lunn.ch dmarc=pass fromdomain=lunn.ch); spf=pass (google.com: domain of linux-kernel+bounces-191353-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:40f1:3f00::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-191353-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=lunn.ch Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sy.mirrors.kernel.org (Postfix) with ESMTPS id 3FD8CB21882 for ; Mon, 27 May 2024 19:01:18 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 5253C160880; Mon, 27 May 2024 19:00:45 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=lunn.ch header.i=@lunn.ch header.b="OB5XT4Rd" Received: from vps0.lunn.ch (vps0.lunn.ch [156.67.10.101]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id CD46A1607AF; Mon, 27 May 2024 19:00:42 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=156.67.10.101 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1716836444; cv=none; b=IWcvg1aUrwfdJEd+3LeWffn07z2GM7Cv0GMQ1TwxZz7T2hu+nRjE3XRjcboShNwKUtyXQv7UKH2kIhrPIR6U/J1AwC8Op6+lqKBKixmvRI/DRFeVYkTGfm3Cj13JTqzIBCn5Y8B6SZzNkZFju7iOFzNWaX5IJ5yoCncSA/PN/fU= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1716836444; c=relaxed/simple; bh=2uBLw2Sx6UBiIag7jcLM/uRvSK9uqL6b3mrS6Z7KwuM=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=n0b/RHnSXqrgTGh+ZRd4MgrGNDElXRxhQgPBXiUAwN5KqCBvEt2RWGWz54oQ2Qo31eNGw+QpXc7vmAMd9CE2EifyTsY+slnsar9oKn6DBmQmdAw88xO/xJvVl+cHaK7yUtkERVR0GoyjK63BT8JaoerEZULs/5LCz4Msn+KDcM4= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=lunn.ch; spf=pass smtp.mailfrom=lunn.ch; dkim=pass (1024-bit key) header.d=lunn.ch header.i=@lunn.ch header.b=OB5XT4Rd; arc=none smtp.client-ip=156.67.10.101 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=lunn.ch Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=lunn.ch DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lunn.ch; s=20171124; h=In-Reply-To:Content-Disposition:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:From:Sender:Reply-To:Subject: Date:Message-ID:To:Cc:MIME-Version:Content-Type:Content-Transfer-Encoding: Content-ID:Content-Description:Content-Disposition:In-Reply-To:References; bh=37lIg3s+t3b4qmG4nLG2iDBlAi6+bbFulGijMGLbRU8=; b=OB5XT4RdOZy8fOvjvk2d6piuRk vfd0+RlJFNNtKH3IcMqZSirlvjb7mPXlqD4ZBtm4zyaObwAl/ngWfAL5icsMY63lGMjF/cndhR4vd oXlofZe+OnC8ok7jw5WG6OZIedTtxK9tY5ZYnywUU8j7hK1egDHtQKw4JejCqXuxvLYc=; Received: from andrew by vps0.lunn.ch with local (Exim 4.94.2) (envelope-from ) id 1sBfZq-00G69n-52; Mon, 27 May 2024 21:00:10 +0200 Date: Mon, 27 May 2024 21:00:10 +0200 From: Andrew Lunn To: Boon Khai Ng Cc: Alexandre Torgue , Jose Abreu , "David S . Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Maxime Coquelin , netdev@vger.kernel.org, linux-stm32@st-md-mailman.stormreply.com, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Tien Sung Ang , G Thomas Rohan , Looi Hong Aun , Andy Shevchenko , Ilpo Jarvinen Subject: Re: [Enable Designware XGMAC VLAN Stripping Feature v2 1/1] net: stmmac: dwxgmac2: Add support for HW-accelerated VLAN Stripping Message-ID: <48176576-e1d2-4c45-967a-91cabb982a21@lunn.ch> References: <20240527093339.30883-1-boon.khai.ng@intel.com> <20240527093339.30883-2-boon.khai.ng@intel.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240527093339.30883-2-boon.khai.ng@intel.com> > This implementation was ported from the dwmac4 driver. How does it differ from dwmac4? Can the dwmac4 implementation just be used, rather than duplicating all the code/bugs. Andrew