Received-SPF: pass (google.com: domain of linux-kernel+bounces-191375-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) client-ip=2604:1380:45e3:2400::1;
Precedence: bulk
MIME-Version: 1.0
References: <20240527062102.3816-2-shresthprasad7@gmail.com> <771db1ec-115f-4b96-916f-3975ca302f55@kernel.org>
In-Reply-To: <771db1ec-115f-4b96-916f-3975ca302f55@kernel.org>
From: Shresth Prasad <shresthprasad7@gmail.com>
Date: Tue, 28 May 2024 01:25:03 +0530
Message-ID: <CAE8VWiLbxeKKtW051nPxagRq6xqZ+J1SHrG=AhOx+NALv7-GGA@mail.gmail.com>
Subject: Re: [PATCH] dt-bindings: watchdog: img,pdc-wdt: Convert to dtschema
To: Krzysztof Kozlowski <krzk@kernel.org>
Cc: wim@linux-watchdog.org, linux@roeck-us.net, robh@kernel.org, 
	krzk+dt@kernel.org, conor+dt@kernel.org, linux-watchdog@vger.kernel.org, 
	devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, 
	skhan@linuxfoundation.org, javier.carrasco.cruz@gmail.com
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

On Tue, May 28, 2024 at 12:17=E2=80=AFAM Krzysztof Kozlowski <krzk@kernel.o=
rg> wrote:
>
> On 27/05/2024 08:21, Shresth Prasad wrote:
> > Convert txt bindings of ImgTec's PDC watchdog timer to dtschema to allo=
w
> > for validation.
> >
> > Signed-off-by: Shresth Prasad <shresthprasad7@gmail.com>
> > ---
> > The binding has been checked and tested against `img/pistachio_marduk.d=
ts`
> > with no errors or warnings.
> > ---
>
>
> Thank you for your patch. There is something to discuss/improve.
>
>
> > +
> > +maintainers:
> > +  - Shresth Prasad <shresthprasad7@gmail.com>
> > +
> > +
>
> Just one blank line.
>
> > +allOf:
> > +  - $ref: watchdog.yaml#
> > +
> > +properties:
> > +  compatible:
> > +    enum:
> > +      - img,pdc-wdt
> > +
> > +  reg:
> > +    maxItems: 1
> > +
> > +  clocks:
> > +    maxItems: 2
>
> Instead of maxItems please list items with description so the items will
> be described.
>
> > +
> > +  clock-names:
> > +    items:
> > +      - const: wdt
> > +      - const: sys
> > +
> > +  interrupts:
> > +    description:
> > +      Should contain WDT interrupt
>
> Drop description, redundant.
>
> > +    maxItems: 1
> > +
> > +  assigned-clocks:
> > +    maxItems: 2
>
> Drop property
>
> > +
> > +  assigned-clock-rates:
> > +    maxItems: 2
>
> Drop property
>
> > +
> > +required:
> > +  - compatible
> > +  - reg
> > +  - clocks
> > +  - clock-names
> > +  - interrupts
> > +
> Best regards,
> Krzysztof
>

Hi,

Thank you for the feedback.
I'll address these and resend the patch.

Regards,
Shresth