Received-SPF: pass (google.com: domain of linux-kernel+bounces-191384-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) client-ip=139.178.88.99;
Date: Mon, 27 May 2024 23:15:34 +0300
From: Andy Shevchenko <andriy.shevchenko@intel.com>
To: Woody Suwalski <terraluna977@gmail.com>
Cc: Guanbing Huang <albanhuang@outlook.com>, gregkh@linuxfoundation.org,
	rafael.j.wysocki@intel.com, linux-acpi@vger.kernel.org,
	tony@atomide.com, john.ogness@linutronix.de,
	yangyicong@hisilicon.com, jirislaby@kernel.org,
	linux-kernel@vger.kernel.org, linux-serial@vger.kernel.org,
	lvjianmin@loongson.cn, albanhuang@tencent.com,
	tombinfan@tencent.com
Subject: Re: Kernel 6.10-rc1 b,Build error with [PATCH v5 2/3] serial: port:
 Add support of PNP IRQ
Message-ID: <ZlTp5lGiT3pNF_di@smile.fi.intel.com>
References: <cover.1712472167.git.albanhuang@tencent.com>
 <PSAPR06MB4952C4112E75D882AC61CA5EC9002@PSAPR06MB4952.apcprd06.prod.outlook.com>
 <cc8a93b2-2504-9754-e26c-5d5c3bd1265c@gmail.com>
Precedence: bulk
MIME-Version: 1.0
Content-Type: text/plain; charset=iso-8859-1
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <cc8a93b2-2504-9754-e26c-5d5c3bd1265c@gmail.com>
Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo

On Mon, May 27, 2024 at 03:44:42PM -0400, Woody Suwalski wrote:
> Guanbing Huang wrote:
> > From: Guanbing Huang <albanhuang@tencent.com>
> > 
> > The function __uart_read_properties doesn't cover PNP devices, so add IRQ
> > processing for PNP devices in the branch.

..

> >   #include <linux/property.h>
> >   #include <linux/serial_core.h>
> >   #include <linux/spinlock.h>
> > @@ -221,7 +222,11 @@ static int __uart_read_properties(struct uart_port *port, bool use_defaults)
> >   	if (dev_is_platform(dev))
> >   		ret = platform_get_irq(to_platform_device(dev), 0);
> > -	else
> > +	else if (dev_is_pnp(dev)) {
> > +		ret = pnp_irq(to_pnp_dev(dev), 0);
> > +		if (ret < 0)
> > +			ret = -ENXIO;
> > +	} else
> >   		ret = fwnode_irq_get(dev_fwnode(dev), 0);
> >   	if (ret == -EPROBE_DEFER)
> >   		return ret;
> 
> Hello all, trying to build 6.10-rc1 fails for me in serial_base.o:
> ? CALL??? scripts/checksyscalls.sh
> ? DESCEND objtool
> ? INSTALL libsubcmd_headers
> ? CC [M]? drivers/tty/serial/serial_port.o
> ? LD [M]? drivers/tty/serial/serial_base.o
> ? MODPOST Module.symvers
> ERROR: modpost: "pnp_bus_type" [drivers/tty/serial/serial_base.ko]
> undefined!
> make[2]: *** [scripts/Makefile.modpost:145: Module.symvers] Error 1
> make[1]: ***
> [/woody/src/kernels/linux-6.10-pingu/work/linux-6.10/Makefile:1892: modpost]
> Error 2
> make: *** [Makefile:246: __sub-make] Error 2
> 
> Reversing the patch "fixes" the problem :-(
> I am building on a Debian bookworm system, gcc 12.2
> 
> Any suggestions? how to make it work?

Yes, I will send a patch soon. Thanks for the report!

-- 
With Best Regards,
Andy Shevchenko