Received-SPF: pass (google.com: domain of linux-kernel+bounces-191466-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) client-ip=139.178.88.99;
Date: Mon, 27 May 2024 23:43:39 +0200
From: Sebastian Reichel <sebastian.reichel@collabora.com>
To: Thomas =?utf-8?Q?Wei=C3=9Fschuh?= <linux@weissschuh.net>
Cc: "Rafael J. Wysocki" <rafael@kernel.org>, Len Brown <lenb@kernel.org>, 
	linux-acpi@vger.kernel.org, linux-kernel@vger.kernel.org, linux-pm@vger.kernel.org, 
	Rajas Paranjpe <paranjperajas@gmail.com>
Subject: Re: [PATCH] ACPI: AC: Properly notify powermanagement core about
 changes
Message-ID: <r5x24fxz5cbyd4laoteq577toqfblfmy4btn4c6o6rrl7godeu@4fgsimcubzrd>
References: <20240526-acpi-ac-changed-v1-1-f4b5997753bb@weissschuh.net>
Precedence: bulk
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
	protocol="application/pgp-signature"; boundary="ocxnujsdr2oxrri5"
Content-Disposition: inline
In-Reply-To: <20240526-acpi-ac-changed-v1-1-f4b5997753bb@weissschuh.net>


--ocxnujsdr2oxrri5
Content-Type: text/plain; charset=iso-8859-1
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

Hi,

On Sun, May 26, 2024 at 11:40:01PM +0200, Thomas Wei=DFschuh wrote:
> The powermanagement core does various actions when a power-supply changes.
> It calls into notifiers, LED triggers, other power supplies and emits an =
uevent.
>=20
> To make sure that all these actions happen properly call power_supply_cha=
nged().
>=20
> Reported-by: Rajas Paranjpe <paranjperajas@gmail.com>
> Closes: https://github.com/MrChromebox/firmware/issues/420#issuecomment-2=
132251318
> Signed-off-by: Thomas Wei=DFschuh <linux@weissschuh.net>
> ---

Reviewed-by: Sebastian Reichel <sebastian.reichel@collabora.com>

-- Sebastian

>  drivers/acpi/ac.c  | 4 ++--
>  drivers/acpi/sbs.c | 4 ++--
>  2 files changed, 4 insertions(+), 4 deletions(-)
>=20
> diff --git a/drivers/acpi/ac.c b/drivers/acpi/ac.c
> index 2d4a35e6dd18..09a87fa222c7 100644
> --- a/drivers/acpi/ac.c
> +++ b/drivers/acpi/ac.c
> @@ -145,7 +145,7 @@ static void acpi_ac_notify(acpi_handle handle, u32 ev=
ent, void *data)
>  						  dev_name(&adev->dev), event,
>  						  (u32) ac->state);
>  		acpi_notifier_call_chain(adev, event, (u32) ac->state);
> -		kobject_uevent(&ac->charger->dev.kobj, KOBJ_CHANGE);
> +		power_supply_changed(ac->charger);
>  	}
>  }
> =20
> @@ -268,7 +268,7 @@ static int acpi_ac_resume(struct device *dev)
>  	if (acpi_ac_get_state(ac))
>  		return 0;
>  	if (old_state !=3D ac->state)
> -		kobject_uevent(&ac->charger->dev.kobj, KOBJ_CHANGE);
> +		power_supply_changed(ac->charger);
> =20
>  	return 0;
>  }
> diff --git a/drivers/acpi/sbs.c b/drivers/acpi/sbs.c
> index 94e3c000df2e..dc8164b182dc 100644
> --- a/drivers/acpi/sbs.c
> +++ b/drivers/acpi/sbs.c
> @@ -610,7 +610,7 @@ static void acpi_sbs_callback(void *context)
>  	if (sbs->charger_exists) {
>  		acpi_ac_get_present(sbs);
>  		if (sbs->charger_present !=3D saved_charger_state)
> -			kobject_uevent(&sbs->charger->dev.kobj, KOBJ_CHANGE);
> +			power_supply_changed(sbs->charger);
>  	}
> =20
>  	if (sbs->manager_present) {
> @@ -622,7 +622,7 @@ static void acpi_sbs_callback(void *context)
>  			acpi_battery_read(bat);
>  			if (saved_battery_state =3D=3D bat->present)
>  				continue;
> -			kobject_uevent(&bat->bat->dev.kobj, KOBJ_CHANGE);
> +			power_supply_changed(bat->bat);
>  		}
>  	}
>  }
>=20
> ---
> base-commit: 6fbf71854e2ddea7c99397772fbbb3783bfe15b5
> change-id: 20240526-acpi-ac-changed-a08c6941ae51
>=20
> Best regards,
> --=20
> Thomas Wei=DFschuh <linux@weissschuh.net>
>=20

--ocxnujsdr2oxrri5
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQIzBAABCgAdFiEE72YNB0Y/i3JqeVQT2O7X88g7+poFAmZU/ooACgkQ2O7X88g7
+ppSEw//cGUjBMrRvbVbNEw4zn0y5P/uJwp8Gdhfa2WuF9iKNPAIAP4BuoQVSroi
CfeN0uAe7VOXj6DHrAZLzRx2JyCRqfbA4xV0dOa1NMLwZBMBcAHhI/zE/Uyb/Ajh
x9y/W36z/k34ciEHYGA7fHLhbFvSyQzDEgDE2ivByhMlMZMxSpRsovjc34eeUaty
2IB17/Vqmdu+LK0MYuTitnolNHKxxJBoAeGeIpuUCKUlmaKNj1RjpR10P1yoXHpH
SYsYwbqUNCSPUL1zoYooQg+/w65Sm8vAdNN2rWSaM7F0Jw7jo/eqVWHOgI8Lk6bD
LLjE2+DzMWmO2KwmE03seN2Hc6vhqC1PgSEw8rI18Cl40lk/IIFmf89uO1s5FIfk
cbp6Qc8AknlhvTNw3+GSV/C1602N17hRJ/viL9xWtWZtGG0L34rc2fy9pOaIfwtM
5FoenJR0ZBGFbROrFgCZEork98KL8wERj973YnyQ0pb4QtUv20tRDc+s4cBSHuSe
1pPPk9MNCTnS5vdKzYGjOBKQKwOCXqQR415K5ltYca//MqZrrqq6+7rFAL2fYAR+
eYl7w0Ree1/TJmCaTi/IUZv7JpOHZBIP+21544X3FwKSYis3Uwaij9HNf3dNFEoD
m5jZHKUv90AO3yKugzuUioTTvhBtd0XMzWWClJcYwTmOyQUvOdE=
=6hnM
-----END PGP SIGNATURE-----

--ocxnujsdr2oxrri5--