Received: by 2002:a89:d88:0:b0:1fa:5c73:8e2d with SMTP id eb8csp2297155lqb; Mon, 27 May 2024 15:05:03 -0700 (PDT) X-Forwarded-Encrypted: i=3; AJvYcCVcYyKFfzc7kGoC8NT3xsv54+VKhpjPGZtNTlCilKFKa/V5sZ4NnNzRbYlYAamOJS4qHlAvLuhTjhPscHz/x8VYJSZGto1wp05hEouGMQ== X-Google-Smtp-Source: AGHT+IEL4+xMyL+++SddjPTEx0XvuNPAHtYoPYeWJoOGSAMF8ZuB3bd6aB9rntKRu0/yyEsoHMze X-Received: by 2002:a17:90b:3113:b0:2bd:f3ee:c903 with SMTP id 98e67ed59e1d1-2bf5e0b818cmr10239588a91.0.1716847502867; Mon, 27 May 2024 15:05:02 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1716847502; cv=pass; d=google.com; s=arc-20160816; b=Zc5Jt0aJ22ddiG30u5xOTmmePRg0E3Sf80LU27x/FledZ5RGjCfkLKpNKh3j0zi2Wh OfUf3qH0oOBVLcHbSS1H/6X9gfhoApsy3XZGN92uxjSS+4KRoXNLglf+kLjbBoF6Iise VMQCOS/v0J8likb5EEZlpiShnRPqHhozEmul5OYIRiwsZZwWhU1LXnGsjBtZJBl27eoj HMwfnw9cPgmpaBR2/VJjZ+DyMYi/tqeSxLPIRhKlOcDpjEavDXDNZfn0oh4ewPWS7ifs XL4TeqpkyRueQOS/aojybR9Z/cnqXMWadgKyn/bG86u+20KXIEqcbfaklBRQK/BAklFb 2x5Q== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=in-reply-to:content-disposition:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:references:message-id:subject:cc :to:from:date:dkim-signature; bh=ViXsFVHEpafS5EmxmYJWnIhjbXPQX8peMdEzB/gglf8=; fh=AzUWqtGHdeWuBYhghF+P768qBhaZEFaYtYPUBuvcLlc=; b=ps0ubJ6+YeFVhQUMumLHPKne3DjMpSe6NAC5GRxgUtZNmnDhYEqPVFzGHPnW1ebQrm 1LwNKdMuqTPsdmc+5bEMCkkskr7pDnjVilUit7ohDD9ABjH9TP3KyM020npeQPZiVP6t vp+CE17fFdCxxeKZQq6/+kDZCsiH73gIVhhjggBtKVMpD2j00QjugEF8/1r2W2PrKekT jmmdfYOK3vmndxqArKgX99qkJzIdo5m6XSBqfxr36h8pM1CTi2lTAfQge22wReR1/wK8 GWm7dXIbXrwmpuANMW893uHiSLHg1T0Jj/ojRwu73zY3EC3ahjJFj6Ybu97kujaCfN9X TlKw==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@lunn.ch header.s=20171124 header.b=4gz2wLZF; arc=pass (i=1 spf=pass spfdomain=lunn.ch dkim=pass dkdomain=lunn.ch dmarc=pass fromdomain=lunn.ch); spf=pass (google.com: domain of linux-kernel+bounces-191472-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:40f1:3f00::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-191472-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=lunn.ch Return-Path: Received: from sy.mirrors.kernel.org (sy.mirrors.kernel.org. [2604:1380:40f1:3f00::1]) by mx.google.com with ESMTPS id 98e67ed59e1d1-2bdd9ef2a30si8576108a91.62.2024.05.27.15.05.02 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 27 May 2024 15:05:02 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel+bounces-191472-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:40f1:3f00::1 as permitted sender) client-ip=2604:1380:40f1:3f00::1; Authentication-Results: mx.google.com; dkim=pass header.i=@lunn.ch header.s=20171124 header.b=4gz2wLZF; arc=pass (i=1 spf=pass spfdomain=lunn.ch dkim=pass dkdomain=lunn.ch dmarc=pass fromdomain=lunn.ch); spf=pass (google.com: domain of linux-kernel+bounces-191472-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:40f1:3f00::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-191472-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=lunn.ch Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sy.mirrors.kernel.org (Postfix) with ESMTPS id 0D291B21B7B for ; Mon, 27 May 2024 22:04:59 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id D57E21667EE; Mon, 27 May 2024 22:04:49 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=lunn.ch header.i=@lunn.ch header.b="4gz2wLZF" Received: from vps0.lunn.ch (vps0.lunn.ch [156.67.10.101]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 8BA3B1754B; Mon, 27 May 2024 22:04:46 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=156.67.10.101 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1716847489; cv=none; b=mn7mTV7J8kGKgFPZFvmaFcCcMLulOuWvDPh4kUdUcRwKm0AmNP38MvCkCMV0ylwmR3wWRwPt1n4V4ox3JZY5qF+0B2uaDttsxhyK5BpqBKMUwzjaMMi4+oCUXeTqK2o89zOf/w3gi+IGMvvR7GAXoovwaZCyUmVD7gnXo1AP61k= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1716847489; c=relaxed/simple; bh=4id6nwrH30cfb7kbRwgCZMpR9t+BkTu7eYCDXgeizbc=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=tQm7Rug8brAOXyO4cM3f+dObK/lclerygxYF/f9Udp6w1xWwWSTmAq6zGveAWQBAwjrs1LToQCxqfCBH6suKhvZots9NrHy1E8h9oOA2ZL/OzhlAJ+dBMYzSmNUVpUm386CQSkZyfuVo9pIw2oKHgz+d+xeX++gg3CVG8ze2J8M= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=lunn.ch; spf=pass smtp.mailfrom=lunn.ch; dkim=pass (1024-bit key) header.d=lunn.ch header.i=@lunn.ch header.b=4gz2wLZF; arc=none smtp.client-ip=156.67.10.101 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=lunn.ch Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=lunn.ch DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lunn.ch; s=20171124; h=In-Reply-To:Content-Disposition:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:From:Sender:Reply-To:Subject: Date:Message-ID:To:Cc:MIME-Version:Content-Type:Content-Transfer-Encoding: Content-ID:Content-Description:Content-Disposition:In-Reply-To:References; bh=ViXsFVHEpafS5EmxmYJWnIhjbXPQX8peMdEzB/gglf8=; b=4gz2wLZFxJ9C3AfaGWJjrdQYr6 y4xNFz4d1B8KdxB3BRdDWFj5GuKH0kegvFgevXQ0Rnh3eb8IZTm7y8IWGz1Xiup07Jr0ieeiQPr5L 9GIK/NxNVSiQ7AOsMIuuoFdfVlUtuJiHFLvJrg9OW/9AanlkFGXMhhJHvVqEAPr6/7YU=; Received: from andrew by vps0.lunn.ch with local (Exim 4.94.2) (envelope-from ) id 1sBiS9-00G6lY-7V; Tue, 28 May 2024 00:04:25 +0200 Date: Tue, 28 May 2024 00:04:25 +0200 From: Andrew Lunn To: MD Danish Anwar Cc: Dan Carpenter , Jan Kiszka , Simon Horman , Vladimir Oltean , Wolfram Sang , Niklas Schnelle , Arnd Bergmann , Diogo Ivo , Roger Quadros , Paolo Abeni , Jakub Kicinski , Eric Dumazet , "David S. Miller" , linux-arm-kernel@lists.infradead.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, srk@ti.com, Vignesh Raghavendra Subject: Re: [PATCH net-next v5 1/3] net: ti: icssg-prueth: Add helper functions to configure FDB Message-ID: <3cf97632-4d77-4f28-bed6-7d40d61d958f@lunn.ch> References: <20240527052738.152821-1-danishanwar@ti.com> <20240527052738.152821-2-danishanwar@ti.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240527052738.152821-2-danishanwar@ti.com> > +struct mgmt_cmd { > + u8 param; > + u8 seqnum; > + u8 type; > + u8 header; > + u32 cmd_args[3]; > +} __packed; There is a general dislike for __packed. Since your structures are naturally well aligned, it is probably not needed. You could be paranoid and add BUILD_BUG_ON(sizeof(struct mgmt_cmd) != 16); Andrew