Received-SPF: pass (google.com: domain of linux-kernel+bounces-191490-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) client-ip=2604:1380:45d1:ec00::1;
Date: Tue, 28 May 2024 06:25:21 +0800
From: Inochi Amaoto <inochiama@outlook.com>
To: Thomas Bonnefille <thomas.bonnefille@bootlin.com>, 
	Rob Herring <robh@kernel.org>, Krzysztof Kozlowski <krzk+dt@kernel.org>, 
	Conor Dooley <conor+dt@kernel.org>, Paul Walmsley <paul.walmsley@sifive.com>, 
	Chen Wang <unicorn_wang@outlook.com>, Inochi Amaoto <inochiama@outlook.com>, 
	Chao Wei <chao.wei@sophgo.com>
Cc: Albert Ou <aou@eecs.berkeley.edu>, Palmer Dabbelt <palmer@dabbelt.com>, 
	Samuel Holland <samuel.holland@sifive.com>, Thomas Gleixner <tglx@linutronix.de>, 
	Daniel Lezcano <daniel.lezcano@linaro.org>, Thomas Petazzoni <thomas.petazzoni@bootlin.com>, 
	=?utf-8?Q?Miqu=C3=A8l?= Raynal <miquel.raynal@bootlin.com>, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, 
	linux-riscv@lists.infradead.org
Subject: Re: [PATCH 5/5] riscv: dts: sophgo: Add LicheeRV Nano board device
 tree
Message-ID:
 <IA1PR20MB49535CBF66DB31C2059C291ABBF02@IA1PR20MB4953.namprd20.prod.outlook.com>
References: <20240527-sg2002-v1-0-1b6cb38ce8f4@bootlin.com>
 <20240527-sg2002-v1-5-1b6cb38ce8f4@bootlin.com>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20240527-sg2002-v1-5-1b6cb38ce8f4@bootlin.com>
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-MessageSentRepresentingType: 1
X-MS-PublicTrafficType: Email
X-MS-TrafficTypeDiagnostic: IA1PR20MB4953:EE_|PH7PR20MB5945:EE_
X-MS-Office365-Filtering-Correlation-Id: aec4e3cf-00d2-48d4-e514-08dc7e9bec7d
X-Microsoft-Antispam:
	BCL:0;ARA:14566002|461199019|1602099003|3412199016|440099019|1710799017;
X-Microsoft-Antispam-Message-Info:
	uuEtMfY2bi7EDPQuqS3M+p78LMgAdAQbbbBoUiTIjQ/hLpo7lY3y+mg9j5ZKFYN3SD6vFyBe1EkdgclDVKGm1++xs54XwNOUAiowDl0/MOtZBZaSZfM1F7H8VLPpmvHFqXMozmRg2LvubBeZ01AOCOBH9uEQAGRNSsrcPa/5ttDttnR7dLBN+f/3907mK4l2q/kCSttmNkfIKt+MDLvqZGmIXJYks62h69dHsPAuEfm8kNmruqI9pX2wH3UdUA4Od7D6mpV7YYssR8T49xZAjEQGFdCFF/wEhkUNXZkfb3AGl5Oy+yZGEnUJ3whV5nIQtgVQz0FmJvLu3QbHTJFcAfq/QtAq1wGERetU501Lkcuk5es8HIXvYEzR62Rc/gAzcQnhSBzWmh5j3lTbUmG0IVrggmB/WrauL8U+rmszEUjZTDSu7Y89mB7/u4ZzeUpHNAOIUmbuCsf3n0aHJ/q/kA27tStfvbIdZ92uf4Ug03MqKVhv1qkNO3SGw4Fa9y0aUVGQhzak2JYdzunuWjYbgspq0a9HGaKknrPXcZbfMSdDSK3lSy7tDqkKi1by7sg5odUM2xua/CNATZ5XLXRMANb4cDigk7L4hVOfmieApUh1kHMwMcBUnH4bk28zytpDxxRTR4LLuse2A1hWhLYDX+S+ImFOpUzuDpk5uIAE0MR9pc4FEGTaulz/3qqS4cfe
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?us-ascii?Q?+bvXGaq2dMAzRvdGEaUB0ETL6MHSRj+VR/UZiNOKhfc74egKUp+qej7u3401?=
 =?us-ascii?Q?M8uCIhfUF+EYQP7Vt7B1oQZbiGK/rgzt2Xy+iYEmkoAVeXstoS52MQIpIC8d?=
 =?us-ascii?Q?bnVCDAeTMWhsmaptKG4UNfKtC00tEkIVg0/XIXpIay/L6vT+mlr1HX3QNiF+?=
 =?us-ascii?Q?/YJjzB2GC0zQxJciTDixyNaC07namn3QK/V+tb5LPrCX/Ldo8ChpnR8FQmTf?=
 =?us-ascii?Q?fz3cZmR4VuU5Ry075bI0L0wl/sldWq6sIc6xKzjcwSh/cqt71HBJXFpmofl4?=
 =?us-ascii?Q?Fhp1HN5AJ4VDFOsyxefJa6n004+4kEkM70i+0o0qpJZkFdCLDSZXBGLYstaT?=
 =?us-ascii?Q?CjhD2dF20aL0QiHaAOZ3Gl+EoN89lpMEPsVFx25lN9zsgJyPEU78+x0yeTx2?=
 =?us-ascii?Q?mgdNwDjSNAngG+cO4K7/dhoitu3N1/x+slwDfN5dlq4pSav2PVRk0e+1QNS2?=
 =?us-ascii?Q?Vi+WyrCjFqaUtU0Fe5cHx8FD5IuGx4YHN1QXWdBdJeiZQJgLZTfUlrnJ8X7z?=
 =?us-ascii?Q?Tr4dGe9eLZTME8BogvUJqV1N69DrJHpsuoDmNihzEkO3hGk2AOl5RJsfN4ni?=
 =?us-ascii?Q?Svu4Wr8FTA056ksKtAj/q8zJdmvZPr5fO+GASs8MqKBxUDibch0WVMW5ryca?=
 =?us-ascii?Q?PceJTq1wJqxFUscNMWPRzQB+SIRyClIEpKejaWszZ6mbFDIZ50tQIquIB/sv?=
 =?us-ascii?Q?XC4UmrSVA378bLjq4jxRdIw8MMQYSh5rb0TwNTSh3x9minx86V+UECVGKQJl?=
 =?us-ascii?Q?R52fyKW/QAsiRcZWPMn823yQNhTADN1/jTGTT3nFQjNzoMY45flFL2yGsW8l?=
 =?us-ascii?Q?rCXRRMLlX47vkrX2NmMcizECmkB4o6H51Y/ccZBrhFT17WQhVPSb1hgGPcTa?=
 =?us-ascii?Q?o7rMOOMlx5NX/iNsaysAyDvL3QOY+FGyR45mrGrWPpMES85CwPnFbHy1o8V2?=
 =?us-ascii?Q?Nzqseg0zMS6DtDRZo42ucBs9QRZRrcNgaLV9IPMnBNwhq6sS8lNYyaiHPeVM?=
 =?us-ascii?Q?Lm+LCYcs0+QYnwnjVd0EYMt6AcFg7MWQmsckguBSW0yR+y6bkNSNG0TSW3P3?=
 =?us-ascii?Q?eO8GbucOT8x1pi+gG1WjE4vAbtXjoHniXYGDWeqTL1RBWg03VaLNDGwipZmB?=
 =?us-ascii?Q?UlUDqiHW0pMWCAWLTHkIbcTMj/sVDuOUFPeGGXXRlusT5T6/8IkBNmcT7B8j?=
 =?us-ascii?Q?MppzHK1PWmDtAgvZFaNF96Nfi+3qtxzEgBsXresxsg3mZZsKUNjprTufqjDy?=
 =?us-ascii?Q?3q/VNgsN80KbY9gBOult?=
X-OriginatorOrg: outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: aec4e3cf-00d2-48d4-e514-08dc7e9bec7d
X-MS-Exchange-CrossTenant-AuthSource: IA1PR20MB4953.namprd20.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 27 May 2024 22:25:33.5385
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 84df9e7f-e9f6-40af-b435-aaaaaaaaaaaa
X-MS-Exchange-CrossTenant-RMS-PersistedConsumerOrg:
	00000000-0000-0000-0000-000000000000
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH7PR20MB5945

On Mon, May 27, 2024 at 12:28:21PM GMT, Thomas Bonnefille wrote:
> LicheeRV Nano [1] is an embedded development platform base on the SOPHGO
> SG2002 chip.
> 
> Add only support for UART.
> 

Although this is OK, I think you can also add sdhci node, it is already
supported.

> Link: https://wiki.sipeed.com/hardware/en/lichee/RV_Nano/1_intro.html
> [1]
> 
> Signed-off-by: Thomas Bonnefille <thomas.bonnefille@bootlin.com>
> ---
>  arch/riscv/boot/dts/sophgo/Makefile                |  1 +
>  .../boot/dts/sophgo/sg2002-lichee-rv-nano.dts      | 25 ++++++++++++++++++++++
>  2 files changed, 26 insertions(+)
> 
> diff --git a/arch/riscv/boot/dts/sophgo/Makefile b/arch/riscv/boot/dts/sophgo/Makefile
> index 57ad82a61ea6..5759b21805dc 100644
> --- a/arch/riscv/boot/dts/sophgo/Makefile
> +++ b/arch/riscv/boot/dts/sophgo/Makefile
> @@ -1,4 +1,5 @@
>  # SPDX-License-Identifier: GPL-2.0
>  dtb-$(CONFIG_ARCH_SOPHGO) += cv1800b-milkv-duo.dtb
>  dtb-$(CONFIG_ARCH_SOPHGO) += cv1812h-huashan-pi.dtb
> +dtb-$(CONFIG_ARCH_SOPHGO) += sg2002-licheerv-nano.dtb
>  dtb-$(CONFIG_ARCH_SOPHGO) += sg2042-milkv-pioneer.dtb
> diff --git a/arch/riscv/boot/dts/sophgo/sg2002-lichee-rv-nano.dts b/arch/riscv/boot/dts/sophgo/sg2002-lichee-rv-nano.dts
> new file mode 100644
> index 000000000000..aaad2733801b
> --- /dev/null
> +++ b/arch/riscv/boot/dts/sophgo/sg2002-lichee-rv-nano.dts
> @@ -0,0 +1,25 @@
> +// SPDX-License-Identifier: (GPL-2.0 OR MIT)
> +/*
> + * Copyright (C) 2024 Thomas Bonnefille <thomas.bonnefille@bootlin.com>
> + */
> +
> +/dts-v1/;
> +
> +#include "sg2002.dtsi"
> +
> +/ {
> +	model = "LicheeRV Nano";
> +	compatible = "sipeed,licheerv-nano", "sophgo,sg2002";

Use the right version, rv nano have several versions with different 
peripherals. The compatible is good for the common file, but not the 
specific board.

> +
> +	aliases {
> +		serial0 = &uart0;
> +	};
> +
> +	chosen {
> +		stdout-path = "serial0:115200n8";
> +	};

It is also better to add all already support nodes, such as gpio, 
other uart port.

> +};
> +
> +&uart0 {
> +	status = "okay";
> +};
> 
> -- 
> 2.45.1
>