Received-SPF: pass (google.com: domain of linux-kernel+bounces-191494-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:40f1:3f00::1 as permitted sender) client-ip=2604:1380:40f1:3f00::1;
Message-ID: <e39b652c-ba0e-4c54-971e-8df9a2a5d0be@intel.com>
Date: Tue, 28 May 2024 10:36:13 +1200
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH v2 3/6] KVM: Add a module param to allow enabling
 virtualization when KVM is loaded
To: Chao Gao <chao.gao@intel.com>
CC: Sean Christopherson <seanjc@google.com>, Paolo Bonzini
	<pbonzini@redhat.com>, <kvm@vger.kernel.org>, <linux-kernel@vger.kernel.org>
References: <20240522022827.1690416-1-seanjc@google.com>
 <20240522022827.1690416-4-seanjc@google.com>
 <8b344a16-b28a-4f75-9c1a-a4edf2aa4a11@intel.com>
 <Zk7Eu0WS0j6/mmZT@chao-email>
 <c4fa17ca-d361-4cb7-a897-9812571aa75f@intel.com>
 <Zk/9xMepBqAXEItK@chao-email>
Content-Language: en-US
From: "Huang, Kai" <kai.huang@intel.com>
In-Reply-To: <Zk/9xMepBqAXEItK@chao-email>
Content-Type: text/plain; charset="UTF-8"; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?Z3RTdk5MazRIWTRneUROM0lhZElvNUp0WnJtaGlLblgvWk5JSWJNREVmS0JJ?=
 =?utf-8?B?S2plMlFtV3Y4U1pzeWdDRFYzYzRnRmw1NGx6U2VRMmdzOFBJRkxhN0IybCtj?=
 =?utf-8?B?S3hwVkhNMm81angzc1RJWDFtSTZ2WC9WNk9xSkVhYzBkTDlienRpV0hqcHcy?=
 =?utf-8?B?OUdYVE1tcHhKa0VmM2EwNVZzVkgwbzNwdVVhbFlKUTJoanJ0Zjh5ZzZDNnh3?=
 =?utf-8?B?NXB1STdZenU5akJQOW1LOHZ3VTVCQnUvdUdhY01Vdkw0YzF5UHBkRmdNWThp?=
 =?utf-8?B?dXZ2c1FXS3phcnY1dVR2c3dqUGViM1E1bld1SmFSeDdpU3l3K01YNUFCK2x3?=
 =?utf-8?B?dnJ5UktrL1IwSEtnNWl6cktEMUFxQk42ajJic3ArelhqWlZrd3l0QkZFQjZv?=
 =?utf-8?B?OTBIcnpWTlptZU5CVW9PdGdNSmc0ZmpsSDE1S3dER0RIWEkrb003aHVSU3NQ?=
 =?utf-8?B?cWhjQkJnd1RBNHdlZE9QY1pJeHR6UHhJeWJmN3ZRTGcrRG9aQ3k0TDB2L0NH?=
 =?utf-8?B?K3pIeWZPOG9lRngzcS9NUUYvNHRIZ0I3VDhyUnBIV0ZodGV1Y1BEUko2ZnhE?=
 =?utf-8?B?OFJvVGxPeFFISnZRNEE2eUxDWHFERkl2aXFkbXVNTlUxN3lCUE1jeUJwck9T?=
 =?utf-8?B?cW0vTEdDSjRQRE5kb1J5ZmpLN0VlRGMwSlRWYXNkcjJjbCtoVnZIbUN1TXIx?=
 =?utf-8?B?V2FLOU5LTnh3WmE3ZlpFMDZnWGQ3T1VWc3N2dXhQQjV2SWkydllqM0FqVERY?=
 =?utf-8?B?Ulg5S1hEeWkvWjNNcU5BdlRucE85R0EzNmxxRXZWTjhwcjQrelFHU2xwMlRq?=
 =?utf-8?B?dlNpaHZWakcvMzJ0ZDl4bE5pZmFqaVI1N3p1aVJVTjh3Qit6S05WN2NWb2Zz?=
 =?utf-8?B?QlpkTm5qcjJKa0RLOHExK2V6UFZBMTJhYXBuMndpT01TQ1V5RUZoWWprWTAv?=
 =?utf-8?B?Q1ZCSkRPVjU1L0dOT3c0cjJ5NXFQYkZYV1RpaS8xOG44NmZzNnpGMEw4K3Jv?=
 =?utf-8?B?MVZjK3k4ZUd4OXRsTHEva0xUY29LYjhPRDBFUlN1VG5rTzJ6Qy9KNDBuN0VW?=
 =?utf-8?B?cm9hckYzVDZES0laL0NGd0NFNnZJM0ZFdDdQOGhrNlhNeGlxZG9lYWc1YlRo?=
 =?utf-8?B?YlovRDE0RjN3WEhEdVh2ZlM4RFVYNTd1elNoSUM0TmhGdTl3dmZBdWxDc3pa?=
 =?utf-8?B?LytqZ3dRTWhMS1hoT09HSU1MczdFUWdKcGZrMnpDQmg0U3Vjdit1NlRwbHVk?=
 =?utf-8?B?aXhMUjFueW5LbjY1ZkhrcWRnQkkvYWNFeHdGUkJwUkxnd1BTSENKd1k5K3Vh?=
 =?utf-8?B?enJDZHZRWWkrN1ZiZUswWEZxQTJNNHFrN1JiWHFrQlFDRXg4MEtheFBLdDJV?=
 =?utf-8?B?QktiTmFwNUdDcHBtNVNGYlh0SUpkQ2h2WkFOWW9oRkpoQzdMY3BZUE9ORFFF?=
 =?utf-8?B?eVhVTVlJUGdPdGVyaDZXL2FNYndzaHc3S1hIbHNuRmdIbFo4VEZod2ppQ0w2?=
 =?utf-8?B?ZVlPeFFBdm0xa204NUVmaHVDbmdjdlVWNVdRMEtCdHhIaDcrbFNlV0IzRFpm?=
 =?utf-8?B?V2FNL21sL3Qzd1hObUxDWDQyZzU1RGZjQnlvQlFLNS9yeGhuOE81cHZEQUJK?=
 =?utf-8?B?WWJRNUFENW1uM2d1bnJxNnhwRnVuc29GcGIycllLdWtRNVFIcDQ0QjgxSSt6?=
 =?utf-8?B?SUMyb3JxaGR0aTBhaTliQVhiUUdUODNybk5EMFdob3A5SUY3NW1tK2gvbUho?=
 =?utf-8?B?ajZDWGFqbnZhQXJtVnFhaDlWbmlVeEt2WFgvTkNuOGwvT1hFeTVxaTFGTG91?=
 =?utf-8?B?TnhZL1NmZncvUmF0Y2pmdEJHbjJpT3NrZVZLZWQ1bDBGUU0yRWtZdjRRM0gz?=
 =?utf-8?B?VnEyRmEzd3JyVzlEMnVLT2FRaFNhWWw4dnpMR09VSnc4eVhrR2p5QzZERGl2?=
 =?utf-8?B?RTV5dFd1QURVb2t5TXRCdDE4K2xMTlE0Q3ZpWm02RUUvcDh4Z0dMWXR6bjF3?=
 =?utf-8?B?b3dVR3dRaWozMVJsQWR2K3JxdlppRm9kSGJGOUN5N1piSEpzTS9UR2ZZUG1G?=
 =?utf-8?B?SjVMRDJ2alEyc25lM2x1dUJhVTN4SStTM0FCaGlxZEppQ0RndzZWU0FwSHVa?=
 =?utf-8?Q?AGnSl8rif5Wy9uydZsxjr/82/?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 8e3b0207-190e-4c06-c2be-08dc7e9d6e0e
X-MS-Exchange-CrossTenant-AuthSource: BL1PR11MB5978.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 27 May 2024 22:36:20.2974
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: uaa/ifJaZCjlIxGBWvYuRW2Thhk+rWj0rGPFSIH7KG356r8ewv3KBZEjAsA0bE3vVDfCGdsRnMc/TqTaDemAHA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA2PR11MB4955
X-OriginatorOrg: intel.com


On 24/05/2024 2:39 pm, Chao Gao wrote:
> On Fri, May 24, 2024 at 11:11:37AM +1200, Huang, Kai wrote:
>>
>>
>> On 23/05/2024 4:23 pm, Chao Gao wrote:
>>> On Thu, May 23, 2024 at 10:27:53AM +1200, Huang, Kai wrote:
>>>>
>>>>
>>>> On 22/05/2024 2:28 pm, Sean Christopherson wrote:
>>>>> Add an off-by-default module param, enable_virt_at_load, to let userspace
>>>>> force virtualization to be enabled in hardware when KVM is initialized,
>>>>> i.e. just before /dev/kvm is exposed to userspace.  Enabling virtualization
>>>>> during KVM initialization allows userspace to avoid the additional latency
>>>>> when creating/destroying the first/last VM.  Now that KVM uses the cpuhp
>>>>> framework to do per-CPU enabling, the latency could be non-trivial as the
>>>>> cpuhup bringup/teardown is serialized across CPUs, e.g. the latency could
>>>>> be problematic for use case that need to spin up VMs quickly.
>>>>
>>>> How about we defer this until there's a real complain that this isn't
>>>> acceptable?  To me it doesn't sound "latency of creating the first VM"
>>>> matters a lot in the real CSP deployments.
>>>
>>> I suspect kselftest and kvm-unit-tests will be impacted a lot because
>>> hundreds of tests are run serially. And it looks clumsy to reload KVM
>>> module to set enable_virt_at_load to make tests run faster. I think the
>>> test slowdown is a more realistic problem than running an off-tree
>>> hypervisor, so I vote to make enabling virtualization at load time the
>>> default behavior and if we really want to support an off-tree hypervisor,
>>> we can add a new module param to opt in enabling virtualization at runtime.
>>
>> I am not following why off-tree hypervisor is ever related to this.
> 
> Enabling virtualization at runtime was added to support an off-tree hypervisor
> (see the commit below).  

Oh, ok.  I was thinking something else.

>>
>> The problem of enabling virt during module loading by default is it impacts
>> all ARCHs. Given this performance downgrade (if we care) can be resolved by
>> explicitly doing on_each_cpu() below, I am not sure why we want to choose
>> this radical approach.
> 
> IIUC, we plan to set up TDX module at KVM load time; we need to enable virt
> at load time at least for TDX. Definitely, on_each_cpu() can solve the perf
> concern. But a solution which can also satisfy TDX's need is better to me.
> 

Doing on_each_cpu() explicitly can also meet TDX's purpose.  We just 
explicitly enable virtualization during module loading if we are going 
to enable TDX.  For all other cases, the behaivour remains the same, 
unless they want to change when to enable virtualization, e.g., when 
loading module by default.

For always, or by default enabling virtualization during module loading, 
we somehow discussed before:

https://lore.kernel.org/kvm/ZiKoqMk-wZKdiar9@google.com/

My true comment is introducing a module parameter, which is a userspace 
ABI, to just fix some performance downgrade seems overkill when it can 
be mitigated by the kernel.