Received-SPF: pass (google.com: domain of linux-kernel+bounces-191575-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) client-ip=139.178.88.99;
From: Ankur Arora <ankur.a.arora@oracle.com>
To: linux-kernel@vger.kernel.org
Cc: tglx@linutronix.de, peterz@infradead.org, torvalds@linux-foundation.org,
        paulmck@kernel.org, rostedt@goodmis.org, mark.rutland@arm.com,
        juri.lelli@redhat.com, joel@joelfernandes.org, raghavendra.kt@amd.com,
        sshegde@linux.ibm.com, boris.ostrovsky@oracle.com,
        konrad.wilk@oracle.com, Ankur Arora <ankur.a.arora@oracle.com>,
        Ingo Molnar <mingo@redhat.com>,
        Vincent Guittot <vincent.guittot@linaro.org>
Subject: [PATCH v2 30/35] sched: latency warn for TIF_NEED_RESCHED_LAZY
Date: Mon, 27 May 2024 17:35:16 -0700
Message-Id: <20240528003521.979836-31-ankur.a.arora@oracle.com>
In-Reply-To: <20240528003521.979836-1-ankur.a.arora@oracle.com>
References: <20240528003521.979836-1-ankur.a.arora@oracle.com>
Content-Transfer-Encoding: 8bit
Content-Type: text/plain
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: 
	=?us-ascii?Q?UWnnnbAIN1c4C9wQICynJ6k6tlj2vl6K9/HQkMpkmO8N3NSSmFLV8CW7Brsb?=
 =?us-ascii?Q?fJB/6es0TyW/UUyJ6r/a5C+U559Mpp4pp8GogFwdDQKIScacjP6qQndADeZn?=
 =?us-ascii?Q?aGEc6Arcj2nhrmNMgDbyB9lE2Ac8sYPX6fvRPQckNS5cjp32ci+itgLMa29i?=
 =?us-ascii?Q?GbSfw+/nR0wQxB8MH6sBUoxwPtqpu49INrDY/AzU7+P4Foc359d8QQpuVWe1?=
 =?us-ascii?Q?xLCbSpqwpM1KmONVq/uNUWOSSSH9aTYHJWOtRAWBJmwbgzbzQckixhWhQp7h?=
 =?us-ascii?Q?MbhAIw9gF5/L9w8/N+tYY5b/lFHZNKuKF1pGR3OmnM529E6dE8tcw9hNiK50?=
 =?us-ascii?Q?bc6yX4SYy7F41ppUJQq0Pebp1NPFwXARlVd/JxhhScoVew3/H5SZz3FzFbsV?=
 =?us-ascii?Q?cdJaJbN2vvrQAEmgw5eT+I5mMroc56qLLA7xq9R9d6jeZCAL1nolbaoFlfwq?=
 =?us-ascii?Q?jGVmytaiq5XuEEHQPhFWchetOqazV9XNy6dIlGeQoj0mGHcpzsmrod0YxXur?=
 =?us-ascii?Q?LAvVxD9E8qlJIAxRVsfLdXpV6beBH6WmBElukhs/Xm8MxPyoQsMNruYMNk5m?=
 =?us-ascii?Q?DwXib49GKeLHZ/t1I6ji5+9kkXCpYMKCndFhXn3bDLNkrW7u3uPP6KTD1jMN?=
 =?us-ascii?Q?MGD2LslsBYCG0z2ZRvzBTXg7bozYwXTlu7yvNHhGB6JLv1GTiDlgbUAAD3DL?=
 =?us-ascii?Q?f1UgJ4gLFefdQIinUGa5ws7a7+x//Ehld/uEfu6eiqM0/jw9wpPa23/uVLmx?=
 =?us-ascii?Q?yUpW0yq0xIQOJFONYuTuEC+0O9YqQTaAAGx0ERwhWR2lqJg9cPT0Mx9Vi1T7?=
 =?us-ascii?Q?51N1o/R/mfN99MePJzmBGx12glJV9fWo4qFodyPZ6Gdizzsx8JAzCLQVFdQm?=
 =?us-ascii?Q?JFrWKHgZpKdlPAJ0EAVAeLHAIKhSMrSp6982m21p23upv8smeA4stAC3MejL?=
 =?us-ascii?Q?3W+IoW4T2NQ9gO+twdaADkU7fpy6ovnMAPZ4JSgFWSRQfRThTEXQqo+v2lHT?=
 =?us-ascii?Q?ZKEU2t9v9b3j69/4a/LRq7TXE/wveaxm69xq1NNvvQcpBAN2Au+C9SlATqg5?=
 =?us-ascii?Q?vrUcTz5PDwMUUbgmiLHbyoSHprQqnlAfRGEoPWOClJB1duSR03SbdsXSmAKc?=
 =?us-ascii?Q?0TVYlmRmJbnG9pmCSZei8FTBKxZ7SxmX246uXsHSFBV9AVsOFBrq92yUsCFq?=
 =?us-ascii?Q?g2Wjeyq6MKOQOExrsYQ1UFrLsmY7hnOmqGH+h0hyg5hngA238nGE/hWAYbqR?=
 =?us-ascii?Q?ejjJOZTWkx89NejNPhXx1Q7lYVjfhGCMUQ6ROOrZNT2HgpM5FFfwgQQimS66?=
 =?us-ascii?Q?NMjtK8msYa9k0IQlGDQ7xJjrPUE1lQN0cHahOPIi7+9rg4fPHHwvyc3tzWov?=
 =?us-ascii?Q?jy1TD+yRVRuhSZGThGWyEFuAVsfxoXYqa2mbUwVwMPRAF6ilI6lP6ihTDA8o?=
 =?us-ascii?Q?e2QsGIFRPbfBS0mm9MfnGlqlg00o1HpsNqDRpo+/EAgsT5cjXJ1VbpE6s8IV?=
 =?us-ascii?Q?EozHt/1uIJzbVakmdNX9/u6yM+qSDSvlXPTI4283gvMKglbNUFSuIx39/581?=
 =?us-ascii?Q?Ffw1rWAK31g1IKP/2iwIaPKNIvOdSCQzYNW2a/zxIfHuFHCbKqrK28IkipF6?=
 =?us-ascii?Q?cQ=3D=3D?=
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: 
	L33ocEgSmE+XIBfq27JAUoRxyxoxC37xdV0VjxkxqztnRTvZ82OgqI6QiGlhbPB6PSEQg8IyfgSwlajuTY85gGjeBII8m4QHlT+fHoBJdwPcRbPgpERy8Fn86ysnaN/WJ1nDoFLDoxwiFzdWWLoOiJUeHxrnbu8CH+JBP0NFx+I1me/TRNeo55lirwUPmOBDLgyFGYNSL5QIHeRwvY63TB7SkdrsGf3qCX1Qd81HtyqKWz9OO1Oew6Apigiv8FajYBYSRCMDWqwiXJoZtrdMmnR2fMPpzg037a2A74E01BcxixYdSM2c7KR6r/Ez32V7r6sqQFzeClZ5gDNm8yBEFm78uFZ7nky7JiH8z9RyIfQq46QC2Dgs4rIjeMvFeK++pY+FyqljFuJWGUaoSOhPaEI758UVjSzBoD7pR7Ady3saekkoS7EmOS0naZCauUM7oiCAHrhifvK0DZ50up2p7XO7gGdK68v4bb5LXJWBEInr2WPXBTcbj49BkDju6c42Z7NIHBdCcicZjqKXlAsqvjAjCFdAVebzLR4MSYWWurqq746A1Nazu0VTtk1bXNcsSOK8LAiacrg8Lk1iuBlvr0qv8oqkCoDCs70MrdyeKBY=
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-Network-Message-Id: b6f0f6c5-4d22-4c35-9b63-08dc7eae4703
X-MS-Exchange-CrossTenant-AuthSource: CO6PR10MB5409.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 28 May 2024 00:36:56.1956
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: Qn+jn/R7dt+AMla+e1tsZegFihs1MwNA20bKlcIeg7ekRjulUUVvH9gU8WR81qSpQu4tAqOt9zn0VrSfvuC8r25g53+r/cxvhpjOxpldFTk=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DS7PR10MB7177
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.293,Aquarius:18.0.1039,Hydra:6.0.650,FMLib:17.12.28.16
 definitions=2024-05-27_06,2024-05-27_01,2024-05-17_01
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 mlxlogscore=999 mlxscore=0 adultscore=0
 suspectscore=0 malwarescore=0 phishscore=0 bulkscore=0 spamscore=0
 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2405010000
 definitions=main-2405280003
X-Proofpoint-GUID: t9mVAK44QA6DJhOergGtRERsRVzn5-Xf
X-Proofpoint-ORIG-GUID: t9mVAK44QA6DJhOergGtRERsRVzn5-Xf

resched_latency_warn() now also warns if TIF_NEED_RESCHED_LAZY is set
without rescheduling for more than the latency_warn_ms period.

Cc: Ingo Molnar <mingo@redhat.com>
Cc: Peter Ziljstra <peterz@infradead.org>
Cc: Juri Lelli <juri.lelli@redhat.com>
Cc: Vincent Guittot <vincent.guittot@linaro.org>
Signed-off-by: Ankur Arora <ankur.a.arora@oracle.com>
---
 kernel/sched/core.c  | 2 +-
 kernel/sched/debug.c | 7 +++++--
 2 files changed, 6 insertions(+), 3 deletions(-)

diff --git a/kernel/sched/core.c b/kernel/sched/core.c
index 2bc3ae21a9d0..4f0ac90b7d47 100644
--- a/kernel/sched/core.c
+++ b/kernel/sched/core.c
@@ -5673,7 +5673,7 @@ static u64 cpu_resched_latency(struct rq *rq)
 	if (sysctl_resched_latency_warn_once && warned_once)
 		return 0;
 
-	if (!need_resched() || !latency_warn_ms)
+	if ((!need_resched() && !need_resched_lazy()) || !latency_warn_ms)
 		return 0;
 
 	if (system_state == SYSTEM_BOOTING)
diff --git a/kernel/sched/debug.c b/kernel/sched/debug.c
index e53f1b73bf4a..a1be40101844 100644
--- a/kernel/sched/debug.c
+++ b/kernel/sched/debug.c
@@ -1114,9 +1114,12 @@ void proc_sched_set_task(struct task_struct *p)
 void resched_latency_warn(int cpu, u64 latency)
 {
 	static DEFINE_RATELIMIT_STATE(latency_check_ratelimit, 60 * 60 * HZ, 1);
+	char *nr;
+
+	nr = __tif_need_resched(RESCHED_NOW) ? "need_resched" : "need_resched_lazy";
 
 	WARN(__ratelimit(&latency_check_ratelimit),
-	     "sched: CPU %d need_resched set for > %llu ns (%d ticks) "
+	     "sched: CPU %d %s set for > %llu ns (%d ticks) "
 	     "without schedule\n",
-	     cpu, latency, cpu_rq(cpu)->ticks_without_resched);
+	     cpu, nr, latency, cpu_rq(cpu)->ticks_without_resched);
 }
-- 
2.31.1