Received-SPF: pass (google.com: domain of linux-kernel+bounces-191654-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) client-ip=139.178.88.99;
From: "Ng, Boon Khai" <boon.khai.ng@intel.com>
To: Andrew Lunn <andrew@lunn.ch>
CC: Alexandre Torgue <alexandre.torgue@foss.st.com>, Jose Abreu
	<joabreu@synopsys.com>, "David S . Miller" <davem@davemloft.net>, "Eric
 Dumazet" <edumazet@google.com>, Jakub Kicinski <kuba@kernel.org>, Paolo Abeni
	<pabeni@redhat.com>, Maxime Coquelin <mcoquelin.stm32@gmail.com>,
	"netdev@vger.kernel.org" <netdev@vger.kernel.org>,
	"linux-stm32@st-md-mailman.stormreply.com"
	<linux-stm32@st-md-mailman.stormreply.com>,
	"linux-arm-kernel@lists.infradead.org"
	<linux-arm-kernel@lists.infradead.org>, "linux-kernel@vger.kernel.org"
	<linux-kernel@vger.kernel.org>, "Ang, Tien Sung" <tien.sung.ang@intel.com>,
	"G Thomas, Rohan" <rohan.g.thomas@intel.com>, "Looi, Hong Aun"
	<hong.aun.looi@intel.com>, Andy Shevchenko
	<andriy.shevchenko@linux.intel.com>, Ilpo Jarvinen
	<ilpo.jarvinen@linux.intel.com>
Subject: RE: [Enable Designware XGMAC VLAN Stripping Feature v2 1/1] net:
 stmmac: dwxgmac2: Add support for HW-accelerated VLAN Stripping
Thread-Topic: [Enable Designware XGMAC VLAN Stripping Feature v2 1/1] net:
 stmmac: dwxgmac2: Add support for HW-accelerated VLAN Stripping
Thread-Index: AQHasBkLCj07Z540QUGXqLg1tlacPLGrb/8AgAB3OtA=
Date: Tue, 28 May 2024 02:29:43 +0000
Message-ID: <DM8PR11MB5751469FAA2B01EB6CEB7B50C1F12@DM8PR11MB5751.namprd11.prod.outlook.com>
References: <20240527093339.30883-1-boon.khai.ng@intel.com>
 <20240527093339.30883-2-boon.khai.ng@intel.com>
 <48176576-e1d2-4c45-967a-91cabb982a21@lunn.ch>
In-Reply-To: <48176576-e1d2-4c45-967a-91cabb982a21@lunn.ch>
Accept-Language: en-US
Content-Language: en-US
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?gf4jCZj85XvSDZjGwQz4uLPv4INdNYyf0Y5F2kjpR2XkaWacn6dWJCr7jD/v?=
 =?us-ascii?Q?uo+bnR2M96aIebM7SnDp2aqIDPHSjWOQTp8FIJ5/iRFet5Ux6Pwly3MlpSls?=
 =?us-ascii?Q?8Vbxt1WGPbsv1o+HQv77DrX5EaGBqqBNX6NpeDLLAfeoaM8lnzef/vsUMDff?=
 =?us-ascii?Q?+HWIQSDb0lAlIXfEyT1cqxG2sCSTilAkTdB9z/RD/ybLsftUSe9roETktDD1?=
 =?us-ascii?Q?4trfgEPK91fKB29OUQBOUuJfs40M14+9ZCAVq3LZtQUN7z+/M9hzo+dWH5yz?=
 =?us-ascii?Q?pIyDiyUE6i1Oii8rwcZUKaHcVPBWadHpgrd4V7wsyx8rIsxVRcC00W43K9HE?=
 =?us-ascii?Q?mrMGn6kdTwAmBZ7+HstUWFYbB2jI40/pDe7QuIhQa6aFlUDJOyeXt+GgAuHO?=
 =?us-ascii?Q?auAGjQUzWeihL/0HyDyxV4HsW5yU3Q5bUouVGFMW8MDEBzontMorcWdsaxxd?=
 =?us-ascii?Q?b1JXlpsYK9DK2n+m+6Llxl4+oWQAU5SMtIOPq8OIr7dZ91f8DRK7Upocm9RL?=
 =?us-ascii?Q?VyoZTqH2cP/JJ8eDcOrYZYqfv0+FmuDEGM6XApawUng+2aHkxl6FWmsrKBdu?=
 =?us-ascii?Q?6AfuNW/z2K/MblVEs1R8GOMw/6tE9g19slw7+je6ryr4AoS/6O4zPq4TzLQ0?=
 =?us-ascii?Q?6gMsG9YLyZckqKBTtrAFkzClmlkQ8ClViJA+5JGm5Un7dU/KOuTzF6oCRpy9?=
 =?us-ascii?Q?edthuCWBjto/qQnWa/xF/lpSf891kU8uhw4U6NcaBSQne4eHaClxYWAtvWFD?=
 =?us-ascii?Q?SSpcqfVbOuBuWSCfZ205DjL/l1vZV0goizBPWzq2CGRdTXPzV11IQNbmF+2m?=
 =?us-ascii?Q?p7EpnZg4YEMF0nEGCpVjko/3NT0f5Z/olyNeyUR/tNzNgL7rav3iE8exnoqK?=
 =?us-ascii?Q?I7+5z2QhGeIGm4WRizqniZIy8PaDSNBNQeWZah+1Lu8Tbkfbv5PhV29Qv92K?=
 =?us-ascii?Q?paLHTvCFN28xtc/3BAg/nnxSA9D9GXII2GB5gsV0ajj2T92HxUDanVeGosHE?=
 =?us-ascii?Q?wvyfoGM4nbKmx3QrPv+A2T1u9GRy5oViK6piVjqstZ6lRGwXQgM49FVLzs/o?=
 =?us-ascii?Q?vNv3ffNLmO5W3SB3Xh4NU03HvnqE8SVZxxoXsIg9AANHrZCIRaUwf/BfV2RX?=
 =?us-ascii?Q?0VHaJBXqkZ+kCGGi1grHxj/nk75pXovDS90XA5hfoDZYwproeP9k6j2cgBMr?=
 =?us-ascii?Q?meidlsZKxgvM9oayI655+4onBUUfN+wXdx9j0rJMtrV4Hti8Z6O4TiUW1TZe?=
 =?us-ascii?Q?AKaErXBnAN1RL2rpg+Zcqu98Ja81cKfb4LK0eZzbo8Dr71UG0qpWBgksZtx7?=
 =?us-ascii?Q?J6hiUKuF/JiQ9Us4dKeibGx2drvSTQsSNNnVqDi7tW7hFZyFjhQZi6r3rImE?=
 =?us-ascii?Q?7jGuwHbAoZzCjAKAAlGb8paHls3rleZKG0eFVjo7U64ZRQMgMVIPEm2Y6OVG?=
 =?us-ascii?Q?4xewaeC2TCWHGLYajJTmEsCdgGS4PYlMgN8z1Mk+M5DTGSFYE8wZRragPSCT?=
 =?us-ascii?Q?VcWNgHILGyM4tgmMlwpL/VjtO9OfXWeGpbvx/mr8FJjuDETMtCuzd2lA0yrw?=
 =?us-ascii?Q?5ij88YYd5O56MCLVPJyp/D4f0nkISAg2i07WpBLW?=
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk
X-Mailing-List: linux-kernel@vger.kernel.org
List-Id: <linux-kernel.vger.kernel.org>
List-Subscribe: <mailto:linux-kernel+subscribe@vger.kernel.org>
List-Unsubscribe: <mailto:linux-kernel+unsubscribe@vger.kernel.org>
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: DM8PR11MB5751.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 2f7b063b-6c40-4daf-e5a2-08dc7ebe0883
X-MS-Exchange-CrossTenant-originalarrivaltime: 28 May 2024 02:29:43.1333
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: 3Y9htBblrlIqwWG1L+dpoGwQHk1UaGrgqCyDuFrjL7NRk1t5RK4dzrlBB5cNQy+O5sLeLzGhzii3A134vPTqvA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM4PR11MB5230
X-OriginatorOrg: intel.com

> -----Original Message-----
> From: Andrew Lunn <andrew@lunn.ch>
> Sent: Tuesday, May 28, 2024 3:00 AM
> To: Ng, Boon Khai <boon.khai.ng@intel.com>
> Cc: Alexandre Torgue <alexandre.torgue@foss.st.com>; Jose Abreu
> <joabreu@synopsys.com>; David S . Miller <davem@davemloft.net>; Eric
> Dumazet <edumazet@google.com>; Jakub Kicinski <kuba@kernel.org>; Paolo
> Abeni <pabeni@redhat.com>; Maxime Coquelin
> <mcoquelin.stm32@gmail.com>; netdev@vger.kernel.org; linux-stm32@st-
> md-mailman.stormreply.com; linux-arm-kernel@lists.infradead.org; linux-
> kernel@vger.kernel.org; Ang, Tien Sung <tien.sung.ang@intel.com>; G
> Thomas, Rohan <rohan.g.thomas@intel.com>; Looi, Hong Aun
> <hong.aun.looi@intel.com>; Andy Shevchenko
> <andriy.shevchenko@linux.intel.com>; Ilpo Jarvinen
> <ilpo.jarvinen@linux.intel.com>
> Subject: Re: [Enable Designware XGMAC VLAN Stripping Feature v2 1/1] net:
> stmmac: dwxgmac2: Add support for HW-accelerated VLAN Stripping
>=20
> > This implementation was ported from the dwmac4 driver.
>=20
> How does it differ from dwmac4? Can the dwmac4 implementation just be
> used, rather than duplicating all the code/bugs.

Hi Andrew, 5 years ago the driver was initially implemented separately, may=
be need David S. Miller help to clarify this.
https://github.com/torvalds/linux/blob/master/drivers/net/ethernet/stmicro/=
stmmac/dwxgmac2_core.c
https://github.com/torvalds/linux/blob/master/drivers/net/ethernet/stmicro/=
stmmac/dwmac4_core.c

If you take a look at the code, the register mapping looks different at the=
ir TX MAC Configuration register and RX MAC Configuration register.
https://github.com/torvalds/linux/blob/master/drivers/net/ethernet/stmicro/=
stmmac/dwxgmac2.h
https://github.com/torvalds/linux/blob/master/drivers/net/ethernet/stmicro/=
stmmac/dwmac4.h

So, for this XGMAC VLAN patch, the idea of getting the VLAN id from the des=
criptor is the same, but=20
The register bit filed of getting the VLAN packet VALID is different. Thus,=
 it need to be implemented separately.=20

>=20
> 	Andrew