Received-SPF: pass (google.com: domain of linux-kernel+bounces-191682-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) client-ip=2604:1380:45d1:ec00::1;
Date: Tue, 28 May 2024 13:31:04 +1000
From: Stephen Rothwell <sfr@canb.auug.org.au>
To: Christian Brauner <brauner@kernel.org>
Cc: Christian =?UTF-8?B?R8O2dHRzY2hl?= <cgzones@googlemail.com>, Arnd
 Bergmann <arnd@arndb.de>, Linux Kernel Mailing List
 <linux-kernel@vger.kernel.org>, Linux Next Mailing List
 <linux-next@vger.kernel.org>
Subject: Re: linux-next: build warning after merge of the vfs-brauner tree
Message-ID: <20240528133104.304a1261@canb.auug.org.au>
In-Reply-To: <20240528104905.58195cbe@canb.auug.org.au>
References: <20240528104905.58195cbe@canb.auug.org.au>
Precedence: bulk
MIME-Version: 1.0
Content-Type: multipart/signed; boundary="Sig_/z9bmRDdU.XvdNV.f=5KL.w4";
 protocol="application/pgp-signature"; micalg=pgp-sha256

--Sig_/z9bmRDdU.XvdNV.f=5KL.w4
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: quoted-printable

Hi all,

On Tue, 28 May 2024 10:49:05 +1000 Stephen Rothwell <sfr@canb.auug.org.au> =
wrote:
>=20
> After merging the vfs-brauner tree, today's linux-next build (arm
> multi_v7_defconfig) produced this warning:
>=20
> fs/xattr.c: In function '__do_sys_setxattrat':
> fs/xattr.c:709:61: warning: cast to pointer from integer of different siz=
e [-Wint-to-pointer-cast]
>   709 |         return do_setxattrat(dfd, pathname, at_flags, name, (cons=
t void __user *)args.value,
>       |                                                             ^
> fs/xattr.c: In function '__do_sys_getxattrat':
> fs/xattr.c:855:61: warning: cast to pointer from integer of different siz=
e [-Wint-to-pointer-cast]
>   855 |         return do_getxattrat(dfd, pathname, at_flags, name, (void=
 __user *)args.value, args.size);
>       |                                                             ^
>=20
> Introduced by commit
>=20
>   89345b0ac5ac ("fs/xattr: add *at family syscalls")

This became a build failure in the i386 defconfig build, so I applied
the following fix patch.

From: Stephen Rothwell <sfr@canb.auug.org.au>
Date: Tue, 28 May 2024 13:20:29 +1000
Subject: [PATCH] fix up for "fs/xattr: add *at family syscalls"

Signed-off-by: Stephen Rothwell <sfr@canb.auug.org.au>
---
 fs/xattr.c | 7 +++++--
 1 file changed, 5 insertions(+), 2 deletions(-)

diff --git a/fs/xattr.c b/fs/xattr.c
index 8e712795ab80..d0d54ae2f9cb 100644
--- a/fs/xattr.c
+++ b/fs/xattr.c
@@ -706,7 +706,8 @@ SYSCALL_DEFINE6(setxattrat, int, dfd, const char __user=
 *, pathname, unsigned in
 	if (error)
 		return error;
=20
-	return do_setxattrat(dfd, pathname, at_flags, name, (const void __user *)=
args.value,
+	return do_setxattrat(dfd, pathname, at_flags, name,
+			     (const void __user *)(unsigned long)args.value,
 			     args.size, args.flags);
 }
=20
@@ -852,7 +853,9 @@ SYSCALL_DEFINE6(getxattrat, int, dfd, const char __user=
 *, pathname, unsigned in
 	if (args.flags !=3D 0)
 		return -EINVAL;
=20
-	return do_getxattrat(dfd, pathname, at_flags, name, (void __user *)args.v=
alue, args.size);
+	return do_getxattrat(dfd, pathname, at_flags, name,
+			     (void __user *)(unsigned long)args.value,
+			     args.size);
 }
=20
 SYSCALL_DEFINE4(getxattr, const char __user *, pathname,
--=20
2.43.0

--=20
Cheers,
Stephen Rothwell

--Sig_/z9bmRDdU.XvdNV.f=5KL.w4
Content-Type: application/pgp-signature
Content-Description: OpenPGP digital signature

-----BEGIN PGP SIGNATURE-----

iQEzBAEBCAAdFiEENIC96giZ81tWdLgKAVBC80lX0GwFAmZVT/gACgkQAVBC80lX
0GzHQgf+LlYQsQdZOQQJU/c8l/j4ESdIUDOyPxiFRKaDKphZWlADuvAE+RZ45UtG
Q499df8nTWl13lfZqZYyZ+hCB0E4OE4Ym+ErJT/3glvLphkerMJiQGZqNJneeNxN
6LEp1BGf1dBwIwEW4Ooy5AR9vgz6+aPd+S5Vj/2w8M+wRoaPmZbTv3+G2y268wng
ZUs/vLdjXBhZAL6RWjBIMItaexw5MgHAUVAtIQNBM8h1ALyFb9Sv3Zb5uznlTpvG
gcQy5rvuLy7GAQyBt9mfPUMns61q6xWIjVQZtaG2l+CxtXI7AJKxS2VAMgbdxHYI
I+lSIshVg0LX0cd9/QG/3PeaZyDxOA==
=+BTr
-----END PGP SIGNATURE-----

--Sig_/z9bmRDdU.XvdNV.f=5KL.w4--