Received-SPF: pass (google.com: domain of linux-kernel+bounces-191764-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.48.161 as permitted sender) client-ip=147.75.48.161;
Message-ID: <fb29682b-c9fc-4c96-bb0c-3b842447595e@ti.com>
Date: Tue, 28 May 2024 10:50:14 +0530
Precedence: bulk
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH net-next v7 2/2] net: ti: icssg_prueth: add TAPRIO offload
 support
Content-Language: en-US
To: Andrew Lunn <andrew@lunn.ch>
CC: Jan Kiszka <jan.kiszka@siemens.com>,
        Dan Carpenter
	<dan.carpenter@linaro.org>,
        Simon Horman <horms@kernel.org>, Diogo Ivo
	<diogo.ivo@siemens.com>,
        Wolfram Sang <wsa+renesas@sang-engineering.com>,
        Randy Dunlap <rdunlap@infradead.org>,
        Niklas Schnelle
	<schnelle@linux.ibm.com>,
        Vladimir Oltean <vladimir.oltean@nxp.com>,
        Vignesh
 Raghavendra <vigneshr@ti.com>,
        Richard Cochran <richardcochran@gmail.com>,
        Roger Quadros <rogerq@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
        Jakub
 Kicinski <kuba@kernel.org>, Eric Dumazet <edumazet@google.com>,
        "David S.
 Miller" <davem@davemloft.net>,
        <linux-arm-kernel@lists.infradead.org>, <netdev@vger.kernel.org>,
        <linux-kernel@vger.kernel.org>, <srk@ti.com>,
        Roger
 Quadros <rogerq@ti.com>,
        Vinicius Costa Gomes <vinicius.gomes@intel.com>
References: <20240527055300.154563-1-danishanwar@ti.com>
 <20240527055300.154563-3-danishanwar@ti.com>
 <1d0f9d73-89e7-413a-b1df-5ff56bc1cac4@lunn.ch>
From: MD Danish Anwar <danishanwar@ti.com>
In-Reply-To: <1d0f9d73-89e7-413a-b1df-5ff56bc1cac4@lunn.ch>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit


On 28/05/24 3:48 am, Andrew Lunn wrote:
> On Mon, May 27, 2024 at 11:23:00AM +0530, MD Danish Anwar wrote:
>> From: Roger Quadros <rogerq@ti.com>
>>
>> ICSSG dual-emac f/w supports Enhanced Scheduled Traffic (EST – defined
>> in P802.1Qbv/D2.2 that later got included in IEEE 802.1Q-2018)
>> configuration.
> 
> You only mention dual-emac here. What about when it is in switch mode
> and is using the other firmware?
> 

Both dual-emac and switch firmware supports taprio. The implementation
is same for both firmwares and there is no difference. The patch was
developed before switch support and that's why the commit message only
says dual-emac. I will update the commit message. Is there anything else
that needs to be changed in this seires? If there is, please let me
know. I will try to post it soon.

>     Andrew

-- 
Thanks and Regards,
Danish