Received-SPF: pass (google.com: domain of linux-kernel+bounces-191770-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) client-ip=139.178.88.99;
Message-ID: <9b16c10c-a08a-4b37-8ffc-6ae19b1c70d2@ti.com>
Date: Tue, 28 May 2024 10:57:33 +0530
Precedence: bulk
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH net-next v5 1/3] net: ti: icssg-prueth: Add helper
 functions to configure FDB
Content-Language: en-US
To: Andrew Lunn <andrew@lunn.ch>
CC: Dan Carpenter <dan.carpenter@linaro.org>,
        Jan Kiszka
	<jan.kiszka@siemens.com>, Simon Horman <horms@kernel.org>,
        Vladimir Oltean
	<vladimir.oltean@nxp.com>,
        Wolfram Sang <wsa+renesas@sang-engineering.com>,
        Niklas Schnelle <schnelle@linux.ibm.com>,
        Arnd Bergmann <arnd@arndb.de>, Diogo Ivo <diogo.ivo@siemens.com>,
        Roger Quadros <rogerq@kernel.org>, Paolo
 Abeni <pabeni@redhat.com>,
        Jakub Kicinski <kuba@kernel.org>, Eric Dumazet
	<edumazet@google.com>,
        "David S. Miller" <davem@davemloft.net>,
        <linux-arm-kernel@lists.infradead.org>, <netdev@vger.kernel.org>,
        <linux-kernel@vger.kernel.org>, <srk@ti.com>,
        Vignesh Raghavendra
	<vigneshr@ti.com>
References: <20240527052738.152821-1-danishanwar@ti.com>
 <20240527052738.152821-2-danishanwar@ti.com>
 <3cf97632-4d77-4f28-bed6-7d40d61d958f@lunn.ch>
From: MD Danish Anwar <danishanwar@ti.com>
In-Reply-To: <3cf97632-4d77-4f28-bed6-7d40d61d958f@lunn.ch>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 7bit


On 28/05/24 3:34 am, Andrew Lunn wrote:
>> +struct mgmt_cmd {
>> +	u8 param;
>> +	u8 seqnum;
>> +	u8 type;
>> +	u8 header;
>> +	u32 cmd_args[3];
>> +} __packed;
> 
> There is a general dislike for __packed. Since your structures are
> naturally well aligned, it is probably not needed. You could be
> paranoid and add BUILD_BUG_ON(sizeof(struct mgmt_cmd) != 16);
> 

Sure, I will drop __packed as it's not needed and send next revision.

> 	 Andrew

-- 
Thanks and Regards,
Danish