Received-SPF: pass (google.com: domain of linux-kernel+bounces-191772-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) client-ip=147.75.80.249;
Message-ID: <a8af43e2-09e9-46ac-86f0-baa48d810fa4@ti.com>
Date: Tue, 28 May 2024 10:58:35 +0530
Precedence: bulk
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH net-next v5 3/3] net: ti: icssg-prueth: Add support for
 ICSSG switch firmware
Content-Language: en-US
To: Andrew Lunn <andrew@lunn.ch>
CC: Dan Carpenter <dan.carpenter@linaro.org>,
        Jan Kiszka
	<jan.kiszka@siemens.com>, Simon Horman <horms@kernel.org>,
        Vladimir Oltean
	<vladimir.oltean@nxp.com>,
        Wolfram Sang <wsa+renesas@sang-engineering.com>,
        Niklas Schnelle <schnelle@linux.ibm.com>,
        Arnd Bergmann <arnd@arndb.de>, Diogo Ivo <diogo.ivo@siemens.com>,
        Roger Quadros <rogerq@kernel.org>, Paolo
 Abeni <pabeni@redhat.com>,
        Jakub Kicinski <kuba@kernel.org>, Eric Dumazet
	<edumazet@google.com>,
        "David S. Miller" <davem@davemloft.net>,
        <linux-arm-kernel@lists.infradead.org>, <netdev@vger.kernel.org>,
        <linux-kernel@vger.kernel.org>, <srk@ti.com>,
        Vignesh Raghavendra
	<vigneshr@ti.com>
References: <20240527052738.152821-1-danishanwar@ti.com>
 <20240527052738.152821-4-danishanwar@ti.com>
 <4f5a6d1b-e209-45b1-acec-ce84ca1c856f@lunn.ch>
From: MD Danish Anwar <danishanwar@ti.com>
In-Reply-To: <4f5a6d1b-e209-45b1-acec-ce84ca1c856f@lunn.ch>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 7bit


On 28/05/24 3:44 am, Andrew Lunn wrote:
> On Mon, May 27, 2024 at 10:57:38AM +0530, MD Danish Anwar wrote:
>> Add support for ICSSG switch firmware using existing Dual EMAC driver
>> with switchdev.
>>
>> Limitations:
>> VLAN offloading is limited to 0-256 IDs.
>> MDB/FDB static entries are limited to 511 entries and different FDBs can
>> hash to same bucket and thus may not completely offloaded
>>
>> Example assuming ETH1 and ETH2 as ICSSG2 interfaces:
>>
>> Switch to ICSSG Switch mode:
>>  ip link add name br0 type bridge
>>  ip link set dev eth1 master br0
>>  ip link set dev eth2 master br0
>>  ip link set dev br0 up
>>  bridge vlan add dev br0 vid 1 pvid untagged self
>>
>> Going back to Dual EMAC mode:
>>
>>  ip link set dev br0 down
>>  ip link set dev eth1 nomaster
>>  ip link set dev eth2 nomaster
>>  ip link del name br0 type bridge
>>
>> By default, Dual EMAC firmware is loaded, and can be changed to switch
>> mode by above steps
>>
>> Signed-off-by: MD Danish Anwar <danishanwar@ti.com>
>>  static int prueth_emac_buffer_setup(struct prueth_emac *emac)
>>  {
>>  	struct icssg_buffer_pool_cfg __iomem *bpool_cfg;
>> @@ -321,25 +401,63 @@ static void icssg_init_emac_mode(struct prueth *prueth)
>>  	/* When the device is configured as a bridge and it is being brought
>>  	 * back to the emac mode, the host mac address has to be set as 0.
>>  	 */
>> +	u32 addr = prueth->shram.pa + EMAC_ICSSG_SWITCH_DEFAULT_VLAN_TABLE_OFFSET;
>> +	int i;
>>  	u8 mac[ETH_ALEN] = { 0 };
> 
> nitpick: Reverse Christmas tree
> 
> Reviewed-by: Andrew Lunn <andrew@lunn.ch>

Thanks for the review. I will change this to "Reverse Christmas tree"
and send next revision.

> 
>     Andrew

-- 
Thanks and Regards,
Danish