Received-SPF: pass (google.com: domain of linux-kernel+bounces-191773-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) client-ip=147.75.80.249;
Date: Tue, 28 May 2024 10:59:52 +0530
From: "Gautham R. Shenoy" <gautham.shenoy@amd.com>
To: Perry Yuan <perry.yuan@amd.com>
Cc: Mario.Limonciello@amd.com, Ray.Huang@amd.com, Borislav.Petkov@amd.com,
	rafael.j.wysocki@intel.com, Alexander.Deucher@amd.com,
	Xinmei.Huang@amd.com, Xiaojian.Du@amd.com, Li.Meng@amd.com,
	linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 01/10] cpufreq: amd-pstate: optimize the initial
 frequency values verification
Message-ID: <ZlVr0Ff49DRSTn2R@BLR-5CG11610CF.amd.com>
References: <cover.1715356532.git.perry.yuan@amd.com>
 <c7bce101b2d7d107ba3c89779fe6800060e8edc4.1715356532.git.perry.yuan@amd.com>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <c7bce101b2d7d107ba3c89779fe6800060e8edc4.1715356532.git.perry.yuan@amd.com>
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?us-ascii?Q?B7EB6kJ1gO63zEhlmFjflsSL7lf7e1/V4Zk36e/jT0HJAFO4cValQrrti0dR?=
 =?us-ascii?Q?PGko6UdiR1Th1tvC8BhqYAY5TXrGwEOEHNQEFgLa1I5DiErjDbWr+yNLiW/u?=
 =?us-ascii?Q?Oq0h+XXLsy2hDEhpbgz9Ad78SOdeqFKae/zZLVyB7y466jinhC2OjWn1jFDX?=
 =?us-ascii?Q?SftuA4emVfHM5JNRBizt4pcNZ+42HVGq/4KNUI0RBxB//EP4IcVnRrgQnGyB?=
 =?us-ascii?Q?VfEX17OpUwW3f4pjELF6gubwj+c6oD7xblDnT/PKvYx+J0Ai/ZEdxLQ/rP90?=
 =?us-ascii?Q?ogvb9wDEVdNkbjtwedsbLVyjE9jlCRueTO3INOEe7v22yFCUNwNvuQ43Pl56?=
 =?us-ascii?Q?jF8vC5gH5e0w23D0INdNNbMF2xsYkrL40NOjpm5IYahkyq2OK9wROCIB5jfj?=
 =?us-ascii?Q?URLeiCYwjYXlNIO/Z10WS187o4+La7CYXVdzpUH5icbkh4oQEt5XqBmKd0DD?=
 =?us-ascii?Q?xqnI69I1alFg6bcDcaVDjdRR+7BYZTqHH2rvATmBSHTTI5RATimEARe0mAS1?=
 =?us-ascii?Q?W0sE4ooezMCmP9X7sFQqKnTr6jQ+s0OfOg71VFBdiogrmGBU5CAYsi8r8pVe?=
 =?us-ascii?Q?xwqCUumfBtxGzR9b+aIIKyzueknxsHMzHQE+JAOWc8oKfQAuNqjs14vBu7Of?=
 =?us-ascii?Q?xRIQvkyK8h53xoT1DgOSrzwpHAl+dH6QeimLJZfC1N0kbJAmh8m7valrA0iH?=
 =?us-ascii?Q?ml9rqNJ+5qQDTwL9Z7UlF56H6D0g1nnT8lY8KtdYXcz5uEJhyg7YnL6YOc7f?=
 =?us-ascii?Q?5MAJDHQyJjHFJQheAdQJICp2mkVSilexD9fTzNRpXgfgd6Jz4sE1mmIGVBz8?=
 =?us-ascii?Q?PinNRjEIBhEve2Zv74fwP/ZyFR0mie+WxoEkrE7o8mVpx45UTo37PiV/8who?=
 =?us-ascii?Q?0T/pI+kE/32qssK+1SwQD2kCn4c0TdOK8ww4GTZcSPnzx6BgkEkGTEKSJauM?=
 =?us-ascii?Q?1Ubb6RB+xexvTNvpQK1BuvS7t+ukGXhG2cKVC3U39S9A6U0v+6R87QRgcC9q?=
 =?us-ascii?Q?98O85tg0XU9inc5yuyC6T/hZnLh4CAhrLA1gknp9McMykIxeuiHHWdA2Ooe/?=
 =?us-ascii?Q?cJ1X/VpsxpW8YpuQUxczshjYWO/NPvSBesQyiKHXMEV8mzm/d8k7udqlM2W0?=
 =?us-ascii?Q?STcqi9JyYoOiMAQwALFGZSDZys7dP34++JQUHYtCd9ixF1h6CO8mqBofVYj1?=
 =?us-ascii?Q?jcuQ04brJMbS7cmVS63Muc5FkFjOxF3brU+k6yspYMDiJmNOACVLW4Oau4KK?=
 =?us-ascii?Q?6ydJYGMe0+Wc2DB2GgL6a/nA3wIBQ3Cra9dVQM/CwxtSP27u2zBEos+Xj+o7?=
 =?us-ascii?Q?1K9zQrdE/KqyH9Dg/DePkNtAIFoTAyLDWRGGvG/zfSWdA+pbjBteUi5GaPLE?=
 =?us-ascii?Q?MQmV+EDVCu9+SKTeYpkze99eNNErJo3IoQlXr1dmUzZY2H9iWxN9cjXYJZ9H?=
 =?us-ascii?Q?AVhXwhfE8fIkR9aaVMuR560xFIN4Me+lK+UfrRFmNgT/0Oit/Mv8EuLY8OAq?=
 =?us-ascii?Q?zYPTqQWU30IOC/px20CAZ7pJ1rNsFNY0O7j4XHnilL9OcSNGWN9QBDiqqfQh?=
 =?us-ascii?Q?LbZAWIPfDyuHRKL6KRJ3iwXjDlV+aKCQjOO7z8et?=
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 4e1468ce-0435-4969-28e6-08dc7ed735ec
X-MS-Exchange-CrossTenant-AuthSource: DS7PR12MB8252.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 28 May 2024 05:29:56.9290
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: jNBgIzAG8eLN16WRgx8KgIilIlgqlCl0deCpCq97/9L/LRwagiOGs4pWqQcB0AxJuZdAno3+XsW/pwbZwvc/RQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: LV3PR12MB9214

On Mon, May 13, 2024 at 10:07:19AM +0800, Perry Yuan wrote:
> To enhance the debugging capability of the driver loading failure for
> broken CPPC ACPI tables, it can optimize the expression by moving the
> verification of `min_freq`, `nominal_freq`, and other dependency values
> to the `amd_pstate_init_freq()` function where they are initialized.
> If any of these values are incorrect, the `amd-pstate` driver will not be registered.
> 
> By ensuring that these values are correct before they are used, it will facilitate
> the debugging process when encountering driver loading failures due to faulty CPPC
> ACPI tables from BIOS
> 
> Signed-off-by: Perry Yuan <perry.yuan@amd.com>

Looks good to me.

Acked-by: Gautham R. Shenoy <gautham.shenoy@amd.com>

> ---
>  drivers/cpufreq/amd-pstate.c | 35 ++++++++++++++++++-----------------
>  1 file changed, 18 insertions(+), 17 deletions(-)
> 
> diff --git a/drivers/cpufreq/amd-pstate.c b/drivers/cpufreq/amd-pstate.c
> index 6a342b0c0140..614f6fac0764 100644
> --- a/drivers/cpufreq/amd-pstate.c
> +++ b/drivers/cpufreq/amd-pstate.c
> @@ -889,6 +889,24 @@ static int amd_pstate_init_freq(struct amd_cpudata *cpudata)
>  	WRITE_ONCE(cpudata->nominal_freq, nominal_freq);
>  	WRITE_ONCE(cpudata->max_freq, max_freq);
>  
> +	/**
> +	 * Below values need to be initialized correctly, otherwise driver will fail to load
> +	 * max_freq is calculated according to (nominal_freq * highest_perf)/nominal_perf
> +	 * lowest_nonlinear_freq is a value between [min_freq, nominal_freq]
> +	 * Check _CPC in ACPI table objects if any values are incorrect
> +	 */
> +	if (min_freq <= 0 || max_freq <= 0 || nominal_freq <= 0 || min_freq > max_freq) {
> +		pr_err("min_freq(%d) or max_freq(%d) or nominal_freq(%d) value is incorrect\n",
> +			min_freq, max_freq, nominal_freq);
> +		return -EINVAL;
> +	}
> +
> +	if (lowest_nonlinear_freq <= min_freq || lowest_nonlinear_freq > nominal_freq * 1000) {
> +		pr_err("lowest_nonlinear_freq(%d) value is out of range [min_freq(%d), nominal_freq(%d)]\n",
> +			lowest_nonlinear_freq, min_freq, nominal_freq * 1000);
> +		return -EINVAL;
> +	}
> +
>  	return 0;
>  }
>  
> @@ -927,15 +945,6 @@ static int amd_pstate_cpu_init(struct cpufreq_policy *policy)
>  	max_freq = READ_ONCE(cpudata->max_freq);
>  	nominal_freq = READ_ONCE(cpudata->nominal_freq);
>  
> -	if (min_freq <= 0 || max_freq <= 0 ||
> -	    nominal_freq <= 0 || min_freq > max_freq) {
> -		dev_err(dev,
> -			"min_freq(%d) or max_freq(%d) or nominal_freq (%d) value is incorrect, check _CPC in ACPI tables\n",
> -			min_freq, max_freq, nominal_freq);
> -		ret = -EINVAL;
> -		goto free_cpudata1;
> -	}
> -
>  	policy->cpuinfo.transition_latency = amd_pstate_get_transition_latency(policy->cpu);
>  	policy->transition_delay_us = amd_pstate_get_transition_delay_us(policy->cpu);
>  
> @@ -1388,14 +1397,6 @@ static int amd_pstate_epp_cpu_init(struct cpufreq_policy *policy)
>  	min_freq = READ_ONCE(cpudata->min_freq);
>  	max_freq = READ_ONCE(cpudata->max_freq);
>  	nominal_freq = READ_ONCE(cpudata->nominal_freq);
> -	if (min_freq <= 0 || max_freq <= 0 ||
> -	    nominal_freq <= 0 || min_freq > max_freq) {
> -		dev_err(dev,
> -			"min_freq(%d) or max_freq(%d) or nominal_freq(%d) value is incorrect, check _CPC in ACPI tables\n",
> -			min_freq, max_freq, nominal_freq);
> -		ret = -EINVAL;
> -		goto free_cpudata1;
> -	}
>  
>  	policy->cpuinfo.min_freq = min_freq;
>  	policy->cpuinfo.max_freq = max_freq;
> -- 
> 2.34.1
>