Received: by 2002:a89:d88:0:b0:1fa:5c73:8e2d with SMTP id eb8csp2439458lqb; Mon, 27 May 2024 22:37:44 -0700 (PDT) X-Forwarded-Encrypted: i=3; AJvYcCU8OcJpJfASs48yygJyL4EXebSR9sUEJlq5JOGg5sk/eEjjYvCYKlAjjHCmi03v6vXjdD1CBE+vjmMsgIdfwjSXIP0LwQrLr2EMBDQZMw== X-Google-Smtp-Source: AGHT+IGBCY1xeMWxD6hCup112KZ1Lufk5VW57fMEaqn9SfJ6SPMe4KfuTKbmQxbfvJJwXm3i9pvF X-Received: by 2002:a50:a40c:0:b0:573:55cc:2f50 with SMTP id 4fb4d7f45d1cf-578519f61d8mr8470100a12.37.1716874664237; Mon, 27 May 2024 22:37:44 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1716874664; cv=pass; d=google.com; s=arc-20160816; b=QGM4jFhcZvLy72iKba3l0ebJEHvzNKR1VAAnkW6hTh9YFHKftM4FiptBwbte9KXsLv Tf4bUSZGP1sjODj6d/VNcknDjin6WAd4km+I7RXmdG1X8cMF5prDpouc4nxgCq6GRLeX IUM62jnchtczy7+iB8GwCKHKa2YxC06MVnvO/i6dWYjxHS3GgRZTmQcS73P3LxdT2ADk 0zxw9SBlSlMBK9pA99AXTdqHd/XLVPOq6DBiPDIotPxZ7yaztAD17MMtxbOEpUiwT85+ 5ZpHejktr8PzgkotrKftqhaCAIg0x8H9DgZFvJXxQl4m9N4ew1aVCOHYHAk+IYZfkFfW Q14Q== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:list-unsubscribe:list-subscribe:list-id:precedence :references:message-id:subject:cc:to:from:date:dkim-signature; bh=bG3lI1Yism6KBp1cJyZ09FmgbFb4kQX+kYL7INDDwew=; fh=4j32xD6tM9RzhXtiYpUWuJ/5SRt0EjqsUPqX5wvBH7c=; b=D2tqUc9Dq3M0JGhyutFbU9VqRaSb5V/DqJhNQxO2/7uND8DlNGSog0z5o+8WvskzMn +EsYGCN/Duzj9A9kPfKb/Dxe47TgLs+YJbBi1joX40s347R6m11qCX6ncWY4+jGxUVUw jY+WlZ/l1Wa7ituLo3gXYrh6UiNh3cMhSJTSYB4QXDtTZAuLqg751mJ3khR7Rk8BlL3K x/A1q5S17j+IEddIT83Z5W4KESXXNcAkkd9hx+zBCPlJPBzQEjJ2Cc67xJ+d98kje8Hl kh6lFoSRKcMCx3lZvqphXf/sg+hQfLvSbj1QiVLAq0a8NeJhTMqaxNWZthTt6zZ2oDsL +QzA==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=sJTwfcpM; arc=pass (i=1 dkim=pass dkdomain=kernel.org); spf=pass (google.com: domain of linux-kernel+bounces-191779-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) smtp.mailfrom="linux-kernel+bounces-191779-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from am.mirrors.kernel.org (am.mirrors.kernel.org. [2604:1380:4601:e00::3]) by mx.google.com with ESMTPS id 4fb4d7f45d1cf-578523316f2si4635043a12.94.2024.05.27.22.37.44 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 27 May 2024 22:37:44 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel+bounces-191779-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) client-ip=2604:1380:4601:e00::3; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=sJTwfcpM; arc=pass (i=1 dkim=pass dkdomain=kernel.org); spf=pass (google.com: domain of linux-kernel+bounces-191779-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) smtp.mailfrom="linux-kernel+bounces-191779-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by am.mirrors.kernel.org (Postfix) with ESMTPS id E14CA1F24327 for ; Tue, 28 May 2024 05:37:43 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id C208D4D59F; Tue, 28 May 2024 05:37:37 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="sJTwfcpM" Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E1FA24CB2B; Tue, 28 May 2024 05:37:36 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1716874657; cv=none; b=RmHSv94+0+9Zu9t3cDsBl7LnPFHfKkr3N2F8zn65xbfwvt18xZpFeGNZv/ID+mrB3y5PBHdj1iFhaB+3PjuP4Yhph4L6BzePu9/nqQxtBDYj8aQ/kQLWgObAP2AhpQiF5eThC+21feSfUEVTTKAYTE+DGJ/m/l1J3dFlaEeplCk= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1716874657; c=relaxed/simple; bh=y+v/kHdfFry41PCJXe5N+KAUHrNkRTybrDCFiVJtkF0=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=oqnPeDn1g7MM3TgmmTuEGVA7Tn0kJDYNscDbVp2FkA/NFytdrChKnfCZ6RRMJ+utLdC7X2sSNl7dvGxHCGgzgsh5hnFjkzcXlcp7Gqy9tGVTXpHVw0MWVcUUoMLjxJmoi7Cz2JILwn1NIPSyCT+R0p8F8kzJSXEEaCyzRPIHaCs= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=sJTwfcpM; arc=none smtp.client-ip=10.30.226.201 Received: by smtp.kernel.org (Postfix) with ESMTPSA id AB887C3277B; Tue, 28 May 2024 05:37:34 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1716874656; bh=y+v/kHdfFry41PCJXe5N+KAUHrNkRTybrDCFiVJtkF0=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=sJTwfcpMSUu6VkZi+MzWKj+Mf5oFrKYeykkA+0GmqwRIZeO9dhd/pD4wWeKD347I2 mXNA6eTct049yBkTSMGrU+Sibj4zmRPClCE4ZPvoHbBjRnKXrbsDTX8bp7JMCNOMOP kuFxW/cu6ShRKsnHQb4To31/i7lysXTpvP/Tbq5I/isWvMk9Nzd3HSHO4Nx6tIxCN2 DFYqV39001QupNjdURNWrCiuz1B09zo5gctmFbei1Vx55byCorvQEJydzBjgv1maAP jjbt9eSaCbFg33UEEUcLXLqo/rfIHPrSMUbmJr+gCWcPb7+MaGrHxqPMpKun9tGyH9 hQkDdENocj5lw== Date: Tue, 28 May 2024 05:37:32 +0000 From: Tzung-Bi Shih To: Thomas =?iso-8859-1?Q?Wei=DFschuh?= Cc: Lee Jones , Benson Leung , Guenter Roeck , Pavel Machek , chrome-platform@lists.linux.dev, linux-kernel@vger.kernel.org, Dustin Howett , Mario Limonciello , linux-leds@vger.kernel.org, Rajas Paranjpe Subject: Re: [PATCH v3 3/4] platform/chrome: cros_kbd_led_backlight: allow binding through mfd device Message-ID: References: <20240526-cros_ec-kbd-led-framework-v3-0-ee577415a521@weissschuh.net> <20240526-cros_ec-kbd-led-framework-v3-3-ee577415a521@weissschuh.net> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20240526-cros_ec-kbd-led-framework-v3-3-ee577415a521@weissschuh.net> On Sun, May 26, 2024 at 08:17:17PM +0200, Thomas Wei?schuh wrote: > +#if IS_ENABLED(CONFIG_MFD_CROS_EC_DEV) [...] > +static const struct keyboard_led_drvdata keyboard_led_drvdata_ec_pwm_mfd = { > + .init = keyboard_led_init_ec_pwm_mfd, > + .brightness_set_blocking = keyboard_led_set_brightness_ec_pwm, > + .brightness_get = keyboard_led_get_brightness_ec_pwm, They are only available if IS_ENABLED(CONFIG_CROS_EC).