Received: by 2002:a89:d88:0:b0:1fa:5c73:8e2d with SMTP id eb8csp2440417lqb; Mon, 27 May 2024 22:41:19 -0700 (PDT) X-Forwarded-Encrypted: i=3; AJvYcCW78yXpH4Lxqvvx1DvT1+FeWhVwufgERXTxEpHjAHteuuqVfRx6FmQo4AQNpLS/JjVjMK+1lwwWAT25FDVwPvVbQ6fTPFLkmJbRa4tD9g== X-Google-Smtp-Source: AGHT+IFuWD/QIY+T7Z3Kbfp+Ak717e9J3IbQ+8DMcQjqmXKYWdUD1pko8oTBep5HuNEYFsE51RD1 X-Received: by 2002:a17:903:41c8:b0:1f4:b410:dc14 with SMTP id d9443c01a7336-1f4b410df0bmr31059385ad.67.1716874879334; Mon, 27 May 2024 22:41:19 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1716874879; cv=pass; d=google.com; s=arc-20160816; b=WVumOXo9PCFZezL3o+Ab4djZSRbJLZCQ+LHKINwGZCZwQLxmN4XVq1XVtbpDPgn+aZ yC5bdK1+OhAq7BL0/dxwENZvAVpF+uZ11xs7vNjjC59QJmDZQerjp9kF0dzcd7amGq3o 6rHIKlIw853e673YrgKzjT0B7rCKekNonfVd8trDQa1YumaV2/wwmCS/PlGb6s65wdHn IsQc+4V0JuFDW3qYqAls419LG1oyNoCvRY6i258vD7u+YIgS5iOcF3bPvqtQAkBayHO9 26Rkf/wBy5U8/fJ7ypWmQpFxIGYSn4yQqWFuJ6nR9weI463f0CfBYItPqkp8gz47Q4AN Kojw== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:list-unsubscribe:list-subscribe:list-id:precedence :references:message-id:subject:cc:to:from:date:dkim-signature; bh=DfrG9iWn1442WknkaKDRyPWtWNyqdvfmJjsbe7kyD0A=; fh=MoM8+F2NpegjjvtdpwtMVqhlzhKILHZR/vfjTsXu0uQ=; b=ZrBYFTTsHwn8o1koYk1WMw1bBGUIWOXbLv9CzWEgJXLn1YAQ19noeegWg46KzMSY/T mJO8yk1mBpeRUkDucoiU+gMp9Q398eUN9dKoDv6KHx3TAaldR4oYAm2WU6ZaZgeyJ7FZ QSYyU6h8ANJPz2sxdM3GsaOipsOE+HoY2jkLuR5XVnRB4CWBbQi/MT64+A6SErjPgV2h ybPv/qUUoqrldSUc83loU0vxS/uNlV96LBizXM1nXUKQQrhO8C6/rjvTGtVDKDh1GGSN MSdnjhLByiswMwVVz5q6VtQ4QattqI30+w80KqmBL925rlQSmbkqj2s5Vb6QwWnBLn09 /UOw==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@weissschuh.net header.s=mail header.b=Td8z5VNt; arc=pass (i=1 spf=pass spfdomain=weissschuh.net dkim=pass dkdomain=weissschuh.net dmarc=pass fromdomain=weissschuh.net); spf=pass (google.com: domain of linux-kernel+bounces-191782-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-191782-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=weissschuh.net Return-Path: Received: from sv.mirrors.kernel.org (sv.mirrors.kernel.org. [2604:1380:45e3:2400::1]) by mx.google.com with ESMTPS id d9443c01a7336-1f44c970900si73557875ad.223.2024.05.27.22.41.19 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 27 May 2024 22:41:19 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel+bounces-191782-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) client-ip=2604:1380:45e3:2400::1; Authentication-Results: mx.google.com; dkim=pass header.i=@weissschuh.net header.s=mail header.b=Td8z5VNt; arc=pass (i=1 spf=pass spfdomain=weissschuh.net dkim=pass dkdomain=weissschuh.net dmarc=pass fromdomain=weissschuh.net); spf=pass (google.com: domain of linux-kernel+bounces-191782-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-191782-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=weissschuh.net Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sv.mirrors.kernel.org (Postfix) with ESMTPS id E6429283027 for ; Tue, 28 May 2024 05:41:18 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 0008B4D59B; Tue, 28 May 2024 05:41:13 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=weissschuh.net header.i=@weissschuh.net header.b="Td8z5VNt" Received: from todd.t-8ch.de (todd.t-8ch.de [159.69.126.157]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id CFA2B40BE5; Tue, 28 May 2024 05:41:11 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=159.69.126.157 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1716874873; cv=none; b=UCbutdUbNpxtUTUg4qPDUY/scGUh9Dra0Zw+bZiP2YyDHZRIPO9pc+fSmDeKGFwKvsRj4LNlQaRnhXOo7AvvR5dJ/gagzkwsAYCGcyF63lpdHFPClGSs6w8Jn7eH1M6TRJOEimfn/M+8QaSJkllMNcaAKaM8lY3aBC6ttteUV4Y= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1716874873; c=relaxed/simple; bh=Ed6LE+X1MIVzGMmlXw4d0umQaiRtTlhp8W/JqWUNy5s=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=ddeHIXs2galWJh15SA3p+kQn6EfdF/0Zipw49gfdu4/JmUGa8mVraNl9kmd9t2Whgkg5rE0Ed18gT/hlNYIyfM6CBA5ZrwJt5Ldb46AGBjPsZoOLnZL5QcXZKRn0l2YDJd9ypNWRC3y12CNKplb5p5uX8aAKIUFi22YEXHb84so= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=weissschuh.net; spf=pass smtp.mailfrom=weissschuh.net; dkim=pass (1024-bit key) header.d=weissschuh.net header.i=@weissschuh.net header.b=Td8z5VNt; arc=none smtp.client-ip=159.69.126.157 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=weissschuh.net Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=weissschuh.net DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=weissschuh.net; s=mail; t=1716874870; bh=Ed6LE+X1MIVzGMmlXw4d0umQaiRtTlhp8W/JqWUNy5s=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=Td8z5VNtZnV8QpLSTIuL/fqrxdIzYaxeXqlNPGy+KLy+1PhAZML8oSspaR+aU+rJf b61QAaikCWLrr2lfSrzwbXCFTq+8Xfg3rX0ebGIVoQtsm3DiOKmbIPICBIcwNUJRd+ kkVl/X6cxwMik6SS7oKzSa2Kx5nBRMrxS0U8+Kuc= Date: Tue, 28 May 2024 07:41:09 +0200 From: Thomas =?utf-8?Q?Wei=C3=9Fschuh?= To: Tzung-Bi Shih Cc: Lee Jones , Benson Leung , Guenter Roeck , Pavel Machek , chrome-platform@lists.linux.dev, linux-kernel@vger.kernel.org, Dustin Howett , Mario Limonciello , linux-leds@vger.kernel.org, Rajas Paranjpe Subject: Re: [PATCH v3 3/4] platform/chrome: cros_kbd_led_backlight: allow binding through mfd device Message-ID: <4b5d7db0-4454-4c69-b2c4-9ad652eade76@t-8ch.de> References: <20240526-cros_ec-kbd-led-framework-v3-0-ee577415a521@weissschuh.net> <20240526-cros_ec-kbd-led-framework-v3-3-ee577415a521@weissschuh.net> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: On 2024-05-28 05:37:32+0000, Tzung-Bi Shih wrote: > On Sun, May 26, 2024 at 08:17:17PM +0200, Thomas Weißschuh wrote: > > +#if IS_ENABLED(CONFIG_MFD_CROS_EC_DEV) > [...] > > +static const struct keyboard_led_drvdata keyboard_led_drvdata_ec_pwm_mfd = { > > + .init = keyboard_led_init_ec_pwm_mfd, > > + .brightness_set_blocking = keyboard_led_set_brightness_ec_pwm, > > + .brightness_get = keyboard_led_get_brightness_ec_pwm, > > They are only available if IS_ENABLED(CONFIG_CROS_EC). config MFD_CROS_EC_DEV depends on CROS_EC Do you prefer this to be spelled out explicitly somewhere?