Received: by 2002:a89:d88:0:b0:1fa:5c73:8e2d with SMTP id eb8csp2449747lqb; Mon, 27 May 2024 23:09:41 -0700 (PDT) X-Forwarded-Encrypted: i=3; AJvYcCWO2yWIPwaTnZS05lA33YOhsJMwJvNUf8zKmdsEZobtV6mfsYoIpgy2zQ+1OpA7aNj049PcKR4tKqjePcTkpv+au3rbow3GnKGQ0IOS+A== X-Google-Smtp-Source: AGHT+IHtOx6IkxhfT9SC6gpa62xkKt3x6VpPIvS7ql8j3pZq6AxeXkXPA/kdZUN7TQzBVIQbjffP X-Received: by 2002:a05:6870:b14a:b0:24f:d207:2e00 with SMTP id 586e51a60fabf-24fd28b8096mr9507030fac.51.1716876581515; Mon, 27 May 2024 23:09:41 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1716876581; cv=pass; d=google.com; s=arc-20160816; b=HvmZILi13eaQQEd5WJzMJRp4p/7WCjlPIrsuVi5O9Q8vPDt5308g1UqCHeb8kjZMbR E6xwM7vlYHt2eLtX/lJ7+UBMJDvaFLIARoSGHr4TokSdFClIi18Q3mdoWOvcDT7W0BbU YO1O3KcwLNB2Rgp9tvVoPxUKh0/y6pl8s8XXj69+ravdEcBQjWFtW5TimyEqwfQ0bug4 ccCyje8MQJ6e6EbmZ0yp5Wvkw+4iBot8qwN/20ha25/55W9guTO1WtcncYv2sRLbCTJN vKpt9U9Y1Y5PuV/xwIS2a+x6zBr0RQB0WGjrF19aPhBUQ1WzKeuU2znI5CMJXQbH8l5f Nemw== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=reply-to:cc:to:content-transfer-encoding:mime-version :list-unsubscribe:list-subscribe:list-id:precedence:message-id:date :subject:from:dkim-signature; bh=1I9IU4cE2pKg+SIIWaMQBbH1l+LhAQ2Sp/7r2tQDniQ=; fh=87/eY8gQF4FDF3HwXnnmaJwLYvnDECX4QrU8m57oL/g=; b=GmZBXpRK+P/AAJRfkDdhyJhbxjcwono/GmkR5b8pQZfr/Bb7HriV+SCAO7qRLRsJR8 XRBmzAL+qaMSCystnVTvTYDbOc4JfYchFBrlt0PjkGbUfDU1IBKSUvy6rVc6KnkLPJYi HPzpvwzmFi1en0FyXVdSc2thVNk/IHaF3rNeSvl76/q198CITWo3NaQ4AwJqxs7Hw/7J A/u40CQVPdsGQrA9K5/LIr6sjA2ujEetXOxik+nv5NupRCxaPUXiW9zfNouO319x+vlT lnjnga2JNk1RjtnLy99WcvNeSZ65LzbpEwgqjFDqP7axd15GerBDEuUDsH6/WwClHXHk 89fA==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=us73uEGj; arc=pass (i=1 dkim=pass dkdomain=kernel.org); spf=pass (google.com: domain of linux-kernel+bounces-191798-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-191798-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from sv.mirrors.kernel.org (sv.mirrors.kernel.org. [2604:1380:45e3:2400::1]) by mx.google.com with ESMTPS id 41be03b00d2f7-682299373aasi7415088a12.611.2024.05.27.23.09.41 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 27 May 2024 23:09:41 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel+bounces-191798-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) client-ip=2604:1380:45e3:2400::1; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=us73uEGj; arc=pass (i=1 dkim=pass dkdomain=kernel.org); spf=pass (google.com: domain of linux-kernel+bounces-191798-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-191798-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sv.mirrors.kernel.org (Postfix) with ESMTPS id 1110B283906 for ; Tue, 28 May 2024 06:09:40 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 0ECC26A039; Tue, 28 May 2024 06:09:26 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="us73uEGj" Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 2E8AD4D11B; Tue, 28 May 2024 06:09:24 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1716876565; cv=none; b=Ve/aRsjIIe2zHscHOC8gDfOwYpEAd326vTOnmHtjbN0Da+TK1kfGTzZNwGMZW11LGD9U3HotJOFzG43LD8EfAphd+gpbGrIeHtZT16nYKwuROdouUS6x/zWFR10KNr0ExT6+alOuxGxY6glunnRCMSIZx4JygfzRJGWkqLOJq1w= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1716876565; c=relaxed/simple; bh=yL9QuRyCclHUhhy3AcGDuaeU09XaZ3aXaTF2FrRGqEQ=; h=From:Subject:Date:Message-Id:MIME-Version:Content-Type:To:Cc; b=OSoweSt6w/mzBWFBc9RC0B9erqxoBu1ZUa3Knb9eLNpoUagtP+8eQKc5TMMprK6jIPonODUnfb7IS4xiWkbsPBDZTWtGYZzBEh3IBQmBmyFBtRrhVdgEJiu/mDr2qjDycibGjKylYWIunhaXN0f+Fniuwwy2wlnxDmE0BcfO+sg= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=us73uEGj; arc=none smtp.client-ip=10.30.226.201 Received: by smtp.kernel.org (Postfix) with ESMTPS id B9BF2C3277B; Tue, 28 May 2024 06:09:24 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1716876564; bh=yL9QuRyCclHUhhy3AcGDuaeU09XaZ3aXaTF2FrRGqEQ=; h=From:Subject:Date:To:Cc:Reply-To:From; b=us73uEGjnmXxoVlTmdl967pSD78BNNqud12LFijTKsZ1Bm1FkQ7zo73RMV5o6hgwl rKNcCFR4a+ELHaPxcspIISmS2X9Eb8MQ4Z3s8Ygw7Qk4AzBUvlfC2aLTr88x8jAKV0 DOSRa96vRPaixa1kgKKHYjVqbCUpi8Fw8dj8bAyeE4rJ0hwS4aPw8o43HTP18XcavV IeRppfFRgamIMdCMD9FG+HEa+Tpgjh2Y5BxHGGSfxiQHGOyxv1U3VhmcmXPi8M2QWq kFA5dLvsTplDyM5JGD3RwZPhxJJ6QVVwus1p0MLRb/vB7IJQc0UdioaMnjDu7AHO9S lfPaBB8/iShdw== Received: from aws-us-west-2-korg-lkml-1.web.codeaurora.org (localhost.localdomain [127.0.0.1]) by smtp.lore.kernel.org (Postfix) with ESMTP id A38BCC25B78; Tue, 28 May 2024 06:09:24 +0000 (UTC) From: Nikita Shubin via B4 Relay Subject: [PATCH v2 0/3] dmaengine: ioatdma: Fix mem leakage series Date: Tue, 28 May 2024 09:09:22 +0300 Message-Id: <20240528-ioatdma-fixes-v2-0-a9f2fbe26ab1@yadro.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit X-B4-Tracking: v=1; b=H4sIABJ1VWYC/3WNMQ6DMAxFr4I8NxVEIKBT71ExOI5TPEAqB6Eix N0b2Du+9/X0d0iswgkexQ7KqySJcwZ7K4BGnN9sxGcGW9q6bGxtJOLiJzRBvpwMdoHIY+9820N uHCY2TnGm8awmTAvrOXyUryLb15B5lLRE3a7ftTrtv4u1MqVxbdeEKrRIRM8NvcY7xQmG4zh+i CioVsMAAAA= To: Vinod Koul , Dave Jiang , Logan Gunthorpe Cc: Andy Shevchenko , Nikita Shubin , dmaengine@vger.kernel.org, linux-kernel@vger.kernel.org, linux@yadro.com, Nikita Shubin X-Mailer: b4 0.13.0 X-Developer-Signature: v=1; a=ed25519-sha256; t=1716876563; l=1143; i=n.shubin@yadro.com; s=20230718; h=from:subject:message-id; bh=yL9QuRyCclHUhhy3AcGDuaeU09XaZ3aXaTF2FrRGqEQ=; b=K4gvr1A5/gyMVLHQfIfsxddXfjDgycKJo70pdAg85txaURyEa+qlUCFPsS5oPFoUE7Sg1sKc6lG8 rm8wd6zPD+hBhf85i+hCRkyQERBYdLmxp7yd95vJWjTCJIIqhNon X-Developer-Key: i=n.shubin@yadro.com; a=ed25519; pk=vqf5YIUJ7BJv3EJFaNNxWZgGuMgDH6rwufTLflwU9ac= X-Endpoint-Received: by B4 Relay for n.shubin@yadro.com/20230718 with auth_id=161 X-Original-From: Nikita Shubin Reply-To: n.shubin@yadro.com Started with observing leakage in patch 3, investigating revealed much more problems in probing error path. Andy you are always welcome to review if you have a spare time. Thank you Andy and Markus for your comments. Signed-off-by: Nikita Shubin --- Changes in v2: - dmaengine: ioatdma: Fix error path in ioat3_dma_probe(): Markus: - fix typo - dmaengine: ioatdma: Fix kmemleak in ioat_pci_probe() Andy: - s/int/unsigned int/ - fix spelling errors - trimmed kmemleak reports - Link to v1: https://lore.kernel.org/r/20240524-ioatdma-fixes-v1-0-b785f1f7accc@yadro.com --- Nikita Shubin (3): dmaengine: ioatdma: Fix leaking on version mismatch dmaengine: ioatdma: Fix error path in ioat3_dma_probe() dmaengine: ioatdma: Fix kmemleak in ioat_pci_probe() drivers/dma/ioat/init.c | 54 ++++++++++++++++++++++++++----------------------- 1 file changed, 29 insertions(+), 25 deletions(-) --- base-commit: 6d69b6c12fce479fde7bc06f686212451688a102 change-id: 20240524-ioatdma-fixes-a8fccda9bd79 Best regards, -- Nikita Shubin