Received-SPF: pass (google.com: domain of linux-kernel+bounces-191860-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.48.161 as permitted sender) client-ip=147.75.48.161;
Precedence: bulk
MIME-Version: 1.0
References: <zhtllemg2gcex7hwybjzoavzrsnrwheuxtswqyo3mn2dlhsxbx@dkfnr5zx3r2x> <202405191921.C218169@keescook>
In-Reply-To: <202405191921.C218169@keescook>
From: Geert Uytterhoeven <geert@linux-m68k.org>
Date: Tue, 28 May 2024 09:18:24 +0200
Message-ID: <CAMuHMdUUTy7G6fUa7+P+ZionsiYag-ni_K4smcp6j=gFb9RJJg@mail.gmail.com>
Subject: Re: [GIT PULL] bcachefs updates fro 6.10-rc1
To: Kent Overstreet <kent.overstreet@linux.dev>
Cc: Kees Cook <keescook@chromium.org>, Stephen Rothwell <sfr@canb.auug.org.au>, 
	Linus Torvalds <torvalds@linux-foundation.org>, linux-bcachefs@vger.kernel.org, 
	linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

Hi Kent,

On Mon, May 20, 2024 at 4:39=E2=80=AFAM Kees Cook <keescook@chromium.org> w=
rote:
> On Sun, May 19, 2024 at 12:14:34PM -0400, Kent Overstreet wrote:
> > [...]
> > bcachefs changes for 6.10-rc1
> > [...]
> >       bcachefs: bch2_btree_path_to_text()
>
> Hi Kent,
>
> I've asked after this before[1], but there continues to be a lot of
> bcachefs development going on that is only visible when it appears in
> -next or during the merge window. I cannot find the above commit on
> any mailing list on lore.kernel.org[2]. The rules for -next are clear:
> patches _must_ appear on a list _somewhere_ before they land in -next
> (much less Linus's tree). The point is to get additional reviews, and
> to serve as a focal point for any discussions that pop up over a given
> change. Please adjust the bcachefs development workflow to address this.

This morning, the kisskb build service informed me about several build
failures on m68k (e.g. [1]).

In fact, the kernel test robot had already detected them on multiple 32-bit
platforms 4 days ago:
  - Subject: [bcachefs:bcachefs-testing 21/23] fs/bcachefs/btree_io.c:542:7=
:
    warning: format specifies type 'size_t' (aka 'unsigned int') but the
    argument has type 'unsigned long'[2]
  - Subject: [bcachefs:bcachefs-testing 21/23] fs/bcachefs/btree_io.c:541:3=
3:
    warning: format '%zu' expects argument of type 'size_t', but argument
    3 has type 'long unsigned int'[3]

These are caused by commit 1d34085cde461893 ("bcachefs:
Plumb bkey into __btree_err()"), which is nowhere to be found on
any public mailing list archived by lore.

+               prt_printf(out, " bset byte offset %zu",
+                          (unsigned long)(void *)k -
+                          ((unsigned long)(void *)i & ~511UL));

Please stop committing private unreviewed patches to linux-next,
as I have asked before [4].
Thank you!

[1]http://kisskb.ellerman.id.au/kisskb/buildresult/15176487/
[2] https://lore.kernel.org/all/202405250948.JeFBsoxZ-lkp@intel.com/
[3] https://lore.kernel.org/all/202405250757.U8G0SdUV-lkp@intel.com/
[4] https://lore.kernel.org/all/CAMuHMdX04q-af8BVWqGgeG5gkZrrDJWsnrJh5j=3DX=
G97vrdTQrg@mail.gmail.com/

Gr{oetje,eeting}s,

                        Geert


--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k=
org

In personal conversations with technical people, I call myself a hacker. Bu=
t
when I'm talking to journalists I just say "programmer" or something like t=
hat.
                                -- Linus Torvalds