Received-SPF: pass (google.com: domain of linux-kernel+bounces-191892-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) client-ip=2604:1380:45d1:ec00::1;
From: Xu Yang <xu.yang_2@nxp.com>
To: frank.li@nxp.com,
	will@kernel.org,
	mark.rutland@arm.com,
	robh+dt@kernel.org,
	krzysztof.kozlowski+dt@linaro.org,
	conor+dt@kernel.org,
	shawnguo@kernel.org,
	s.hauer@pengutronix.de,
	kernel@pengutronix.de,
	festevam@gmail.com,
	john.g.garry@oracle.com,
	jolsa@kernel.org,
	namhyung@kernel.org,
	irogers@google.com
Cc: mike.leach@linaro.org,
	peterz@infradead.org,
	mingo@redhat.com,
	acme@kernel.org,
	alexander.shishkin@linux.intel.com,
	adrian.hunter@intel.com,
	linux-arm-kernel@lists.infradead.org,
	devicetree@vger.kernel.org,
	linux-kernel@vger.kernel.org,
	linux-perf-users@vger.kernel.org,
	imx@lists.linux.dev
Subject: [PATCH v11 5/8] perf: imx_perf: fix counter start and config sequence
Date: Wed, 29 May 2024 00:05:20 +0800
Message-Id: <20240528160523.1695953-5-xu.yang_2@nxp.com>
In-Reply-To: <20240528160523.1695953-1-xu.yang_2@nxp.com>
References: <20240528160523.1695953-1-xu.yang_2@nxp.com>
Content-Transfer-Encoding: 8bit
Content-Type: text/plain
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?us-ascii?Q?lDRkQX5776YzdLJR1ilwkVzqVw9ES+HLDWvXu7edY9eii4rodv+7K40HPo5H?=
 =?us-ascii?Q?BWjOzY8n2z/8SpO1wZWBQVQFD25WLVVTQBTXeOMG7JgZNXRnbhhSfhtZB3Bs?=
 =?us-ascii?Q?4g/a7sBqXC3z23LsHrlvzmBIIxJEaluUFeWDwdDOmjXKY9JC8ek8zEsSWolp?=
 =?us-ascii?Q?KUuA7eYVH4LUTv8LL7DEqH5Y2GlpfwZ0cXP8/+G1b7gUysXRBrj5jJtzl6L6?=
 =?us-ascii?Q?n5oYRjXxEYtjQ5d4euDlu/DwLAW/qo95tKGnG1YIfVGcXSKR+HtHaXW+wiPX?=
 =?us-ascii?Q?bRaSCaBq0ZdW4SY9tVZD177ZBrzPnAttJcCiBOwX7U8LJDqAqLMTqdCj1vhf?=
 =?us-ascii?Q?B6Fy7nFgDIofqWfeV3XVW6jEHFZcuFDJrjh/hl/gM0W7eZzn7Xz84Iq9WYtJ?=
 =?us-ascii?Q?b6dKxt6rAfYzCEt6DdSToFkbHq+qpihGx4Rp0NO/uI7AfEHeTiX8NeJkzJP+?=
 =?us-ascii?Q?3qU7sW1B/q2vnUgcov6AR2NP+HRIHR3qrU+q3ifMiCnH5/vHiHXCdLBLnuFY?=
 =?us-ascii?Q?zQL7Y/mMgmMrRnHaT2T4fIyRqbGSDDDvcDIUQUo1DV74a7t0Ooym/9t1fvXF?=
 =?us-ascii?Q?j3Cv+26gEdSwOpfFAPb8YnlLkVdlAsvaaQz0uU3poIFLwsCO6ul8U/fEmydx?=
 =?us-ascii?Q?fBjGuXNtOVTpdl1LHEag4qklRQWAWN++xbzUIL7pvq1AAH6xFJXv6zLyWRQZ?=
 =?us-ascii?Q?LM9yD8WNBIjgLrD5GUMpNaZ5WPTAuriaajHUE8ADr8OjlWMyF8CNzaj7K3ak?=
 =?us-ascii?Q?7XtOO3BtUOvzdbRReXJw/LJ0Q3d1G2mUsK5BWZLRFgtWvz2b5KePRtaw70Qp?=
 =?us-ascii?Q?Ul4e75YrFpjyJDC4WIAMYpPQrn1EmVnFlnZxEn/9ryH4Tf1D4TirN0pfOd2k?=
 =?us-ascii?Q?29mbfUtaxU8nFHQocJyTz8C+SB56UVLILaAA/geLWRbOSOLQN4lj2m4qaVjo?=
 =?us-ascii?Q?CSLjePXboe/OMDCAxxCzhJWfXihXFkAtwgKueFLY/UfAL3QhXVRsZgmLAn0E?=
 =?us-ascii?Q?YDPqMTSVpa2lg0oF1NPfHT5YQA1mBDVHNBRD+wWHFBDM8Jj6ZIdWtNJhgv1d?=
 =?us-ascii?Q?ETI90oaeA4iCXC/dvE1gVPWE8eKX/lRFjt72uChiRkHcn6OSPEXyJQHBNuaF?=
 =?us-ascii?Q?Ip3ZFyidS4v2oKSjiGdj1pTNuqmLwT1s3OOYkxbjDRwGnR2Z2rkLNME/uEVI?=
 =?us-ascii?Q?+nA/2YB6grSxijjiDUkictG06xQPGLqWyMxkqNDWq/SQN+T6yRgeqlhAfTw8?=
 =?us-ascii?Q?EmCzs2kvujC2EoEMTHbdTX1rBI9K89NY+HWUIn/T3HLgXclkyPqeqrXpuHCI?=
 =?us-ascii?Q?3r3bY3QPbImYhA80rDMd9yo4U0hxZBmNyZVEXogOXpdZENDn0JamPEL7obQw?=
 =?us-ascii?Q?rzvaC5Sf2bf61nBwW4ZLaqSPA4nz7ODF726g1inQCS7BdVndW84ewRF6Bohx?=
 =?us-ascii?Q?NBtCBVyxLNUHXkELlUQMRtbKVRiMsSZMBZJIjOs9J+Oz7kRw7HzR6HjTW2Ro?=
 =?us-ascii?Q?bOr3QcifJEWJAfdwYnXK1a1T2MCXMCGoKw+EuXnREAxnSJV789CkcvVWIVkD?=
 =?us-ascii?Q?2pgowv3AuWT1HNU/CeRMlhMTL8MHXGefYb2gzjFV?=
X-OriginatorOrg: nxp.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 9427b489-d43c-41e3-9558-08dc7eebe218
X-MS-Exchange-CrossTenant-AuthSource: DU2PR04MB8822.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 28 May 2024 07:57:56.0095
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 0sNSxjMAdbHvEZT8TPH4QcclO4+LQ3TLGb4gER6KUy4WDHx/ZaFbibVTNPoCLZmEdrv+jimLpVHjqdNhkh6vKw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: VE1PR04MB7229

In current driver, the counter will start firstly and then be configured.
This sequence is not correct for AXI filter events since the correct
AXI_MASK and AXI_ID are not set yet. Then the results may be inaccurate.

Reviewed-by: Frank Li <Frank.Li@nxp.com>
Fixes: 55691f99d417 ("drivers/perf: imx_ddr: Add support for NXP i.MX9 SoC DDRC PMU driver")
cc: <stable@vger.kernel.org>
Signed-off-by: Xu Yang <xu.yang_2@nxp.com>

---
Changes in v5:
 - new patch
Changes in v6:
 - no changes
Changes in v7:
 - no changes
Changes in v8:
 - add fix tag
Changes in v9:
 - add Rb tag
Changes in v10:
 - no changes
Changes in v11:
 - no changes
---
 drivers/perf/fsl_imx9_ddr_perf.c | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/drivers/perf/fsl_imx9_ddr_perf.c b/drivers/perf/fsl_imx9_ddr_perf.c
index d1c5495d5e48..26144916dba7 100644
--- a/drivers/perf/fsl_imx9_ddr_perf.c
+++ b/drivers/perf/fsl_imx9_ddr_perf.c
@@ -541,12 +541,12 @@ static int ddr_perf_event_add(struct perf_event *event, int flags)
 	hwc->idx = counter;
 	hwc->state |= PERF_HES_STOPPED;
 
-	if (flags & PERF_EF_START)
-		ddr_perf_event_start(event, flags);
-
 	/* read trans, write trans, read beat */
 	imx93_ddr_perf_monitor_config(pmu, event_id, counter, cfg1, cfg2);
 
+	if (flags & PERF_EF_START)
+		ddr_perf_event_start(event, flags);
+
 	return 0;
 }
 
-- 
2.34.1