Received: by 2002:a89:d88:0:b0:1fa:5c73:8e2d with SMTP id eb8csp2489948lqb; Tue, 28 May 2024 01:04:42 -0700 (PDT) X-Forwarded-Encrypted: i=3; AJvYcCUPG5O1UIwCNNeVRJIW6KTb4jxsef+TW2kDKsZm4hmepK8sBf29KxURNWl+QU/t2mVeqmcxqbiINx/wrkJJzOnZXWwTI3kxthlFDnJJrg== X-Google-Smtp-Source: AGHT+IEGVnhj1NdkfTdbVVmaP//jaIPke7jSkXDGl1OuzoK7taY7bBdzhb84rre1uX69+2IsVzwN X-Received: by 2002:a05:6358:e48e:b0:194:9edb:f7fc with SMTP id e5c5f4694b2df-197e565d810mr1454639355d.21.1716883482056; Tue, 28 May 2024 01:04:42 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1716883482; cv=pass; d=google.com; s=arc-20160816; b=e8wX6oP2n5jQCcGtjlzEiHHnY55qIUqx8EqLcURCTRnCy85Oa4qp3PVaMUmqzlC5RR cKHUxQ6kLDG06zkvSoUrOvRGAgd2sKv1NNsZqraK+R8arHc5RB1kMYQ9K10pXEu0ieIm MNzStwcGcf7W+MmYFvdwkqoy+xLjaVv1AhT9GABmqG1n5ZmlbQA1b0ltjuWftjzNz/oC bLu13QMuhCF1qsf9NGvTjZ77p38mHAMmIUBTQM/d8xxSgsdFS3TaOeWME5IVW0La/c+i RigDXqvDnPpTYlE9cY2r6Kuiq9TknSuTpwoxQMyJCpBLK7rbFrDGEgWWDWnOXs9QEqw7 blGg== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=ui-outboundreport:content-transfer-encoding:in-reply-to:from :content-language:subject:references:cc:to:user-agent:mime-version :list-unsubscribe:list-subscribe:list-id:precedence:date:message-id :dkim-signature; bh=bbgNyi/+EIYLCzUxZT7diaC1goU6a+vThPNJP//ZidE=; fh=pMqaSIT64p5hOidozoWaXN8iazK+rg734Oq5CtiW2ek=; b=DQIdaAxuRJnmG6uKBV5gSlCQaH9YSrsIT4ohFM3S84b1nCy+pbla5KmhxO8O0yleQ4 oFdWEmlr9raLfhEqT0m23m7j4boanFLhiB5kRm3bkuogYA7KjhE+bi4uGlX+KMXf8HjN ZeqCVgFipC0QT5uvc3pnXpeh4/tAuI6ByogyDgCfOGpvvBK5vAPjvELwmNehC3gyxgvm 6Rf1pjksd+4GCD/o2G7ezMl1D8Q/nzR0BLqic4rgvO9uG4nT4BdL0Ca/2EOHHon9E62C xuAT3a8vg5S7Ps/8JSkVxuUGoZxRRdbu6THEgbbgdy86nV9bemUnID8iUMgbIotwAhG1 nsBA==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@web.de header.s=s29768273 header.b=uykWsVUR; arc=pass (i=1 spf=pass spfdomain=web.de dkim=pass dkdomain=web.de dmarc=pass fromdomain=web.de); spf=pass (google.com: domain of linux-kernel+bounces-191899-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.48.161 as permitted sender) smtp.mailfrom="linux-kernel+bounces-191899-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=web.de Return-Path: Received: from sy.mirrors.kernel.org (sy.mirrors.kernel.org. [147.75.48.161]) by mx.google.com with ESMTPS id 41be03b00d2f7-68221c6a221si5130846a12.159.2024.05.28.01.04.41 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 28 May 2024 01:04:42 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel+bounces-191899-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.48.161 as permitted sender) client-ip=147.75.48.161; Authentication-Results: mx.google.com; dkim=pass header.i=@web.de header.s=s29768273 header.b=uykWsVUR; arc=pass (i=1 spf=pass spfdomain=web.de dkim=pass dkdomain=web.de dmarc=pass fromdomain=web.de); spf=pass (google.com: domain of linux-kernel+bounces-191899-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.48.161 as permitted sender) smtp.mailfrom="linux-kernel+bounces-191899-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=web.de Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sy.mirrors.kernel.org (Postfix) with ESMTPS id 7D9F8B225BA for ; Tue, 28 May 2024 08:04:35 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 48FB813541E; Tue, 28 May 2024 08:04:30 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=web.de header.i=markus.elfring@web.de header.b="uykWsVUR" Received: from mout.web.de (mout.web.de [212.227.17.12]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id CB72350297 for ; Tue, 28 May 2024 08:04:26 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=212.227.17.12 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1716883469; cv=none; b=gapP4T5ZbrCB1ecoe3q+nqffFYnFkqFKo3/MAnH1st4kXH9Sic5bGYuy+6IQQdHpLfp9laLRO/s2Y38gXlAOlGFaUNFdq3ne68qWGsK3Dlv3mOvSGdahS4lD3abC/Z93ePYKTFBwmp7B/3WV0aUs1+ELZYCIgctgL8PXaJdH3HM= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1716883469; c=relaxed/simple; bh=4RV5VbKP+X5saQ/w7slHvHhnTf+qNYOaQ4+j0g7V21w=; h=Message-ID:Date:MIME-Version:To:Cc:References:Subject:From: In-Reply-To:Content-Type; b=VCT2WAEznQ8IocVSySyq5dSpqrZlasXW77l7M9Kis0JhZTQwvMeR/Zn3H4PMtoll1HaNqmpakQYdIKzBcrLX50S4qBY3D73qhYfYSUpf2YN4oDZ3Powhi3guoxal3vWtF0q7qijNxDwm6rLD128P7oQpN530GtNYKEkorN6N9tk= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=web.de; spf=pass smtp.mailfrom=web.de; dkim=pass (2048-bit key) header.d=web.de header.i=markus.elfring@web.de header.b=uykWsVUR; arc=none smtp.client-ip=212.227.17.12 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=web.de Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=web.de DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=web.de; s=s29768273; t=1716883436; x=1717488236; i=markus.elfring@web.de; bh=bbgNyi/+EIYLCzUxZT7diaC1goU6a+vThPNJP//ZidE=; h=X-UI-Sender-Class:Message-ID:Date:MIME-Version:To:Cc:References: Subject:From:In-Reply-To:Content-Type:Content-Transfer-Encoding: cc:content-transfer-encoding:content-type:date:from:message-id: mime-version:reply-to:subject:to; b=uykWsVURrjxDnWqaZnMuvEx5oVNIAMOO6IQNIWJk/il44crEcbf5/4s+QZeCcsX3 mZ5dEU4OC3aiw7GE1So+PyjDO31n7A8N6JJ+kip2vDAkbh0O3DPB0KSMDnYiqPvzE 58IvBT7707j7ZM2u8derGaGkNjZSHeKz//lLviJK8EMFjOOEnMpo9eisTE58zJbe4 LTGfc1hZWQGqDPOdQqXwZGPqrtH3O1TYQU3hNWYmilv7hKJWlGZUjB7vwKqciHCn7 IYImt1pylv0owRlOIbUNde7lPi0Ri8bloYrTQNW88tFKRLISth4SEEp+q3LhCl3oT rORrnhVT3+Bv9LYImg== X-UI-Sender-Class: 814a7b36-bfc1-4dae-8640-3722d8ec6cd6 Received: from [192.168.178.21] ([94.31.83.95]) by smtp.web.de (mrweb105 [213.165.67.124]) with ESMTPSA (Nemesis) id 1MS17h-1s5dJv04kt-00QESD; Tue, 28 May 2024 10:03:56 +0200 Message-ID: <1b4714f8-eb5c-40c6-aa3f-eb6eb7be209e@web.de> Date: Tue, 28 May 2024 10:03:53 +0200 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird To: Li zeming , Ben Segall , Daniel Bristot de Oliveira , Dietmar Eggemann , Ingo Molnar , Juri Lelli , Mel Gorman , Peter Zijlstra , Steven Rostedt , Valentin Schneider , Vincent Guittot Cc: LKML References: <20240528071446.59197-1-zeming@nfschina.com> Subject: =?UTF-8?Q?Re=3A_=5BPATCH=5D_sched=3A_core=3A_Remove_unnecessary_?= =?UTF-8?B?4oCYTlVMTOKAmSB2YWx1ZXMgZnJvbSBjb3JlX3Jx?= Content-Language: en-GB From: Markus Elfring In-Reply-To: <20240528071446.59197-1-zeming@nfschina.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-Provags-ID: V03:K1:a0cuAab6fOD/m4PwL6zI56abUEI6F2kPN5j8FW4ooxxwZT5jlx6 lPkJvpfjpAdtapiNnI8clTZ3rElueoZHwz2Snh3L24cTkLDkfoM6v5FEtfiSSEuZDFZOUBs HeZN1Eclsxl1k3Tz8mOov0RrhcPd4wqWbQsLojVe+PqfSOeVd+sgc6G2MbmI0MHWolU+5Sf CcjYeIz7Jhs2NZ+IuJHGg== X-Spam-Flag: NO UI-OutboundReport: notjunk:1;M01:P0:cBzi56AyxGc=;WGe6KXMrCwTz3V1iGSlL73wsLL0 Y0NUDvRT79iedSL3ZfWIBbu5gjAplcxsC/lE73SUzDBKlk6Rkq2M//YhluNUHGlgqukxOS7gh vKuDMTr2fvbK+OqZ7NU3qODKTkGHFZ07gvPMWIfOReEKSdeMHEDBNB9ttX4wFYbXPgL1lJUbR LYyacvgI/BDzjgRqQKNZmvGG7ud4CB4d3QA5zwmtIqWYtLNViBbX2hZNanLIriplXRVQkhJmp f8Un7nhPOluvnBOMTzTFhRmMb5FrAUa/zlhYOnIfcBDKPDz98rRNgyjjrS0FUjtSEt6JNDkT+ wKb8j8IbwC6DFR6uBuWZ0fa818Rfo3l8MTtBQzgPajsOCqMHV6x2xvUPWvUKHrws9jxICxniB 7NiQHqqBtRJopGamrIvi0gRQXj2JMqphg3MOXoan9ySsCaxfnG88SP2KkD/a0olpRqwD6dp1C Yg/tdBhUH+byrlml2wDkhm3ri2VZRAC5WdPW8EQo6GSs6FePKmBMXHenYLCatK4d0dowWf+Mo IZrblfET0AQ/5mDGCLFefZsK9ZSVk+wb2/hqTqun+K401wOPMQ3vxst0Wn+JjldZminxHVnzf bJzSnbcGJer4L/GEXMJMRC/seOvmu8/ykXfc/Ke+KHUArfc3nAWPBHt0IPhtu/Hb1LbFBuJ6j r1Q3ghrWWC/O5RYpUCQFqMy5iqJT/BfziCjDQeubS9YGa9dPb59PzkCVyVoy/FENUQ0Xzs9hN 6wjkI8BWL4fiJv2/6QZ+UVmgfWkeDJBKR0HmvJ2rlpkU1wG5YKHMCgzUqg+/nqzFgbykvC9m8 a8J/sLhRkQhJtLPZrENhd5GwI8wNkKzGg9rNxb4t4no8c= > core_rq is assigned first, so it does not need to initialize the > assignment. * Would a wording approach (like the following) be a bit nicer? The variable =E2=80=9Ccore_rq=E2=80=9D will eventually be set to an appr= opriate pointer a bit later. Thus omit the explicit initialisation at the beginning. * How do you think about to use the summary phrase =E2=80=9CDelete an unnecessary initialisation in sched_core_cpu_deactiva= te()=E2=80=9D? Regards, Markus