Received-SPF: pass (google.com: domain of linux-kernel+bounces-191978-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) client-ip=2604:1380:45e3:2400::1;
Message-ID: <70083d10-483e-4daf-a408-020f0147c5cf@amlogic.com>
Date: Tue, 28 May 2024 17:00:11 +0800
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH 3/3] arm64: dts: amlogic: a4: add power domain controller
 node
Content-Language: en-US
To: neil.armstrong@linaro.org, Rob Herring <robh@kernel.org>,
 Krzysztof Kozlowski <krzk+dt@kernel.org>, Conor Dooley
 <conor+dt@kernel.org>, Kevin Hilman <khilman@baylibre.com>,
 Jerome Brunet <jbrunet@baylibre.com>,
 Martin Blumenstingl <martin.blumenstingl@googlemail.com>,
 Jianxin Pan <jianxin.pan@amlogic.com>, Ulf Hansson <ulf.hansson@linaro.org>
Cc: devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
 linux-amlogic@lists.infradead.org, linux-kernel@vger.kernel.org,
 linux-pm@vger.kernel.org
References: <20240528-a4_secpowerdomain-v1-0-2a9d7df9b128@amlogic.com>
 <20240528-a4_secpowerdomain-v1-3-2a9d7df9b128@amlogic.com>
 <c97b12bb-8b56-4129-a292-588226a0ec42@linaro.org>
From: Xianwei Zhao <xianwei.zhao@amlogic.com>
In-Reply-To: <c97b12bb-8b56-4129-a292-588226a0ec42@linaro.org>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?SURUMnEvMWNpRGV5TmVadllTQ0RheTNvTG0rcGdTUktoK0t2Rlc1aThXWVY1?=
 =?utf-8?B?RC9rYXBTMUsxMDhWMy9FdWpGQzFUeUE1cVJISlVDd1VXYW8wUlN6VEJUVkYw?=
 =?utf-8?B?VWwrUWRlT1Z4WFpTRUYzNjdKdXFIajlpL1E1UzI2K2dQYysyTE1aWk9kVzV0?=
 =?utf-8?B?dXR0bDExdWRqZFBpb3B0Y3YzQnpMT01rWG5YL3h5bjgxdlI4Ty8vUW1jcTMv?=
 =?utf-8?B?Y2VHNzFQQlk4OXB6alBOa1VzWEJYOXNpZkx0RDUzaGo5Y2Q0K3pnSG9UUmlu?=
 =?utf-8?B?WmxqVWh3VG1GdlVWYWdQN2oxVEJubUZCUEhITnJJajFUSjAzeWVKL2ZKTjhU?=
 =?utf-8?B?Z0FlTUhlY3Z0dU9JYUFTc0NvM2NoZ205bTV2VWZES2F0WkhRbmI0dnBRTlZX?=
 =?utf-8?B?VlhmRkR4bEVoeVpxNDhuUUpBSXBncTRISnl6WDlHLysxWk1zYlhrVjZFRk5O?=
 =?utf-8?B?WW5Jd1lYWHlGaXg4T0w1bDdKNHpPZ01Vb0EvL2tiNENYMEY2YVZVUUpVVEZJ?=
 =?utf-8?B?a0xSc1dFNE1PSHowOGhHd2VQeHpiNWgzUWZpT05YU0Q5OUYvYzJXcFZKSUxw?=
 =?utf-8?B?TzE0UnU3SG91Q1ozK2NSZEQrVE9Ka1BJYStwaTN0aU10dGx3bTN2c0drcktk?=
 =?utf-8?B?aE5mMVFnaEQzU205UmFITlIzNWh0dEVYQVBuQktTbHowbjI0SENRWGNWMVZV?=
 =?utf-8?B?RDBBNWYxWjJoc0dmVTU1aHdEK29hUW1XcXJ5akxhRldnY2tzUWVTaHFvb1Rq?=
 =?utf-8?B?OUlraW80TEhUUEtKSXBqNEZSTldMU2tUQWtrRFljcTlqN0tsT3BlOEpQOWJy?=
 =?utf-8?B?OWRWQ3l4STRCVzBiSElTWkZVMUlaZmFtWEZncnE1ck0wN3JuSWtramFPREh5?=
 =?utf-8?B?WHZEZ1dXZVJORnduWFlHOHdkZ1kvODhoa3psREx3Qk9tRDBZN3JNdlBRdGx3?=
 =?utf-8?B?RUdFS2RjRi8vZmV4SWNxTnlMTjlCck5EMDVKRm1RM0JWekJYYndiM3pSZlNW?=
 =?utf-8?B?UnlkSHVveHVEVWJzOWhkRG9HQ055bHppWEtzREREU01KNHFoemgydGpXakFX?=
 =?utf-8?B?bWJZREprOTdQd3lJYnBqMnFXOGZKWmlCdFhiT3NEUFl4Z3ZHNVloOXFLMVhz?=
 =?utf-8?B?T2R5dXpGN1BTYkxJREJFeXBFYlBrbElCdHArMktsNmg2aUlSOGl4QjQ5Z3l4?=
 =?utf-8?B?YTRDQUFrUjluTnlENUhnL3gyKzFJaktWQlMyV3Fxc0MxbGZPdE9iSUlaR2J6?=
 =?utf-8?B?aXNkT3NEUklzVldMMUVIcEJDRnl1YytrWEsvbEhvRDNIOENRU1ZWblN1Y1Jt?=
 =?utf-8?B?QnJzYjRaRnkrTTVmckVNOUJjNEZQbUNvNGs4M3BhNExKUW9zM01mUDVIK3pQ?=
 =?utf-8?B?dVBWb2lpajVFMlQzMWVjWXhtRFQwR2FtVWsxVlFjWmVKc2lXWkk2d2FSNTI5?=
 =?utf-8?B?RXZEWXJJTWpoTC9mZ1BnWTBaSEV3VEdHZXZlT1RRNjNad1dRT1Nsc0tTNFVM?=
 =?utf-8?B?TnlpSCtTQ1hSTnRnWG1SSXZlN0dDT0pTZ1Y0bVRVb0dKVzFjRm1zUkMvRElL?=
 =?utf-8?B?V2NpS2tBSHp3bzFaZkFZN0cwczg4bEpaR1VlbVJCNm94ZktiSnRjTHNxVUhZ?=
 =?utf-8?B?TzJsbmx1bUl0Nit6QXY3UFlrYi9vL3d6blFRRmUyYTVnUHgrV3RqSmdvMGRU?=
 =?utf-8?B?YWxVNW9BM3F2Z0hWOW5haTc0WDR0UGVLV0l2M2NsSHZqTFNEaDlvVTdaTWpv?=
 =?utf-8?B?cEI4WitlZzVBMmlOU1BCSzNncW41S3FRQVVCZzcwNEZseng5a3kxc2l1aGw1?=
 =?utf-8?B?QnQwUlpLMzZoclRrSnh5cVphOFhmV01uNXoycUk4Ukx6NnFHK2IzNTE5TEgx?=
 =?utf-8?B?UzMvNHQxaUwvQW05MnNpb0p2Z1BRZTNYTWd1bFZWdFV5bVYxZ2NpMzh4MjJo?=
 =?utf-8?B?VHQydllSS0lkN1dYbXpLeTk3V1dkcFM5eFJ0SS9zLyt6T0U5WG94a2VNMjR4?=
 =?utf-8?B?OUZIZzQ0RzFGMzUyNlRLS0NuZ3ZteisxUGorN3Qrdy9xS2FOaGhwTnNRR3Fw?=
 =?utf-8?B?N3hlb05hVEVDdkhxeXBzQ3dOdXZzK0s4c1pYOTFINnl4UHJ5VGpLa3E5Z3Jk?=
 =?utf-8?B?L09SMVF3bjhncGNUK3VRd3orSHc0cnE2L2tpM0Z3Ylc2OWY4dkVmZnNhbHN5?=
 =?utf-8?B?Qmc9PQ==?=
X-OriginatorOrg: amlogic.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 8b584415-e1d9-46ea-6842-08dc7ef497ec
X-MS-Exchange-CrossTenant-AuthSource: TYZPR03MB6896.apcprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 28 May 2024 09:00:16.7767
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 0df2add9-25ca-4b3a-acb4-c99ddf0b1114
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: mSlISDqZNwDticQWI35iLs0bIcJwFR5oQwR8CYg1CGKJjM4sQxerU8xl18kJaWkTfEhhpv2yxce012TMHKqpQi51wyDJgjOwFt6FrlAp0kk=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: TYZPR03MB7290

Hi Neil,
    Thanks for your quickly reply.

On 2024/5/28 16:46, Neil Armstrong wrote:
> [ EXTERNAL EMAIL ]
> 
> On 28/05/2024 10:39, Xianwei Zhao via B4 Relay wrote:
>> From: Xianwei Zhao <xianwei.zhao@amlogic.com>
>>
>> Add power domain controller node for Amlogic A4 SoC
>>
>> Signed-off-by: Xianwei Zhao <xianwei.zhao@amlogic.com>
>> ---
>>   arch/arm64/boot/dts/amlogic/amlogic-a4-common.dtsi | 4 ++++
>>   arch/arm64/boot/dts/amlogic/amlogic-a4.dtsi        | 5 +++++
>>   2 files changed, 9 insertions(+)
>>
>> diff --git a/arch/arm64/boot/dts/amlogic/amlogic-a4-common.dtsi 
>> b/arch/arm64/boot/dts/amlogic/amlogic-a4-common.dtsi
>> index b6106ad4a072..eebde77ae5b4 100644
>> --- a/arch/arm64/boot/dts/amlogic/amlogic-a4-common.dtsi
>> +++ b/arch/arm64/boot/dts/amlogic/amlogic-a4-common.dtsi
>> @@ -27,6 +27,10 @@ xtal: xtal-clk {
>>               #clock-cells = <0>;
>>       };
>>
>> +     sm: secure-monitor {
>> +             compatible = "amlogic,meson-gxbb-sm";
>> +     };
>> +
>>       soc {
>>               compatible = "simple-bus";
>>               #address-cells = <2>;
>> diff --git a/arch/arm64/boot/dts/amlogic/amlogic-a4.dtsi 
>> b/arch/arm64/boot/dts/amlogic/amlogic-a4.dtsi
>> index 73ca1d7eed81..917c05219b9c 100644
>> --- a/arch/arm64/boot/dts/amlogic/amlogic-a4.dtsi
>> +++ b/arch/arm64/boot/dts/amlogic/amlogic-a4.dtsi
>> @@ -37,4 +37,9 @@ cpu3: cpu@3 {
>>                       enable-method = "psci";
>>               };
>>       };
>> +
>> +     pwrc: power-controller {
>> +             compatible = "amlogic,a4-pwrc";
>> +             #power-domain-cells = <1>;
>> +     };
> 
> pwrc is supposed to be a child of secure-monitor.
> 
Considered writing it like this when I wrote this.

Here are two approaches: one is to include secure-monitor in the comm 
dtsi and fill power-controller by aliases in dtsi of each chip, while 
the other is to directly include secure-monitor in the dtsi of each 
chip. Which one do you suggest?

> Neil
> 
>>   };
>>
>