Received-SPF: pass (google.com: domain of linux-kernel+bounces-191980-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.48.161 as permitted sender) client-ip=147.75.48.161;
From: Eric Curtin <ecurtin@redhat.com>
To: linux-unionfs@vger.kernel.org (open list:OVERLAY FILESYSTEM)
Cc: Alexander Larsson <alexl@redhat.com>,
	Eric Curtin <ecurtin@redhat.com>,
	Wei Wang <weiwang@redhat.com>,
	Miklos Szeredi <miklos@szeredi.hu>,
	Amir Goldstein <amir73il@gmail.com>,
	linux-unionfs@vger.kernel.org (open list:OVERLAY FILESYSTEM),
	linux-kernel@vger.kernel.org (open list)
Subject: [PATCH] ovl: change error message to info for empty lowerdir
Date: Tue, 28 May 2024 10:02:40 +0100
Message-ID: <20240528090244.6746-1-ecurtin@redhat.com>
Precedence: bulk
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit

In some deployments, an empty lowerdir is not considered an error.
The current implementation logs this scenario as an error during boot,
which can be misleading and cause unnecessary concern for users. This
commit changes the log level from pr_err to pr_info to reflect the
non-error nature of an empty lowerdir in these cases.

Reported-by: Wei Wang <weiwang@redhat.com>
Signed-off-by: Eric Curtin <ecurtin@redhat.com>
---
 fs/overlayfs/params.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/fs/overlayfs/params.c b/fs/overlayfs/params.c
index 4860fcc4611bb..53170d73bb79c 100644
--- a/fs/overlayfs/params.c
+++ b/fs/overlayfs/params.c
@@ -231,7 +231,7 @@ static int ovl_mount_dir_noesc(const char *name, struct path *path)
 	int err = -EINVAL;
 
 	if (!*name) {
-		pr_err("empty lowerdir\n");
+		pr_info("empty lowerdir\n");
 		goto out;
 	}
 	err = kern_path(name, LOOKUP_FOLLOW, path);
-- 
2.45.0